linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] dt-bindings: mmc: fsl-imx-esdhc: Add some compatible fallbacks
@ 2023-01-11 20:46 Andreas Kemnade
  2023-01-13 19:27 ` Rob Herring
  0 siblings, 1 reply; 2+ messages in thread
From: Andreas Kemnade @ 2023-01-11 20:46 UTC (permalink / raw)
  To: ulf.hansson, robh+dt, krzysztof.kozlowski+dt, shawnguo, s.hauer,
	kernel, festevam, linux-imx, linux-mmc, devicetree,
	linux-arm-kernel, linux-kernel
  Cc: Andreas Kemnade

Currently make dtbs_check shows lots of errors because imx*.dtsi does
not use single compatibles but combinations of them.

Add fallbacks for imx6sll/ull which are useful for U-Boot.

This will significantly reduce noise on make dtbs_check.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
Changes in v2:
- allow only combinations with fallback compatible
- reduce them to the cases where they are actually useful

 Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
index dc6256f04b42..be6caa25c57d 100644
--- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
+++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
@@ -29,14 +29,18 @@ properties:
           - fsl,imx53-esdhc
           - fsl,imx6q-usdhc
           - fsl,imx6sl-usdhc
-          - fsl,imx6sll-usdhc
           - fsl,imx6sx-usdhc
-          - fsl,imx6ull-usdhc
           - fsl,imx7d-usdhc
           - fsl,imx7ulp-usdhc
           - fsl,imx8mm-usdhc
           - fsl,imxrt1050-usdhc
           - nxp,s32g2-usdhc
+      - items:
+          - const: fsl,imx6sll-usdhc
+          - const: fsl,imx6sx-usdhc
+      - items:
+          - const: fsl,imx6ull-usdhc
+          - const: fsl,imx6sx-usdhc
       - items:
           - enum:
               - fsl,imx8mq-usdhc
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] dt-bindings: mmc: fsl-imx-esdhc: Add some compatible fallbacks
  2023-01-11 20:46 [PATCH v2] dt-bindings: mmc: fsl-imx-esdhc: Add some compatible fallbacks Andreas Kemnade
@ 2023-01-13 19:27 ` Rob Herring
  0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2023-01-13 19:27 UTC (permalink / raw)
  To: Andreas Kemnade
  Cc: ulf.hansson, krzysztof.kozlowski+dt, shawnguo, s.hauer, kernel,
	festevam, linux-imx, linux-mmc, devicetree, linux-arm-kernel,
	linux-kernel

On Wed, Jan 11, 2023 at 09:46:33PM +0100, Andreas Kemnade wrote:
> Currently make dtbs_check shows lots of errors because imx*.dtsi does
> not use single compatibles but combinations of them.
> 
> Add fallbacks for imx6sll/ull which are useful for U-Boot.
> 
> This will significantly reduce noise on make dtbs_check.
> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> Changes in v2:
> - allow only combinations with fallback compatible
> - reduce them to the cases where they are actually useful
> 
>  Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> index dc6256f04b42..be6caa25c57d 100644
> --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> @@ -29,14 +29,18 @@ properties:
>            - fsl,imx53-esdhc
>            - fsl,imx6q-usdhc
>            - fsl,imx6sl-usdhc
> -          - fsl,imx6sll-usdhc
>            - fsl,imx6sx-usdhc
> -          - fsl,imx6ull-usdhc
>            - fsl,imx7d-usdhc
>            - fsl,imx7ulp-usdhc
>            - fsl,imx8mm-usdhc
>            - fsl,imxrt1050-usdhc
>            - nxp,s32g2-usdhc
> +      - items:
> +          - const: fsl,imx6sll-usdhc
> +          - const: fsl,imx6sx-usdhc
> +      - items:
> +          - const: fsl,imx6ull-usdhc
> +          - const: fsl,imx6sx-usdhc

Can be simplified to:

- items:
    - enum:
        - fsl,imx6sll-usdhc
        - fsl,imx6ull-usdhc
    - const: fsl,imx6sx-usdhc


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-01-13 19:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-11 20:46 [PATCH v2] dt-bindings: mmc: fsl-imx-esdhc: Add some compatible fallbacks Andreas Kemnade
2023-01-13 19:27 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).