From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: "Andy Shevchenko" <andriy.shevchenko@intel.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Wolfram Sang" <wsa@kernel.org>,
"Matti Vaittinen" <Matti.Vaittinen@fi.rohmeurope.com>,
"Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Peter Rosin" <peda@axentia.se>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Michael Tretter" <m.tretter@pengutronix.de>,
"Shawn Tu" <shawnx.tu@intel.com>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Mike Pagano" <mpagano@gentoo.org>,
"Krzysztof Hałasa" <khalasa@piap.pl>,
"Marek Vasut" <marex@denx.de>,
"Luca Ceresoli" <luca@lucaceresoli.net>
Subject: Re: [PATCH v7 1/7] i2c: add I2C Address Translator (ATR) support
Date: Thu, 19 Jan 2023 14:00:56 +0100 [thread overview]
Message-ID: <20230119140056.686c0dea@booty> (raw)
In-Reply-To: <79331f60-0849-9d5a-822a-987df01a4b96@ideasonboard.com>
Hi Tomi, Andy,
On Thu, 19 Jan 2023 14:22:26 +0200
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> wrote:
> On 19/01/2023 13:35, Luca Ceresoli wrote:
> > Hi Tomi, Andy,
> >
> > On Thu, 19 Jan 2023 12:09:57 +0200
> > Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> wrote:
> >
> >> On 19/01/2023 10:21, Luca Ceresoli wrote:
> >>
> >> <snip>
> >>
> >>>>>>> +void i2c_atr_set_driver_data(struct i2c_atr *atr, void *data)
> >>>>>>> +{
> >>>>>>> + atr->priv = data;
> >>>>>>> +}
> >>>>>>> +EXPORT_SYMBOL_NS_GPL(i2c_atr_set_driver_data, I2C_ATR);
> >>>>>>> +
> >>>>>>> +void *i2c_atr_get_driver_data(struct i2c_atr *atr)
> >>>>>>> +{
> >>>>>>> + return atr->priv;
> >>>>>>> +}
> >>>>>>> +EXPORT_SYMBOL_NS_GPL(i2c_atr_get_driver_data, I2C_ATR);
> >>>>>>
> >>>>>> Just to be sure: Is it really _driver_ data and not _device instance_ data?
> >>>>>
> >>>>> It is device instance data indeed. I don't remember why this got
> >>>>> changed, but in v3 it was i2c_atr_set_clientdata().
> >>>>
> >>>> It's me who was and is against calling it clientdata due to possible
> >>>> confusion with i2c_set/get_clientdata() that is about *driver data*.
> >>>> I missed that time the fact that this is about device instance data.
> >>>> I dunno which name would be better in this case, i2c_atr_set/get_client_priv() ?
> >>>
> >>> Not sure I'm following you here. The i2c_atr_set_clientdata() name was
> >>> given for similarity with i2c_set_clientdata(). The latter wraps
> >>> dev_set_drvdata(), which sets `struct device`->driver_data. There is
> >>> one driver_data per each `struct device` instance, not per each driver.
> >>> The same goes for i2c_atr_set_driver_data(): there is one priv pointer
> >>> per each `struct i2c_atr` instance.
> >>
> >> I'm a bit confused. What is "driver data" and what is "device instance
> >> data"?
> >>
> >> This deals with the driver's private data, where the "driver" is the
> >> owner/creator of the i2c-atr. The i2c-atr itself doesn't have a device
> >> (it's kind of part of the owner's device), and there's no driver in
> >> i2c-atr.c
> >>
> >> I don't like "client" here, as it reminds me of i2c_client (especially
> >> as we're in i2c context).
> >>
> >> What about i2c_atr_set_user_data()? Or "owner_data"?
> >
> > Ah, only now I got the point Andy made initially about "client" not
> > being an appropriate word.
> >
> > In i2c we have:
> >
> > i2c_set_clientdata(struct i2c_client *client, void *data)
> > ^^^^^^~~~~ ^^^^^^ ~~~~
> >
> > so "client" clearly makes sense there, now here.
>
> Isn't that also used by the i2c_client? A driver which handles an i2c
> device is the "i2c client", in a sense?
>
> > The same logic applied here would lead to:
> >
> > i2c_atr_set_atrdata(struct i2c_atr *atr, void *data)
> > ^^^~~~~ ^^^ ~~~~
> >
> > which makes sense but it is a ugly IMO.
>
> Here, I think, there's a bit of a difference to the i2c_client case, as
> we have a separate component for the i2c-atr. Although I guess one can
> argue that the top level driver is the ATR driver, as it handles the HW,
> and i2c-atr.c is just a set of helpers, so... I don't know =).
>
> > So I think i2c_atr_get_driver_data() in this v7 makes sense, it's to
> > set the data that the ATR driver instance needs.
> >
> > This is coherent with logic in spi/spi.h:
> >
> > spi_set_drvdata(struct spi_device *spi, void *data)
> >
> > except for the abbreviation ("_drvdata" vs "_driver_data").
> >
> > Andy, Tomi, would i2c_atr_set_drvdata() be OK for you, just like SPI
> > does?
>
> Well, I'm good with the current i2c_atr_set_driver_data(). If all agrees
> that it's "driver data", I'd rather keep it like that. I find this
> "drvdata" style very odd. Why no underscore between drv and data? Why
> abbreviate drv, it doesn't really help anything here?
Agreed, I'm OK with either form of "driver data".
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2023-01-19 13:02 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 12:40 [PATCH v7 0/7] i2c-atr and FPDLink Tomi Valkeinen
2023-01-18 12:40 ` [PATCH v7 1/7] i2c: add I2C Address Translator (ATR) support Tomi Valkeinen
2023-01-18 14:23 ` Andy Shevchenko
2023-01-18 17:17 ` Luca Ceresoli
2023-01-18 17:39 ` Andy Shevchenko
2023-01-19 8:21 ` Luca Ceresoli
2023-01-19 10:09 ` Tomi Valkeinen
2023-01-19 11:35 ` Luca Ceresoli
2023-01-19 12:22 ` Tomi Valkeinen
2023-01-19 13:00 ` Luca Ceresoli [this message]
2023-01-20 9:55 ` Laurent Pinchart
2023-01-20 13:58 ` Luca Ceresoli
2023-01-19 12:39 ` Tomi Valkeinen
2023-01-19 13:08 ` Luca Ceresoli
2023-01-19 10:01 ` Tomi Valkeinen
2023-01-20 15:58 ` Andy Shevchenko
2023-01-20 16:00 ` Tomi Valkeinen
2023-01-18 12:40 ` [PATCH v7 2/7] dt-bindings: media: add TI DS90UB913 FPD-Link III Serializer Tomi Valkeinen
2023-01-18 12:40 ` [PATCH v7 3/7] dt-bindings: media: add TI DS90UB953 " Tomi Valkeinen
2023-01-18 12:40 ` [PATCH v7 4/7] dt-bindings: media: add TI DS90UB960 FPD-Link III Deserializer Tomi Valkeinen
2023-01-19 23:24 ` Laurent Pinchart
2023-01-18 12:40 ` [PATCH v7 5/7] media: i2c: add DS90UB960 driver Tomi Valkeinen
2023-01-18 15:48 ` Andy Shevchenko
2023-01-19 16:27 ` Tomi Valkeinen
2023-01-19 23:19 ` Laurent Pinchart
2023-01-20 16:47 ` Andy Shevchenko
2023-01-25 11:15 ` Tomi Valkeinen
2023-01-25 12:10 ` Andy Shevchenko
2023-01-25 13:33 ` Tomi Valkeinen
2023-01-25 14:49 ` Andy Shevchenko
2023-01-25 15:14 ` Tomi Valkeinen
2023-01-25 15:27 ` Andy Shevchenko
2023-01-26 8:41 ` Tomi Valkeinen
2023-01-26 10:21 ` Andy Shevchenko
2023-01-26 10:51 ` Laurent Pinchart
2023-01-27 8:24 ` Tomi Valkeinen
2023-01-27 9:15 ` Andy Shevchenko
2023-02-08 15:10 ` Tomi Valkeinen
2023-02-09 10:54 ` Laurent Pinchart
2023-01-18 12:40 ` [PATCH v7 6/7] media: i2c: add DS90UB913 driver Tomi Valkeinen
2023-01-20 0:03 ` Laurent Pinchart
2023-01-20 7:04 ` Tomi Valkeinen
2023-01-20 9:06 ` Laurent Pinchart
2023-01-18 12:40 ` [PATCH v7 7/7] media: i2c: add DS90UB953 driver Tomi Valkeinen
2023-01-20 0:34 ` Laurent Pinchart
2023-01-20 8:13 ` Tomi Valkeinen
2023-01-20 9:23 ` Laurent Pinchart
2023-01-18 16:01 ` [PATCH v7 0/7] i2c-atr and FPDLink Andy Shevchenko
2023-01-18 17:28 ` Tomi Valkeinen
2023-01-18 17:43 ` Andy Shevchenko
2023-01-19 8:43 ` Luca Ceresoli
2023-01-19 12:40 ` Tomi Valkeinen
2023-01-19 13:19 ` Luca Ceresoli
2023-01-20 16:00 ` Andy Shevchenko
2023-01-20 16:17 ` Luca Ceresoli
2023-01-20 16:20 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230119140056.686c0dea@booty \
--to=luca.ceresoli@bootlin.com \
--cc=Matti.Vaittinen@fi.rohmeurope.com \
--cc=andriy.shevchenko@intel.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=khalasa@piap.pl \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=m.tretter@pengutronix.de \
--cc=marex@denx.de \
--cc=mchehab@kernel.org \
--cc=mpagano@gentoo.org \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shawnx.tu@intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).