[PATCH 00/11] ARM: dts: exynos: DT schema fixes

[PATCH 00/11] ARM: dts: exynos: DT schema fixes

[Krzysztof Kozlowski]

Hi,

With this set of fixes (and few other earlier), all Exynos ARMv7 boards
successfully pass DT Schema checks! All! Hurray!

Please kindly test if I did not break any boards...

Best regards,
Krzysztof

Krzysztof Kozlowski (11):
  ARM: dts: exynos: correct wr-active property in Exynos3250 Rinato
  ARM: dts: exynos: drop unsupported desc-num in Exynos3250
  ARM: dts: exynos: correct cd-gpios property in Exynos4412 Itop Elite
  ARM: dts: exynos: align pin node names in Exynos4412
  ARM: dts: exynos: add ports in HDMI bridge in Exynos4412 Midas
  ARM: dts: exynos: add panel supply in Tiny4412
  ARM: dts: exynos: add backlight supply in P4 Note
  ARM: dts: exynos: align HSOTG/USB node names
  ARM: dts: exynos: correct SATA clocks in Exynos5250
  ARM: dts: exynos: correct HS200 property in Exynos5260
  ARM: dts: exynos: correct HSI2C properties in Exynos5410 Odroid XU

 arch/arm/boot/dts/exynos3250-monk.dts       |  1 -
 arch/arm/boot/dts/exynos3250-rinato.dts     |  3 +--
 arch/arm/boot/dts/exynos3250.dtsi           |  2 +-
 arch/arm/boot/dts/exynos4.dtsi              |  2 +-
 arch/arm/boot/dts/exynos4412-itop-elite.dts |  2 +-
 arch/arm/boot/dts/exynos4412-midas.dtsi     | 13 ++++++++++---
 arch/arm/boot/dts/exynos4412-p4note.dtsi    |  1 +
 arch/arm/boot/dts/exynos4412-pinctrl.dtsi   |  2 +-
 arch/arm/boot/dts/exynos4412-tiny4412.dts   |  8 ++++++++
 arch/arm/boot/dts/exynos5250.dtsi           |  2 +-
 arch/arm/boot/dts/exynos5260-xyref5260.dts  |  2 +-
 arch/arm/boot/dts/exynos5410-odroidxu.dts   |  3 +--
 12 files changed, 27 insertions(+), 14 deletions(-)

-- 
2.34.1

[PATCH 01/11] ARM: dts: exynos: correct wr-active property in Exynos3250 Rinato

[Krzysztof Kozlowski]

The property is wr-active:

  exynos3250-rinato.dtb: fimd@11c00000: i80-if-timings: 'wr-act' does not match any of the regexes: 'pinctrl-[0-9]+'

Fixes: b59b3afb94d4 ("ARM: dts: add fimd device support for exynos3250-rinato")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/exynos3250-rinato.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
index 6d2c7bb19184..2eb682009815 100644
--- a/arch/arm/boot/dts/exynos3250-rinato.dts
+++ b/arch/arm/boot/dts/exynos3250-rinato.dts
@@ -250,7 +250,7 @@ &fimd {
 	i80-if-timings {
 		cs-setup = <0>;
 		wr-setup = <0>;
-		wr-act = <1>;
+		wr-active = <1>;
 		wr-hold = <0>;
 	};
 };
-- 
2.34.1

[PATCH 02/11] ARM: dts: exynos: drop unsupported desc-num in Exynos3250

[Krzysztof Kozlowski]

There is no desc-num property for MMC nodes:

  exynos3250-monk.dtb: mmc@12510000: Unevaluated properties are not allowed ('desc-num' was unexpected)

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/exynos3250-monk.dts   | 1 -
 arch/arm/boot/dts/exynos3250-rinato.dts | 1 -
 2 files changed, 2 deletions(-)

diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts
index 02a9dc479d34..c8eacf1b5d0b 100644
--- a/arch/arm/boot/dts/exynos3250-monk.dts
+++ b/arch/arm/boot/dts/exynos3250-monk.dts
@@ -438,7 +438,6 @@ &mshc_0 {
 	broken-cd;
 	non-removable;
 	cap-mmc-highspeed;
-	desc-num = <4>;
 	mmc-hs200-1_8v;
 	card-detect-delay = <200>;
 	vmmc-supply = <&vemmc_reg>;
diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
index 2eb682009815..812816af8476 100644
--- a/arch/arm/boot/dts/exynos3250-rinato.dts
+++ b/arch/arm/boot/dts/exynos3250-rinato.dts
@@ -619,7 +619,6 @@ &mshc_0 {
 	broken-cd;
 	non-removable;
 	cap-mmc-highspeed;
-	desc-num = <4>;
 	mmc-hs200-1_8v;
 	card-detect-delay = <200>;
 	vmmc-supply = <&ldo12_reg>;
-- 
2.34.1

[PATCH 03/11] ARM: dts: exynos: correct cd-gpios property in Exynos4412 Itop Elite

[Krzysztof Kozlowski]

The property is cd-gpios:

  exynos4412-itop-elite.dtb: mmc@12530000: Unevaluated properties are not allowed ('cd-gpio' was unexpected)

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/exynos4412-itop-elite.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts
index 202ab0fee3b7..b596e997e451 100644
--- a/arch/arm/boot/dts/exynos4412-itop-elite.dts
+++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
@@ -214,7 +214,7 @@ &sdhci_2 {
 	bus-width = <4>;
 	pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus4>;
 	pinctrl-names = "default";
-	cd-gpio = <&gpx0 7 GPIO_ACTIVE_LOW>;
+	cd-gpios = <&gpx0 7 GPIO_ACTIVE_LOW>;
 	cap-sd-highspeed;
 	vmmc-supply = <&ldo23_reg>;
 	vqmmc-supply = <&ldo17_reg>;
-- 
2.34.1

[PATCH 04/11] ARM: dts: exynos: align pin node names in Exynos4412

[Krzysztof Kozlowski]

The DT schema expect pin configuration nodes to have pin prefix or
suffix:

  exynos4412-trats2.dtb: pinctrl@3860000: sleep-state: 'gpz-0', 'gpz-1', 'gpz-2', 'gpz-3', 'gpz-4', 'gpz-5', 'gpz-6'
    do not match any of the regexes: '^(pin-[a-z0-9-]+|[a-z0-9-]+-pin)$', 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/exynos4412-pinctrl.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos4412-pinctrl.dtsi b/arch/arm/boot/dts/exynos4412-pinctrl.dtsi
index 58847d4fa846..8ab31c3daa48 100644
--- a/arch/arm/boot/dts/exynos4412-pinctrl.dtsi
+++ b/arch/arm/boot/dts/exynos4412-pinctrl.dtsi
@@ -12,7 +12,7 @@
 #include "exynos-pinctrl.h"
 
 #define PIN_SLP(_pin, _mode, _pull)					\
-	_pin {								\
+	pin- ## _pin {							\
 		samsung,pins = #_pin;					\
 		samsung,pin-con-pdn = <EXYNOS_PIN_PDN_ ##_mode>;	\
 		samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_ ##_pull>;	\
-- 
2.34.1

[RFT 05/11] ARM: dts: exynos: add ports in HDMI bridge in Exynos4412 Midas

[Krzysztof Kozlowski]

The SII9234 HDMI bridge expects ports property:

  exynos4412-i9305.dtb: hdmi-bridge@39: 'ports' is a required property
  exynos4412-i9305.dtb: hdmi-bridge@39: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/exynos4412-midas.dtsi | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi b/arch/arm/boot/dts/exynos4412-midas.dtsi
index 8e1c19a8ad06..a626d33d1330 100644
--- a/arch/arm/boot/dts/exynos4412-midas.dtsi
+++ b/arch/arm/boot/dts/exynos4412-midas.dtsi
@@ -273,9 +273,16 @@ sii9234: hdmi-bridge@39 {
 			interrupts = <5 IRQ_TYPE_LEVEL_HIGH>;
 			reg = <0x39>;
 
-			port {
-				mhl_to_hdmi: endpoint {
-					remote-endpoint = <&hdmi_to_mhl>;
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@0 {
+					reg = <0>;
+
+					mhl_to_hdmi: endpoint {
+						remote-endpoint = <&hdmi_to_mhl>;
+					};
 				};
 			};
 		};
-- 
2.34.1

[PATCH 06/11] ARM: dts: exynos: add panel supply in Tiny4412

[Krzysztof Kozlowski]

The simple panel should have a supply.  Provide a stub, as the board DTS
does not have a PMIC node, to silence warning:

  exynos4412-tiny4412.dtb: panel: 'power-supply' is a required property

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/exynos4412-tiny4412.dts | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4412-tiny4412.dts b/arch/arm/boot/dts/exynos4412-tiny4412.dts
index 04388c575efe..e0b6162d2e2a 100644
--- a/arch/arm/boot/dts/exynos4412-tiny4412.dts
+++ b/arch/arm/boot/dts/exynos4412-tiny4412.dts
@@ -79,6 +79,7 @@ pmic_ap_clk: pmic-ap-clk {
 
 	panel {
 		compatible = "innolux,at070tn92";
+		power-supply = <&vddq_lcd>;
 
 		port {
 			panel_input: endpoint {
@@ -86,6 +87,13 @@ panel_input: endpoint {
 			};
 		};
 	};
+
+	vddq_lcd: regulator-vddq-lcd {
+		compatible = "regulator-fixed";
+		regulator-name = "vddq-lcd";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+	};
 };
 
 &cpu_thermal {
-- 
2.34.1

[PATCH 07/11] ARM: dts: exynos: add backlight supply in P4 Note

[Krzysztof Kozlowski]

The LCD backlight  should have a supply.  Use same regulator as LCD, to
silence warning:

  exynos4412-p4note-n8010.dtb: backlight: 'power-supply' is a required property

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/exynos4412-p4note.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/exynos4412-p4note.dtsi b/arch/arm/boot/dts/exynos4412-p4note.dtsi
index e41cf3ed362d..201c38edd48f 100644
--- a/arch/arm/boot/dts/exynos4412-p4note.dtsi
+++ b/arch/arm/boot/dts/exynos4412-p4note.dtsi
@@ -245,6 +245,7 @@ backlight: backlight {
 		pinctrl-0 = <&led_bl_reset>;
 		pinctrl-names = "default";
 		enable-gpios = <&gpm0 1 GPIO_ACTIVE_HIGH>;
+		power-supply = <&panel_vdd>;
 		pwms = <&pwm 1 78770 0>;
 		brightness-levels = <0 48 128 255>;
 		num-interpolated-steps = <8>;
-- 
2.34.1

[PATCH 08/11] ARM: dts: exynos: align HSOTG/USB node names

[Krzysztof Kozlowski]

The DT schema expect HSOTG node names to be named "usb":

  exynos4210-smdkv310.dtb: hsotg@12480000: $nodename:0: 'hsotg@12480000' does not match '^usb(@.*)?'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/exynos3250.dtsi | 2 +-
 arch/arm/boot/dts/exynos4.dtsi    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
index 9b25449d5311..36b47c2c1663 100644
--- a/arch/arm/boot/dts/exynos3250.dtsi
+++ b/arch/arm/boot/dts/exynos3250.dtsi
@@ -365,7 +365,7 @@ sysmmu_fimd0: sysmmu@11e20000 {
 			#iommu-cells = <0>;
 		};
 
-		hsotg: hsotg@12480000 {
+		hsotg: usb@12480000 {
 			compatible = "samsung,s3c6400-hsotg";
 			reg = <0x12480000 0x20000>;
 			interrupts = <GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>;
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index 5c4ecda27a47..55afe9972460 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -362,7 +362,7 @@ exynos_usbphy: exynos-usbphy@125b0000 {
 			status = "disabled";
 		};
 
-		hsotg: hsotg@12480000 {
+		hsotg: usb@12480000 {
 			compatible = "samsung,s3c6400-hsotg";
 			reg = <0x12480000 0x20000>;
 			interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
-- 
2.34.1

[PATCH 09/11] ARM: dts: exynos: correct SATA clocks in Exynos5250

[Krzysztof Kozlowski]

The DT schema expects clock name matching certain patterns:

  exynos5250-smdk5250.dtb: sata@122f0000: clock-names:1: 'oneOf' conditional failed, one must be fixed:
    'sclk_sata' is not one of ['pclk', 'aclk', 'hclk', 'sata']
    'pmalive' was expected
    'rxoob' was expected
    'ref' was expected

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/exynos5250.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index f82f82fc803f..9225f3552837 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -390,7 +390,7 @@ sata: sata@122f0000 {
 			reg = <0x122F0000 0x1ff>;
 			interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&clock CLK_SATA>, <&clock CLK_SCLK_SATA>;
-			clock-names = "sata", "sclk_sata";
+			clock-names = "sata", "pclk";
 			phys = <&sata_phy>;
 			phy-names = "sata-phy";
 			ports-implemented = <0x1>;
-- 
2.34.1

[PATCH 10/11] ARM: dts: exynos: correct HS200 property in Exynos5260

[Krzysztof Kozlowski]

There is no supports-hs200-mode property for MMC nodes, so assume
intention was mmc-hs200-1_8v:

  exynos5260-xyref5260.dtb: mmc@12140000: Unevaluated properties are not allowed ('supports-hs200-mode' was unexpected)

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/exynos5260-xyref5260.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos5260-xyref5260.dts b/arch/arm/boot/dts/exynos5260-xyref5260.dts
index 3c3b751d4360..387b8494f18f 100644
--- a/arch/arm/boot/dts/exynos5260-xyref5260.dts
+++ b/arch/arm/boot/dts/exynos5260-xyref5260.dts
@@ -87,7 +87,7 @@ &mmc_0 {
 	status = "okay";
 	broken-cd;
 	cap-mmc-highspeed;
-	supports-hs200-mode; /* 200 MHz */
+	mmc-hs200-1_8v;
 	card-detect-delay = <200>;
 	samsung,dw-mshc-ciu-div = <3>;
 	samsung,dw-mshc-sdr-timing = <0 4>;
-- 
2.34.1

[PATCH 11/11] ARM: dts: exynos: correct HSI2C properties in Exynos5410 Odroid XU

[Krzysztof Kozlowski]

The HSI2C controller uses clock-frequency and does not have
i2c-sda-delay.  The properties were copy-pasted from the slower
S3C-family I2C controller:

  exynos5410-odroidxu.dtb: i2c@12ca0000: Unevaluated properties are not allowed ('samsung,i2c-max-bus-freq', 'samsung,i2c-sda-delay' were unexpected)

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/exynos5410-odroidxu.dts | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts
index d1cbc6b8a570..232561620da2 100644
--- a/arch/arm/boot/dts/exynos5410-odroidxu.dts
+++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
@@ -164,8 +164,7 @@ map2 {
 };
 
 &hsi2c_4 {
-	samsung,i2c-sda-delay = <100>;
-	samsung,i2c-max-bus-freq = <400000>;
+	clock-frequency = <400000>;
 	status = "okay";
 
 	usb3503: usb-hub@8 {
-- 
2.34.1

Re: [PATCH 00/11] ARM: dts: exynos: DT schema fixes

[Krzysztof Kozlowski]

On Fri, 20 Jan 2023 16:53:53 +0100, Krzysztof Kozlowski wrote:
> With this set of fixes (and few other earlier), all Exynos ARMv7 boards
> successfully pass DT Schema checks! All! Hurray!
> 
> Please kindly test if I did not break any boards...
> 
> Best regards,
> Krzysztof
> 
> [...]

Applied, thanks!

[01/11] ARM: dts: exynos: correct wr-active property in Exynos3250 Rinato
        https://git.kernel.org/krzk/linux/c/d15d2a617499882971ddb773a583015bf36fa492
[02/11] ARM: dts: exynos: drop unsupported desc-num in Exynos3250
        https://git.kernel.org/krzk/linux/c/49434cd203ed3af220145f2e5e5791339dac347a
[03/11] ARM: dts: exynos: correct cd-gpios property in Exynos4412 Itop Elite
        https://git.kernel.org/krzk/linux/c/78b93ffef4ad1800f884e4892c1bd79ca5512cba
[04/11] ARM: dts: exynos: align pin node names in Exynos4412
        https://git.kernel.org/krzk/linux/c/f370a3d0fd16cd260248c387cc085dcb8a6d32b2
[05/11] ARM: dts: exynos: add ports in HDMI bridge in Exynos4412 Midas
        https://git.kernel.org/krzk/linux/c/74ac07e485bb01e232c7f3d67632ffc9b64604aa
[06/11] ARM: dts: exynos: add panel supply in Tiny4412
        https://git.kernel.org/krzk/linux/c/c2387ee9a318dfb7cb5a7a210e2825c62d4932cc
[07/11] ARM: dts: exynos: add backlight supply in P4 Note
        https://git.kernel.org/krzk/linux/c/f845ae570231bcaa677df65af620896fdf3c5705
[08/11] ARM: dts: exynos: align HSOTG/USB node names
        https://git.kernel.org/krzk/linux/c/eeb0fd23bc0fc823032dd2a2df22651ce8369aed
[09/11] ARM: dts: exynos: correct SATA clocks in Exynos5250
        https://git.kernel.org/krzk/linux/c/712c852a7b0dc0ac66fa6b89997f4f952483a5e4
[10/11] ARM: dts: exynos: correct HS200 property in Exynos5260
        https://git.kernel.org/krzk/linux/c/865b7ea364f892a3de7838eec04628efb945939e
[11/11] ARM: dts: exynos: correct HSI2C properties in Exynos5410 Odroid XU
        https://git.kernel.org/krzk/linux/c/5dd60c69047ee3fd92a9f64b28377f4819536d2f

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Re: [RFT 05/11] ARM: dts: exynos: add ports in HDMI bridge in Exynos4412 Midas

[Henrik Grimler]

Hi,

I see you have already merged this, but FWIW HDMI works as well as
before on exynos4412-i9300, so:

Tested-by: Henrik Grimler <henrik@grimler.se>

Longer explanation: HDMI output only works on i9300 if MHL cable is
attached before device boots, so probably bootloader sets up some
settings that the sii9234 driver does not handle (correctly) if cable
is hot plugged.

Best regards,
Henrik Grimler

On Fri, Jan 20, 2023 at 04:53:58PM +0100, Krzysztof Kozlowski wrote:
> The SII9234 HDMI bridge expects ports property:
> 
>   exynos4412-i9305.dtb: hdmi-bridge@39: 'ports' is a required property
>   exynos4412-i9305.dtb: hdmi-bridge@39: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  arch/arm/boot/dts/exynos4412-midas.dtsi | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi b/arch/arm/boot/dts/exynos4412-midas.dtsi
> index 8e1c19a8ad06..a626d33d1330 100644
> --- a/arch/arm/boot/dts/exynos4412-midas.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-midas.dtsi
> @@ -273,9 +273,16 @@ sii9234: hdmi-bridge@39 {
>  			interrupts = <5 IRQ_TYPE_LEVEL_HIGH>;
>  			reg = <0x39>;
>  
> -			port {
> -				mhl_to_hdmi: endpoint {
> -					remote-endpoint = <&hdmi_to_mhl>;
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
> +					reg = <0>;
> +
> +					mhl_to_hdmi: endpoint {
> +						remote-endpoint = <&hdmi_to_mhl>;
> +					};
>  				};
>  			};
>  		};
> -- 
> 2.34.1
> 

Re: [RFT 05/11] ARM: dts: exynos: add ports in HDMI bridge in Exynos4412 Midas

[Krzysztof Kozlowski]

On 23/01/2023 16:34, Henrik Grimler wrote:
> Hi,
> 
> I see you have already merged this, but FWIW HDMI works as well as
> before on exynos4412-i9300, so:
> 
> Tested-by: Henrik Grimler <henrik@grimler.se>

Great, thanks! I'll add your tag.

> 
> Longer explanation: HDMI output only works on i9300 if MHL cable is
> attached before device boots, so probably bootloader sets up some
> settings that the sii9234 driver does not handle (correctly) if cable
> is hot plugged.

Best regards,
Krzysztof

RE: [PATCH 01/11] ARM: dts: exynos: correct wr-active property in Exynos3250 Rinato

[Alim Akhtar]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Friday, January 20, 2023 9:24 PM
> To: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
> <alim.akhtar@samsung.com>; Inki Dae <inki.dae@samsung.com>; Kyungmin
> Park <kyungmin.park@samsung.com>; Kukjin Kim <kgene@kernel.org>;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: replicant@osuosl.org; phone-devel@vger.kernel.org;
> ~postmarketos/upstreaming@lists.sr.ht; Martin Jücker
> <martin.juecker@gmail.com>; Henrik Grimler <henrik@grimler.se>;
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Subject: [PATCH 01/11] ARM: dts: exynos: correct wr-active property in
> Exynos3250 Rinato
> 
> The property is wr-active:
> 
>   exynos3250-rinato.dtb: fimd@11c00000: i80-if-timings: 'wr-act' does not
> match any of the regexes: 'pinctrl-[0-9]+'
> 
> Fixes: b59b3afb94d4 ("ARM: dts: add fimd device support for exynos3250-
> rinato")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

>  arch/arm/boot/dts/exynos3250-rinato.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts
> b/arch/arm/boot/dts/exynos3250-rinato.dts
> index 6d2c7bb19184..2eb682009815 100644
> --- a/arch/arm/boot/dts/exynos3250-rinato.dts
> +++ b/arch/arm/boot/dts/exynos3250-rinato.dts
> @@ -250,7 +250,7 @@ &fimd {
>  	i80-if-timings {
>  		cs-setup = <0>;
>  		wr-setup = <0>;
> -		wr-act = <1>;
> +		wr-active = <1>;
>  		wr-hold = <0>;
>  	};
>  };
> --
> 2.34.1

RE: [PATCH 02/11] ARM: dts: exynos: drop unsupported desc-num in Exynos3250

[Alim Akhtar]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Friday, January 20, 2023 9:24 PM
> To: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
> <alim.akhtar@samsung.com>; Inki Dae <inki.dae@samsung.com>; Kyungmin
> Park <kyungmin.park@samsung.com>; Kukjin Kim <kgene@kernel.org>;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: replicant@osuosl.org; phone-devel@vger.kernel.org;
> ~postmarketos/upstreaming@lists.sr.ht; Martin Jücker
> <martin.juecker@gmail.com>; Henrik Grimler <henrik@grimler.se>;
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Subject: [PATCH 02/11] ARM: dts: exynos: drop unsupported desc-num in
> Exynos3250
> 
> There is no desc-num property for MMC nodes:
> 
>   exynos3250-monk.dtb: mmc@12510000: Unevaluated properties are not
> allowed ('desc-num' was unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

>  arch/arm/boot/dts/exynos3250-monk.dts   | 1 -
>  arch/arm/boot/dts/exynos3250-rinato.dts | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos3250-monk.dts
> b/arch/arm/boot/dts/exynos3250-monk.dts
> index 02a9dc479d34..c8eacf1b5d0b 100644
> --- a/arch/arm/boot/dts/exynos3250-monk.dts
> +++ b/arch/arm/boot/dts/exynos3250-monk.dts
> @@ -438,7 +438,6 @@ &mshc_0 {
>  	broken-cd;
>  	non-removable;
>  	cap-mmc-highspeed;
> -	desc-num = <4>;
>  	mmc-hs200-1_8v;
>  	card-detect-delay = <200>;
>  	vmmc-supply = <&vemmc_reg>;
> diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts
> b/arch/arm/boot/dts/exynos3250-rinato.dts
> index 2eb682009815..812816af8476 100644
> --- a/arch/arm/boot/dts/exynos3250-rinato.dts
> +++ b/arch/arm/boot/dts/exynos3250-rinato.dts
> @@ -619,7 +619,6 @@ &mshc_0 {
>  	broken-cd;
>  	non-removable;
>  	cap-mmc-highspeed;
> -	desc-num = <4>;
>  	mmc-hs200-1_8v;
>  	card-detect-delay = <200>;
>  	vmmc-supply = <&ldo12_reg>;
> --
> 2.34.1

RE: [PATCH 03/11] ARM: dts: exynos: correct cd-gpios property in Exynos4412 Itop Elite

[Alim Akhtar]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Friday, January 20, 2023 9:24 PM
> To: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
> <alim.akhtar@samsung.com>; Inki Dae <inki.dae@samsung.com>; Kyungmin
> Park <kyungmin.park@samsung.com>; Kukjin Kim <kgene@kernel.org>;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: replicant@osuosl.org; phone-devel@vger.kernel.org;
> ~postmarketos/upstreaming@lists.sr.ht; Martin Jücker
> <martin.juecker@gmail.com>; Henrik Grimler <henrik@grimler.se>;
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Subject: [PATCH 03/11] ARM: dts: exynos: correct cd-gpios property in
> Exynos4412 Itop Elite
> 
> The property is cd-gpios:
> 
>   exynos4412-itop-elite.dtb: mmc@12530000: Unevaluated properties are not
> allowed ('cd-gpio' was unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

>  arch/arm/boot/dts/exynos4412-itop-elite.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts
> b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> index 202ab0fee3b7..b596e997e451 100644
> --- a/arch/arm/boot/dts/exynos4412-itop-elite.dts
> +++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> @@ -214,7 +214,7 @@ &sdhci_2 {
>  	bus-width = <4>;
>  	pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus4>;
>  	pinctrl-names = "default";
> -	cd-gpio = <&gpx0 7 GPIO_ACTIVE_LOW>;
> +	cd-gpios = <&gpx0 7 GPIO_ACTIVE_LOW>;
>  	cap-sd-highspeed;
>  	vmmc-supply = <&ldo23_reg>;
>  	vqmmc-supply = <&ldo17_reg>;
> --
> 2.34.1

RE: [PATCH 04/11] ARM: dts: exynos: align pin node names in Exynos4412

[Alim Akhtar]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Friday, January 20, 2023 9:24 PM
> To: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
> <alim.akhtar@samsung.com>; Inki Dae <inki.dae@samsung.com>; Kyungmin
> Park <kyungmin.park@samsung.com>; Kukjin Kim <kgene@kernel.org>;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: replicant@osuosl.org; phone-devel@vger.kernel.org;
> ~postmarketos/upstreaming@lists.sr.ht; Martin Jücker
> <martin.juecker@gmail.com>; Henrik Grimler <henrik@grimler.se>;
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Subject: [PATCH 04/11] ARM: dts: exynos: align pin node names in
> Exynos4412
> 
> The DT schema expect pin configuration nodes to have pin prefix or
> suffix:
> 
>   exynos4412-trats2.dtb: pinctrl@3860000: sleep-state: 'gpz-0', 'gpz-1', 'gpz-2',
> 'gpz-3', 'gpz-4', 'gpz-5', 'gpz-6'
>     do not match any of the regexes: '^(pin-[a-z0-9-]+|[a-z0-9-]+-pin)$',
> 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

>  arch/arm/boot/dts/exynos4412-pinctrl.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-pinctrl.dtsi
> b/arch/arm/boot/dts/exynos4412-pinctrl.dtsi
> index 58847d4fa846..8ab31c3daa48 100644
> --- a/arch/arm/boot/dts/exynos4412-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-pinctrl.dtsi
> @@ -12,7 +12,7 @@
>  #include "exynos-pinctrl.h"
> 
>  #define PIN_SLP(_pin, _mode, _pull)					\
> -	_pin {								\
> +	pin- ## _pin {							\
>  		samsung,pins = #_pin;					\
>  		samsung,pin-con-pdn = <EXYNOS_PIN_PDN_ ##_mode>;
> 	\
>  		samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_ ##_pull>;
> 	\
> --
> 2.34.1

RE: [PATCH 08/11] ARM: dts: exynos: align HSOTG/USB node names

[Alim Akhtar]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Friday, January 20, 2023 9:24 PM
> To: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
> <alim.akhtar@samsung.com>; Inki Dae <inki.dae@samsung.com>; Kyungmin
> Park <kyungmin.park@samsung.com>; Kukjin Kim <kgene@kernel.org>;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: replicant@osuosl.org; phone-devel@vger.kernel.org;
> ~postmarketos/upstreaming@lists.sr.ht; Martin Jücker
> <martin.juecker@gmail.com>; Henrik Grimler <henrik@grimler.se>;
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Subject: [PATCH 08/11] ARM: dts: exynos: align HSOTG/USB node names
> 
> The DT schema expect HSOTG node names to be named "usb":
> 
>   exynos4210-smdkv310.dtb: hsotg@12480000: $nodename:0:
> 'hsotg@12480000' does not match '^usb(@.*)?'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

>  arch/arm/boot/dts/exynos3250.dtsi | 2 +-
>  arch/arm/boot/dts/exynos4.dtsi    | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos3250.dtsi
> b/arch/arm/boot/dts/exynos3250.dtsi
> index 9b25449d5311..36b47c2c1663 100644
> --- a/arch/arm/boot/dts/exynos3250.dtsi
> +++ b/arch/arm/boot/dts/exynos3250.dtsi
> @@ -365,7 +365,7 @@ sysmmu_fimd0: sysmmu@11e20000 {
>  			#iommu-cells = <0>;
>  		};
> 
> -		hsotg: hsotg@12480000 {
> +		hsotg: usb@12480000 {
>  			compatible = "samsung,s3c6400-hsotg";
>  			reg = <0x12480000 0x20000>;
>  			interrupts = <GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>;
> diff --git a/arch/arm/boot/dts/exynos4.dtsi
> b/arch/arm/boot/dts/exynos4.dtsi index 5c4ecda27a47..55afe9972460
> 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -362,7 +362,7 @@ exynos_usbphy: exynos-usbphy@125b0000 {
>  			status = "disabled";
>  		};
> 
> -		hsotg: hsotg@12480000 {
> +		hsotg: usb@12480000 {
>  			compatible = "samsung,s3c6400-hsotg";
>  			reg = <0x12480000 0x20000>;
>  			interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
> --
> 2.34.1

RE: [PATCH 09/11] ARM: dts: exynos: correct SATA clocks in Exynos5250

[Alim Akhtar]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Friday, January 20, 2023 9:24 PM
> To: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
> <alim.akhtar@samsung.com>; Inki Dae <inki.dae@samsung.com>; Kyungmin
> Park <kyungmin.park@samsung.com>; Kukjin Kim <kgene@kernel.org>;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: replicant@osuosl.org; phone-devel@vger.kernel.org;
> ~postmarketos/upstreaming@lists.sr.ht; Martin Jücker
> <martin.juecker@gmail.com>; Henrik Grimler <henrik@grimler.se>;
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Subject: [PATCH 09/11] ARM: dts: exynos: correct SATA clocks in Exynos5250
> 
> The DT schema expects clock name matching certain patterns:
> 
>   exynos5250-smdk5250.dtb: sata@122f0000: clock-names:1: 'oneOf'
> conditional failed, one must be fixed:
>     'sclk_sata' is not one of ['pclk', 'aclk', 'hclk', 'sata']
>     'pmalive' was expected
>     'rxoob' was expected
>     'ref' was expected
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>


>  arch/arm/boot/dts/exynos5250.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> index f82f82fc803f..9225f3552837 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -390,7 +390,7 @@ sata: sata@122f0000 {
>  			reg = <0x122F0000 0x1ff>;
>  			interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>;
>  			clocks = <&clock CLK_SATA>, <&clock
> CLK_SCLK_SATA>;
> -			clock-names = "sata", "sclk_sata";
> +			clock-names = "sata", "pclk";
>  			phys = <&sata_phy>;
>  			phy-names = "sata-phy";
>  			ports-implemented = <0x1>;
> --
> 2.34.1

RE: [PATCH 10/11] ARM: dts: exynos: correct HS200 property in Exynos5260

[Alim Akhtar]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Friday, January 20, 2023 9:24 PM
> To: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
> <alim.akhtar@samsung.com>; Inki Dae <inki.dae@samsung.com>; Kyungmin
> Park <kyungmin.park@samsung.com>; Kukjin Kim <kgene@kernel.org>;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: replicant@osuosl.org; phone-devel@vger.kernel.org;
> ~postmarketos/upstreaming@lists.sr.ht; Martin Jücker
> <martin.juecker@gmail.com>; Henrik Grimler <henrik@grimler.se>;
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Subject: [PATCH 10/11] ARM: dts: exynos: correct HS200 property in
> Exynos5260
> 
> There is no supports-hs200-mode property for MMC nodes, so assume
> intention was mmc-hs200-1_8v:
> 
>   exynos5260-xyref5260.dtb: mmc@12140000: Unevaluated properties are
> not allowed ('supports-hs200-mode' was unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

>  arch/arm/boot/dts/exynos5260-xyref5260.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5260-xyref5260.dts
> b/arch/arm/boot/dts/exynos5260-xyref5260.dts
> index 3c3b751d4360..387b8494f18f 100644
> --- a/arch/arm/boot/dts/exynos5260-xyref5260.dts
> +++ b/arch/arm/boot/dts/exynos5260-xyref5260.dts
> @@ -87,7 +87,7 @@ &mmc_0 {
>  	status = "okay";
>  	broken-cd;
>  	cap-mmc-highspeed;
> -	supports-hs200-mode; /* 200 MHz */
> +	mmc-hs200-1_8v;
>  	card-detect-delay = <200>;
>  	samsung,dw-mshc-ciu-div = <3>;
>  	samsung,dw-mshc-sdr-timing = <0 4>;
> --
> 2.34.1

RE: [PATCH 11/11] ARM: dts: exynos: correct HSI2C properties in Exynos5410 Odroid XU

[Alim Akhtar]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Friday, January 20, 2023 9:24 PM
> To: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
> <alim.akhtar@samsung.com>; Inki Dae <inki.dae@samsung.com>; Kyungmin
> Park <kyungmin.park@samsung.com>; Kukjin Kim <kgene@kernel.org>;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: replicant@osuosl.org; phone-devel@vger.kernel.org;
> ~postmarketos/upstreaming@lists.sr.ht; Martin Jücker
> <martin.juecker@gmail.com>; Henrik Grimler <henrik@grimler.se>;
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Subject: [PATCH 11/11] ARM: dts: exynos: correct HSI2C properties in
> Exynos5410 Odroid XU
> 
> The HSI2C controller uses clock-frequency and does not have i2c-sda-delay.
> The properties were copy-pasted from the slower S3C-family I2C controller:
> 
>   exynos5410-odroidxu.dtb: i2c@12ca0000: Unevaluated properties are not
> allowed ('samsung,i2c-max-bus-freq', 'samsung,i2c-sda-delay' were
> unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

>  arch/arm/boot/dts/exynos5410-odroidxu.dts | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts
> b/arch/arm/boot/dts/exynos5410-odroidxu.dts
> index d1cbc6b8a570..232561620da2 100644
> --- a/arch/arm/boot/dts/exynos5410-odroidxu.dts
> +++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
> @@ -164,8 +164,7 @@ map2 {
>  };
> 
>  &hsi2c_4 {
> -	samsung,i2c-sda-delay = <100>;
> -	samsung,i2c-max-bus-freq = <400000>;
> +	clock-frequency = <400000>;
>  	status = "okay";
> 
>  	usb3503: usb-hub@8 {
> --
> 2.34.1