* [PATCH 2/6] arm64: dts: exynos: add ADC supply on Exynos7 Espresso
2023-01-20 17:31 ` [PATCH 1/6] arm64: dts: exynos: disable non-working GPU on Exynos7 Espresso Krzysztof Kozlowski
@ 2023-01-20 17:31 ` Krzysztof Kozlowski
2023-01-28 6:53 ` Alim Akhtar
2023-01-20 17:31 ` [PATCH 3/6] arm64: dts: exynos: correct Bluetooth LED triger on E850-96 Krzysztof Kozlowski
` (5 subsequent siblings)
6 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-20 17:31 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Alim Akhtar, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Sam Protsenko, Chanho Park, Krzysztof Kozlowski
ADC requires supply and it seems LDO3 (same as on Exynos5433 TM2 boards)
fits in voltage range of 1.8 V. Use it to silence warning:
exynos7-espresso.dtb: adc@13620000: 'vdd-supply' is a required property
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
index 829657c9c7ca..abb3bd700d6f 100644
--- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
+++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
@@ -78,6 +78,7 @@ &watchdog {
};
&adc {
+ vdd-supply = <&ldo3_reg>;
status = "okay";
};
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* RE: [PATCH 2/6] arm64: dts: exynos: add ADC supply on Exynos7 Espresso
2023-01-20 17:31 ` [PATCH 2/6] arm64: dts: exynos: add ADC supply " Krzysztof Kozlowski
@ 2023-01-28 6:53 ` Alim Akhtar
0 siblings, 0 replies; 9+ messages in thread
From: Alim Akhtar @ 2023-01-28 6:53 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Rob Herring',
'Krzysztof Kozlowski',
devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: 'Sam Protsenko', 'Chanho Park'
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Friday, January 20, 2023 11:01 PM
> To: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
> <alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Sam Protsenko <semen.protsenko@linaro.org>; Chanho Park
> <chanho61.park@samsung.com>; Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org>
> Subject: [PATCH 2/6] arm64: dts: exynos: add ADC supply on Exynos7
> Espresso
>
> ADC requires supply and it seems LDO3 (same as on Exynos5433 TM2 boards)
> fits in voltage range of 1.8 V. Use it to silence warning:
>
Yes, it is LDO3 for exynos7_espresso board as well.
> exynos7-espresso.dtb: adc@13620000: 'vdd-supply' is a required property
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> index 829657c9c7ca..abb3bd700d6f 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> @@ -78,6 +78,7 @@ &watchdog {
> };
>
> &adc {
> + vdd-supply = <&ldo3_reg>;
> status = "okay";
> };
>
> --
> 2.34.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/6] arm64: dts: exynos: correct Bluetooth LED triger on E850-96
2023-01-20 17:31 ` [PATCH 1/6] arm64: dts: exynos: disable non-working GPU on Exynos7 Espresso Krzysztof Kozlowski
2023-01-20 17:31 ` [PATCH 2/6] arm64: dts: exynos: add ADC supply " Krzysztof Kozlowski
@ 2023-01-20 17:31 ` Krzysztof Kozlowski
2023-01-20 17:31 ` [PATCH 4/6] arm64: dts: exynos: add VPH_PWR regulator on TM2 Krzysztof Kozlowski
` (4 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-20 17:31 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Alim Akhtar, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Sam Protsenko, Chanho Park, Krzysztof Kozlowski
Switch source of LED activity to hci0-power from RX, to match bindings
(same effect expected):
exynos850-e850-96.dtb: leds: led-5:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
'hci0rx' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
'hci0rx' does not match '^cpu[0-9]*$'
'hci0rx' does not match '^hci[0-9]+-power$'
'hci0rx' does not match '^mmc[0-9]+$'
'hci0rx' does not match '^phy[0-9]+tx$'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Depends on:
https://lore.kernel.org/all/a85c256af01f64389a078c2b37c3b72a27d97536.1668005062.git.geert+renesas@glider.be/
---
arch/arm64/boot/dts/exynos/exynos850-e850-96.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/exynos/exynos850-e850-96.dts b/arch/arm64/boot/dts/exynos/exynos850-e850-96.dts
index f52a55f644f7..6ed38912507f 100644
--- a/arch/arm64/boot/dts/exynos/exynos850-e850-96.dts
+++ b/arch/arm64/boot/dts/exynos/exynos850-e850-96.dts
@@ -106,7 +106,7 @@ bt_active_led: led-5 {
gpios = <&gpg2 7 GPIO_ACTIVE_HIGH>;
color = <LED_COLOR_ID_BLUE>;
function = LED_FUNCTION_BLUETOOTH;
- linux,default-trigger = "hci0rx";
+ linux,default-trigger = "hci0-power";
default-state = "off";
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 4/6] arm64: dts: exynos: add VPH_PWR regulator on TM2
2023-01-20 17:31 ` [PATCH 1/6] arm64: dts: exynos: disable non-working GPU on Exynos7 Espresso Krzysztof Kozlowski
2023-01-20 17:31 ` [PATCH 2/6] arm64: dts: exynos: add ADC supply " Krzysztof Kozlowski
2023-01-20 17:31 ` [PATCH 3/6] arm64: dts: exynos: correct Bluetooth LED triger on E850-96 Krzysztof Kozlowski
@ 2023-01-20 17:31 ` Krzysztof Kozlowski
2023-01-20 17:31 ` [PATCH 5/6] arm64: dts: exynos: add interrupt-controller to WM5110 " Krzysztof Kozlowski
` (3 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-20 17:31 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Alim Akhtar, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Sam Protsenko, Chanho Park, Krzysztof Kozlowski
VPH_PWR is routed to battery, so it is not configurable. However few
devices, e.g. WM5110 expect speaker power supplies, thus provide the
regulator for full hardware description. Audio amplifier also accepts
that power supply.
Keep ordering the nodes by renaming existing IRDA regulator.
This fixes dtbs_check warnings:
exynos5433-tm2e.dtb: audio-codec@0: 'SPKVDDL-supply' is a required property
exynos5433-tm2e.dtb: audio-codec@0: 'SPKVDDR-supply' is a required property
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../boot/dts/exynos/exynos5433-tm2-common.dtsi | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
index 6f701297a665..3785a6580bdf 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
@@ -99,11 +99,18 @@ max98504: amplifier@31 {
DIOVDD-supply = <&ldo3_reg>;
DVDD-supply = <&ldo3_reg>;
- /* PVDD-supply to VPH_PWR */
+ PVDD-supply = <&vph_pwr_regulator>;
};
};
- irda_regulator: irda-regulator {
+ vph_pwr_regulator: regulator-vph-pwr {
+ compatible = "regulator-fixed";
+ regulator-name = "VPH_PWR";
+ regulator-min-microvolt = <4200000>;
+ regulator-max-microvolt = <4200000>;
+ };
+
+ irda_regulator: regulator-irda {
compatible = "regulator-fixed";
enable-active-high;
gpio = <&gpr3 3 GPIO_ACTIVE_HIGH>;
@@ -1298,6 +1305,8 @@ wm5110: audio-codec@0 {
CPVDD-supply = <&ldo18_reg>;
DBVDD2-supply = <&ldo18_reg>;
DBVDD3-supply = <&ldo18_reg>;
+ SPKVDDL-supply = <&vph_pwr_regulator>;
+ SPKVDDR-supply = <&vph_pwr_regulator>;
controller-data {
samsung,spi-feedback-delay = <0>;
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 5/6] arm64: dts: exynos: add interrupt-controller to WM5110 on TM2
2023-01-20 17:31 ` [PATCH 1/6] arm64: dts: exynos: disable non-working GPU on Exynos7 Espresso Krzysztof Kozlowski
` (2 preceding siblings ...)
2023-01-20 17:31 ` [PATCH 4/6] arm64: dts: exynos: add VPH_PWR regulator on TM2 Krzysztof Kozlowski
@ 2023-01-20 17:31 ` Krzysztof Kozlowski
2023-01-20 17:31 ` [PATCH 6/6] arm64: dts: exynos: correct wlf,micd-dbtime " Krzysztof Kozlowski
` (2 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-20 17:31 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Alim Akhtar, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Sam Protsenko, Chanho Park, Krzysztof Kozlowski
The WM5110 bindings expect node to be interrupt controller:
exynos5433-tm2.dtb: audio-codec@0: 'interrupt-controller' is a required property
exynos5433-tm2.dtb: audio-codec@0: '#interrupt-cells' is a required property
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
index 3785a6580bdf..5124027d7541 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
@@ -1285,6 +1285,8 @@ wm5110: audio-codec@0 {
gpio-controller;
#gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
wlf,micd-detect-debounce = <300>;
wlf,micd-bias-start-time = <0x1>;
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 6/6] arm64: dts: exynos: correct wlf,micd-dbtime on TM2
2023-01-20 17:31 ` [PATCH 1/6] arm64: dts: exynos: disable non-working GPU on Exynos7 Espresso Krzysztof Kozlowski
` (3 preceding siblings ...)
2023-01-20 17:31 ` [PATCH 5/6] arm64: dts: exynos: add interrupt-controller to WM5110 " Krzysztof Kozlowski
@ 2023-01-20 17:31 ` Krzysztof Kozlowski
2023-01-23 10:01 ` [PATCH 1/6] arm64: dts: exynos: disable non-working GPU on Exynos7 Espresso Krzysztof Kozlowski
2023-01-28 6:49 ` Alim Akhtar
6 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-20 17:31 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Alim Akhtar, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Sam Protsenko, Chanho Park, Krzysztof Kozlowski
The wlf,micd-dbtime property of WM5110 codec can be either 2 or 4
(driver ignores other values, so assume author wanted something here):
exynos5433-tm2e.dtb: audio-codec@0: wlf,micd-dbtime:0:0: 1 is not one of [2, 4]
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
index 5124027d7541..f54f30633417 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
@@ -1291,7 +1291,7 @@ wm5110: audio-codec@0 {
wlf,micd-detect-debounce = <300>;
wlf,micd-bias-start-time = <0x1>;
wlf,micd-rate = <0x7>;
- wlf,micd-dbtime = <0x1>;
+ wlf,micd-dbtime = <0x2>;
wlf,micd-force-micbias;
wlf,micd-configs = <0x0 1 0>;
wlf,hpdet-channel = <1>;
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 1/6] arm64: dts: exynos: disable non-working GPU on Exynos7 Espresso
2023-01-20 17:31 ` [PATCH 1/6] arm64: dts: exynos: disable non-working GPU on Exynos7 Espresso Krzysztof Kozlowski
` (4 preceding siblings ...)
2023-01-20 17:31 ` [PATCH 6/6] arm64: dts: exynos: correct wlf,micd-dbtime " Krzysztof Kozlowski
@ 2023-01-23 10:01 ` Krzysztof Kozlowski
2023-01-28 6:49 ` Alim Akhtar
6 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-23 10:01 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel, Rob Herring, devicetree,
Alim Akhtar, linux-samsung-soc, Krzysztof Kozlowski,
Krzysztof Kozlowski
Cc: Sam Protsenko, Chanho Park
On Fri, 20 Jan 2023 18:31:11 +0100, Krzysztof Kozlowski wrote:
> The Panfrost GPU drivers require clock but such was not provided in
> Exynos7 DTSI. The CMU_G3D clock controller was not upstreamed, thus
> consider GPU as non-working and simply disable it to silence warnings
> like:
>
> exynos7-espresso.dtb: gpu@14ac0000: 'clocks' is a required property
>
> [...]
Applied, thanks!
[1/6] arm64: dts: exynos: disable non-working GPU on Exynos7 Espresso
https://git.kernel.org/krzk/linux/c/e251bbd6faca7f0ee1986a8534ceab9042e0e73a
[2/6] arm64: dts: exynos: add ADC supply on Exynos7 Espresso
https://git.kernel.org/krzk/linux/c/4fffea1941bf527f55f6ac98584672206b26781f
[3/6] arm64: dts: exynos: correct Bluetooth LED triger on E850-96
https://git.kernel.org/krzk/linux/c/706528771a73ad9963e257ede00a09960720fa12
[4/6] arm64: dts: exynos: add VPH_PWR regulator on TM2
https://git.kernel.org/krzk/linux/c/d65703ba28f3afc3a530d1f70f437e226733d776
[5/6] arm64: dts: exynos: add interrupt-controller to WM5110 on TM2
https://git.kernel.org/krzk/linux/c/73cdaf6c6bbec3e8b506b501863457c9d01b964d
[6/6] arm64: dts: exynos: correct wlf,micd-dbtime on TM2
https://git.kernel.org/krzk/linux/c/662009c7f4aac7bb415e75e197ff6cd83863d5ab
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: [PATCH 1/6] arm64: dts: exynos: disable non-working GPU on Exynos7 Espresso
2023-01-20 17:31 ` [PATCH 1/6] arm64: dts: exynos: disable non-working GPU on Exynos7 Espresso Krzysztof Kozlowski
` (5 preceding siblings ...)
2023-01-23 10:01 ` [PATCH 1/6] arm64: dts: exynos: disable non-working GPU on Exynos7 Espresso Krzysztof Kozlowski
@ 2023-01-28 6:49 ` Alim Akhtar
6 siblings, 0 replies; 9+ messages in thread
From: Alim Akhtar @ 2023-01-28 6:49 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Rob Herring',
'Krzysztof Kozlowski',
devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: 'Sam Protsenko', 'Chanho Park'
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Friday, January 20, 2023 11:01 PM
> To: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
> <alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Sam Protsenko <semen.protsenko@linaro.org>; Chanho Park
> <chanho61.park@samsung.com>; Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org>
> Subject: [PATCH 1/6] arm64: dts: exynos: disable non-working GPU on
> Exynos7 Espresso
>
> The Panfrost GPU drivers require clock but such was not provided in
> Exynos7 DTSI. The CMU_G3D clock controller was not upstreamed, thus
> consider GPU as non-working and simply disable it to silence warnings
> like:
>
> exynos7-espresso.dtb: gpu@14ac0000: 'clocks' is a required property
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
>
> This patchset fixes remaining Exynos/Tesla ARMv8 dtbs_check warnings. No
> more excuses for not running dtbs_check on new patches.
Thanks Krzysztof for cleaning it up.
> ---
> arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> index b846c0be90e3..829657c9c7ca 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> @@ -61,7 +61,6 @@ &fin_pll {
>
> &gpu {
> mali-supply = <&buck6_reg>;
> - status = "okay";
> };
>
> &serial_2 {
> --
> 2.34.1
^ permalink raw reply [flat|nested] 9+ messages in thread