* [PATCH 2/8] arm64: dts: qcom: sm8350: Add missing #address/size-cells to DSIn
2023-01-20 21:00 [PATCH 1/8] drm/msm/dsi: Allow 2 CTRLs on v2.5.0 Konrad Dybcio
@ 2023-01-20 21:00 ` Konrad Dybcio
2023-01-21 8:46 ` Dmitry Baryshkov
2023-01-20 21:00 ` [PATCH 3/8] arm64: dts: qcom: sm8350: Fix DSI1 interrupt Konrad Dybcio
` (8 subsequent siblings)
9 siblings, 1 reply; 18+ messages in thread
From: Konrad Dybcio @ 2023-01-20 21:00 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
Cc: marijn.suijten, Konrad Dybcio, Rob Clark, Abhinav Kumar,
Dmitry Baryshkov, Sean Paul, David Airlie, Daniel Vetter,
Douglas Anderson, Loic Poulain, Neil Armstrong, Rajeev Nandan,
Stephen Boyd, dri-devel, freedreno, linux-kernel, Rob Herring,
Krzysztof Kozlowski, devicetree
Panels/DRM bridges definitely don't need 64bits of address space and
are usually not 32-bit wide. Set address-cells to 1 and size-cells to
0.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8350.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
index dc84dbed81bb..c0ba67747c24 100644
--- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
@@ -2989,6 +2989,9 @@ mdss_dsi0: dsi@ae94000 {
phys = <&mdss_dsi0_phy>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
dsi0_opp_table: opp-table {
@@ -3084,6 +3087,9 @@ mdss_dsi1: dsi@ae96000 {
phys = <&mdss_dsi1_phy>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
dsi1_opp_table: opp-table {
--
2.39.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH 2/8] arm64: dts: qcom: sm8350: Add missing #address/size-cells to DSIn
2023-01-20 21:00 ` [PATCH 2/8] arm64: dts: qcom: sm8350: Add missing #address/size-cells to DSIn Konrad Dybcio
@ 2023-01-21 8:46 ` Dmitry Baryshkov
0 siblings, 0 replies; 18+ messages in thread
From: Dmitry Baryshkov @ 2023-01-21 8:46 UTC (permalink / raw)
To: Konrad Dybcio, linux-arm-msm, andersson, agross, krzysztof.kozlowski
Cc: marijn.suijten, Rob Clark, Abhinav Kumar, Sean Paul,
David Airlie, Daniel Vetter, Douglas Anderson, Loic Poulain,
Neil Armstrong, Rajeev Nandan, Stephen Boyd, dri-devel,
freedreno, linux-kernel, Rob Herring, Krzysztof Kozlowski,
devicetree
On 20/01/2023 23:00, Konrad Dybcio wrote:
> Panels/DRM bridges definitely don't need 64bits of address space and
> are usually not 32-bit wide. Set address-cells to 1 and size-cells to
> 0.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sm8350.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 3/8] arm64: dts: qcom: sm8350: Fix DSI1 interrupt
2023-01-20 21:00 [PATCH 1/8] drm/msm/dsi: Allow 2 CTRLs on v2.5.0 Konrad Dybcio
2023-01-20 21:00 ` [PATCH 2/8] arm64: dts: qcom: sm8350: Add missing #address/size-cells to DSIn Konrad Dybcio
@ 2023-01-20 21:00 ` Konrad Dybcio
2023-01-21 8:46 ` Dmitry Baryshkov
2023-01-20 21:00 ` [PATCH 4/8] arm64: dts: qcom: sm8350: Feed DSI1 PHY clocks to DISPCC Konrad Dybcio
` (7 subsequent siblings)
9 siblings, 1 reply; 18+ messages in thread
From: Konrad Dybcio @ 2023-01-20 21:00 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
Cc: marijn.suijten, Konrad Dybcio, Rob Clark, Abhinav Kumar,
Dmitry Baryshkov, Sean Paul, David Airlie, Daniel Vetter,
Douglas Anderson, Loic Poulain, Neil Armstrong, Rajeev Nandan,
Stephen Boyd, dri-devel, freedreno, linux-kernel, Rob Herring,
Krzysztof Kozlowski, Robert Foss, devicetree
The interrupt was wrong, likely copypasted from DSI0. Fix it.
Fixes: d4a4410583ed ("arm64: dts: qcom: sm8350: Add display system nodes")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8350.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
index c0ba67747c24..ed0106829cb9 100644
--- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
@@ -3062,7 +3062,7 @@ mdss_dsi1: dsi@ae96000 {
reg-names = "dsi_ctrl";
interrupt-parent = <&mdss>;
- interrupts = <4>;
+ interrupts = <5>;
clocks = <&dispcc DISP_CC_MDSS_BYTE1_CLK>,
<&dispcc DISP_CC_MDSS_BYTE1_INTF_CLK>,
--
2.39.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH 3/8] arm64: dts: qcom: sm8350: Fix DSI1 interrupt
2023-01-20 21:00 ` [PATCH 3/8] arm64: dts: qcom: sm8350: Fix DSI1 interrupt Konrad Dybcio
@ 2023-01-21 8:46 ` Dmitry Baryshkov
0 siblings, 0 replies; 18+ messages in thread
From: Dmitry Baryshkov @ 2023-01-21 8:46 UTC (permalink / raw)
To: Konrad Dybcio, linux-arm-msm, andersson, agross, krzysztof.kozlowski
Cc: marijn.suijten, Rob Clark, Abhinav Kumar, Sean Paul,
David Airlie, Daniel Vetter, Douglas Anderson, Loic Poulain,
Neil Armstrong, Rajeev Nandan, Stephen Boyd, dri-devel,
freedreno, linux-kernel, Rob Herring, Krzysztof Kozlowski,
Robert Foss, devicetree
On 20/01/2023 23:00, Konrad Dybcio wrote:
> The interrupt was wrong, likely copypasted from DSI0. Fix it.
>
> Fixes: d4a4410583ed ("arm64: dts: qcom: sm8350: Add display system nodes")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sm8350.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 4/8] arm64: dts: qcom: sm8350: Feed DSI1 PHY clocks to DISPCC
2023-01-20 21:00 [PATCH 1/8] drm/msm/dsi: Allow 2 CTRLs on v2.5.0 Konrad Dybcio
2023-01-20 21:00 ` [PATCH 2/8] arm64: dts: qcom: sm8350: Add missing #address/size-cells to DSIn Konrad Dybcio
2023-01-20 21:00 ` [PATCH 3/8] arm64: dts: qcom: sm8350: Fix DSI1 interrupt Konrad Dybcio
@ 2023-01-20 21:00 ` Konrad Dybcio
2023-01-21 8:47 ` Dmitry Baryshkov
2023-01-20 21:00 ` [PATCH 5/8] arm64: dts: qcom: sm8350: Fix DSI PHY compatibles Konrad Dybcio
` (6 subsequent siblings)
9 siblings, 1 reply; 18+ messages in thread
From: Konrad Dybcio @ 2023-01-20 21:00 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
Cc: marijn.suijten, Konrad Dybcio, Rob Clark, Abhinav Kumar,
Dmitry Baryshkov, Sean Paul, David Airlie, Daniel Vetter,
Douglas Anderson, Loic Poulain, Neil Armstrong, Rajeev Nandan,
Stephen Boyd, dri-devel, freedreno, linux-kernel, Rob Herring,
Krzysztof Kozlowski, Robert Foss, devicetree
This was omitted but is necessary for DSI1 to function. Fix it.
Fixes: d4a4410583ed ("arm64: dts: qcom: sm8350: Add display system nodes")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8350.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
index ed0106829cb9..c964d939289b 100644
--- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
@@ -3159,7 +3159,7 @@ dispcc: clock-controller@af00000 {
reg = <0 0x0af00000 0 0x10000>;
clocks = <&rpmhcc RPMH_CXO_CLK>,
<&mdss_dsi0_phy 0>, <&mdss_dsi0_phy 1>,
- <0>, <0>,
+ <&mdss_dsi1_phy 0>, <&mdss_dsi1_phy 1>,
<0>,
<0>;
clock-names = "bi_tcxo",
--
2.39.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH 4/8] arm64: dts: qcom: sm8350: Feed DSI1 PHY clocks to DISPCC
2023-01-20 21:00 ` [PATCH 4/8] arm64: dts: qcom: sm8350: Feed DSI1 PHY clocks to DISPCC Konrad Dybcio
@ 2023-01-21 8:47 ` Dmitry Baryshkov
0 siblings, 0 replies; 18+ messages in thread
From: Dmitry Baryshkov @ 2023-01-21 8:47 UTC (permalink / raw)
To: Konrad Dybcio, linux-arm-msm, andersson, agross, krzysztof.kozlowski
Cc: marijn.suijten, Rob Clark, Abhinav Kumar, Sean Paul,
David Airlie, Daniel Vetter, Douglas Anderson, Loic Poulain,
Neil Armstrong, Rajeev Nandan, Stephen Boyd, dri-devel,
freedreno, linux-kernel, Rob Herring, Krzysztof Kozlowski,
Robert Foss, devicetree
On 20/01/2023 23:00, Konrad Dybcio wrote:
> This was omitted but is necessary for DSI1 to function. Fix it.
>
> Fixes: d4a4410583ed ("arm64: dts: qcom: sm8350: Add display system nodes")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sm8350.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 5/8] arm64: dts: qcom: sm8350: Fix DSI PHY compatibles
2023-01-20 21:00 [PATCH 1/8] drm/msm/dsi: Allow 2 CTRLs on v2.5.0 Konrad Dybcio
` (2 preceding siblings ...)
2023-01-20 21:00 ` [PATCH 4/8] arm64: dts: qcom: sm8350: Feed DSI1 PHY clocks to DISPCC Konrad Dybcio
@ 2023-01-20 21:00 ` Konrad Dybcio
2023-01-21 8:47 ` Dmitry Baryshkov
2023-01-20 21:00 ` [PATCH 6/8] arm64: dts: qcom: sm8350: Fix DSI PLL size Konrad Dybcio
` (5 subsequent siblings)
9 siblings, 1 reply; 18+ messages in thread
From: Konrad Dybcio @ 2023-01-20 21:00 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
Cc: marijn.suijten, Konrad Dybcio, Rob Clark, Abhinav Kumar,
Dmitry Baryshkov, Sean Paul, David Airlie, Daniel Vetter,
Douglas Anderson, Loic Poulain, Neil Armstrong, Rajeev Nandan,
Stephen Boyd, dri-devel, freedreno, linux-kernel, Rob Herring,
Krzysztof Kozlowski, Robert Foss, devicetree
The compatibles were wrong, resulting in the driver not probing. Fix
that.
Fixes: d4a4410583ed ("arm64: dts: qcom: sm8350: Add display system nodes")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8350.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
index c964d939289b..22bf6239c757 100644
--- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
@@ -3038,7 +3038,7 @@ dsi0_out: endpoint {
};
mdss_dsi0_phy: phy@ae94400 {
- compatible = "qcom,dsi-phy-5nm-8350";
+ compatible = "qcom,sm8350-dsi-phy-5nm";
reg = <0 0x0ae94400 0 0x200>,
<0 0x0ae94600 0 0x280>,
<0 0x0ae94900 0 0x260>;
@@ -3135,7 +3135,7 @@ dsi1_out: endpoint {
};
mdss_dsi1_phy: phy@ae96400 {
- compatible = "qcom,dsi-phy-5nm-8350";
+ compatible = "qcom,sm8350-dsi-phy-5nm";
reg = <0 0x0ae96400 0 0x200>,
<0 0x0ae96600 0 0x280>,
<0 0x0ae96900 0 0x260>;
--
2.39.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH 5/8] arm64: dts: qcom: sm8350: Fix DSI PHY compatibles
2023-01-20 21:00 ` [PATCH 5/8] arm64: dts: qcom: sm8350: Fix DSI PHY compatibles Konrad Dybcio
@ 2023-01-21 8:47 ` Dmitry Baryshkov
0 siblings, 0 replies; 18+ messages in thread
From: Dmitry Baryshkov @ 2023-01-21 8:47 UTC (permalink / raw)
To: Konrad Dybcio, linux-arm-msm, andersson, agross, krzysztof.kozlowski
Cc: marijn.suijten, Rob Clark, Abhinav Kumar, Sean Paul,
David Airlie, Daniel Vetter, Douglas Anderson, Loic Poulain,
Neil Armstrong, Rajeev Nandan, Stephen Boyd, dri-devel,
freedreno, linux-kernel, Rob Herring, Krzysztof Kozlowski,
Robert Foss, devicetree
On 20/01/2023 23:00, Konrad Dybcio wrote:
> The compatibles were wrong, resulting in the driver not probing. Fix
> that.
>
> Fixes: d4a4410583ed ("arm64: dts: qcom: sm8350: Add display system nodes")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sm8350.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 6/8] arm64: dts: qcom: sm8350: Fix DSI PLL size
2023-01-20 21:00 [PATCH 1/8] drm/msm/dsi: Allow 2 CTRLs on v2.5.0 Konrad Dybcio
` (3 preceding siblings ...)
2023-01-20 21:00 ` [PATCH 5/8] arm64: dts: qcom: sm8350: Fix DSI PHY compatibles Konrad Dybcio
@ 2023-01-20 21:00 ` Konrad Dybcio
2023-01-21 8:47 ` Dmitry Baryshkov
2023-01-20 21:00 ` [PATCH 7/8] arm64: dts: qcom: sm8350: Add mdss_ prefix to DSIn out labels Konrad Dybcio
` (4 subsequent siblings)
9 siblings, 1 reply; 18+ messages in thread
From: Konrad Dybcio @ 2023-01-20 21:00 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
Cc: marijn.suijten, Konrad Dybcio, Rob Clark, Abhinav Kumar,
Dmitry Baryshkov, Sean Paul, David Airlie, Daniel Vetter,
Douglas Anderson, Loic Poulain, Neil Armstrong, Rajeev Nandan,
Stephen Boyd, dri-devel, freedreno, linux-kernel, Rob Herring,
Krzysztof Kozlowski, Robert Foss, devicetree
As downstream indicates, DSI PLL is actually 0x27c and not 0x260-
wide. Fix that to reserve the correct registers.
Fixes: d4a4410583ed ("arm64: dts: qcom: sm8350: Add display system nodes")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8350.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
index 22bf6239c757..b09eb8880376 100644
--- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
@@ -3041,7 +3041,7 @@ mdss_dsi0_phy: phy@ae94400 {
compatible = "qcom,sm8350-dsi-phy-5nm";
reg = <0 0x0ae94400 0 0x200>,
<0 0x0ae94600 0 0x280>,
- <0 0x0ae94900 0 0x260>;
+ <0 0x0ae94900 0 0x27c>;
reg-names = "dsi_phy",
"dsi_phy_lane",
"dsi_pll";
@@ -3138,7 +3138,7 @@ mdss_dsi1_phy: phy@ae96400 {
compatible = "qcom,sm8350-dsi-phy-5nm";
reg = <0 0x0ae96400 0 0x200>,
<0 0x0ae96600 0 0x280>,
- <0 0x0ae96900 0 0x260>;
+ <0 0x0ae96900 0 0x27c>;
reg-names = "dsi_phy",
"dsi_phy_lane",
"dsi_pll";
--
2.39.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH 6/8] arm64: dts: qcom: sm8350: Fix DSI PLL size
2023-01-20 21:00 ` [PATCH 6/8] arm64: dts: qcom: sm8350: Fix DSI PLL size Konrad Dybcio
@ 2023-01-21 8:47 ` Dmitry Baryshkov
0 siblings, 0 replies; 18+ messages in thread
From: Dmitry Baryshkov @ 2023-01-21 8:47 UTC (permalink / raw)
To: Konrad Dybcio, linux-arm-msm, andersson, agross, krzysztof.kozlowski
Cc: marijn.suijten, Rob Clark, Abhinav Kumar, Sean Paul,
David Airlie, Daniel Vetter, Douglas Anderson, Loic Poulain,
Neil Armstrong, Rajeev Nandan, Stephen Boyd, dri-devel,
freedreno, linux-kernel, Rob Herring, Krzysztof Kozlowski,
Robert Foss, devicetree
On 20/01/2023 23:00, Konrad Dybcio wrote:
> As downstream indicates, DSI PLL is actually 0x27c and not 0x260-
> wide. Fix that to reserve the correct registers.
>
> Fixes: d4a4410583ed ("arm64: dts: qcom: sm8350: Add display system nodes")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sm8350.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 7/8] arm64: dts: qcom: sm8350: Add mdss_ prefix to DSIn out labels
2023-01-20 21:00 [PATCH 1/8] drm/msm/dsi: Allow 2 CTRLs on v2.5.0 Konrad Dybcio
` (4 preceding siblings ...)
2023-01-20 21:00 ` [PATCH 6/8] arm64: dts: qcom: sm8350: Fix DSI PLL size Konrad Dybcio
@ 2023-01-20 21:00 ` Konrad Dybcio
2023-01-21 8:48 ` Dmitry Baryshkov
2023-01-20 21:01 ` [PATCH 8/8] arm64: dts: qcom: sm8350: Hook up DSI1 to MDP Konrad Dybcio
` (3 subsequent siblings)
9 siblings, 1 reply; 18+ messages in thread
From: Konrad Dybcio @ 2023-01-20 21:00 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
Cc: marijn.suijten, Konrad Dybcio, Rob Clark, Abhinav Kumar,
Dmitry Baryshkov, Sean Paul, David Airlie, Daniel Vetter,
Douglas Anderson, Loic Poulain, Neil Armstrong, Rajeev Nandan,
Stephen Boyd, dri-devel, freedreno, linux-kernel, Rob Herring,
Krzysztof Kozlowski, devicetree
Add the mdss_ prefix to DSIn labels, so that the hardware blocks can
be organized near each other while retaining the alphabetical order
in device DTs when referencing by label.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 2 +-
arch/arm64/boot/dts/qcom/sm8350.dtsi | 10 +++++-----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
index 5a4c4ea4d122..df841230d1b7 100644
--- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
@@ -309,7 +309,7 @@ port@0 {
reg = <0>;
lt9611_a: endpoint {
- remote-endpoint = <&dsi0_out>;
+ remote-endpoint = <&mdss_dsi0_out>;
};
};
diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
index b09eb8880376..0f9427f3319f 100644
--- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
@@ -2952,7 +2952,7 @@ ports {
port@0 {
reg = <0>;
dpu_intf1_out: endpoint {
- remote-endpoint = <&dsi0_in>;
+ remote-endpoint = <&mdss_dsi0_in>;
};
};
};
@@ -3024,14 +3024,14 @@ ports {
port@0 {
reg = <0>;
- dsi0_in: endpoint {
+ mdss_dsi0_in: endpoint {
remote-endpoint = <&dpu_intf1_out>;
};
};
port@1 {
reg = <1>;
- dsi0_out: endpoint {
+ mdss_dsi0_out: endpoint {
};
};
};
@@ -3122,13 +3122,13 @@ ports {
port@0 {
reg = <0>;
- dsi1_in: endpoint {
+ mdss_dsi1_in: endpoint {
};
};
port@1 {
reg = <1>;
- dsi1_out: endpoint {
+ mdss_dsi1_out: endpoint {
};
};
};
--
2.39.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH 7/8] arm64: dts: qcom: sm8350: Add mdss_ prefix to DSIn out labels
2023-01-20 21:00 ` [PATCH 7/8] arm64: dts: qcom: sm8350: Add mdss_ prefix to DSIn out labels Konrad Dybcio
@ 2023-01-21 8:48 ` Dmitry Baryshkov
0 siblings, 0 replies; 18+ messages in thread
From: Dmitry Baryshkov @ 2023-01-21 8:48 UTC (permalink / raw)
To: Konrad Dybcio, linux-arm-msm, andersson, agross, krzysztof.kozlowski
Cc: marijn.suijten, Rob Clark, Abhinav Kumar, Sean Paul,
David Airlie, Daniel Vetter, Douglas Anderson, Loic Poulain,
Neil Armstrong, Rajeev Nandan, Stephen Boyd, dri-devel,
freedreno, linux-kernel, Rob Herring, Krzysztof Kozlowski,
devicetree
On 20/01/2023 23:00, Konrad Dybcio wrote:
> Add the mdss_ prefix to DSIn labels, so that the hardware blocks can
> be organized near each other while retaining the alphabetical order
> in device DTs when referencing by label.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 2 +-
> arch/arm64/boot/dts/qcom/sm8350.dtsi | 10 +++++-----
> 2 files changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 8/8] arm64: dts: qcom: sm8350: Hook up DSI1 to MDP
2023-01-20 21:00 [PATCH 1/8] drm/msm/dsi: Allow 2 CTRLs on v2.5.0 Konrad Dybcio
` (5 preceding siblings ...)
2023-01-20 21:00 ` [PATCH 7/8] arm64: dts: qcom: sm8350: Add mdss_ prefix to DSIn out labels Konrad Dybcio
@ 2023-01-20 21:01 ` Konrad Dybcio
2023-01-21 8:48 ` Dmitry Baryshkov
2023-01-21 8:42 ` [PATCH 1/8] drm/msm/dsi: Allow 2 CTRLs on v2.5.0 Dmitry Baryshkov
` (2 subsequent siblings)
9 siblings, 1 reply; 18+ messages in thread
From: Konrad Dybcio @ 2023-01-20 21:01 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
Cc: marijn.suijten, Konrad Dybcio, Rob Clark, Abhinav Kumar,
Dmitry Baryshkov, Sean Paul, David Airlie, Daniel Vetter,
Douglas Anderson, Loic Poulain, Neil Armstrong, Rajeev Nandan,
Stephen Boyd, dri-devel, freedreno, linux-kernel, Rob Herring,
Krzysztof Kozlowski, Robert Foss, devicetree
Somehow DSI1 was not hooked up to MDP resulting in it not working.
Fix it.
Fixes: d4a4410583ed ("arm64: dts: qcom: sm8350: Add display system nodes")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8350.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
index 0f9427f3319f..2531a9a80194 100644
--- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
@@ -2955,6 +2955,13 @@ dpu_intf1_out: endpoint {
remote-endpoint = <&mdss_dsi0_in>;
};
};
+
+ port@1 {
+ reg = <1>;
+ dpu_intf2_out: endpoint {
+ remote-endpoint = <&mdss_dsi1_in>;
+ };
+ };
};
};
@@ -3123,6 +3130,7 @@ ports {
port@0 {
reg = <0>;
mdss_dsi1_in: endpoint {
+ remote-endpoint = <&dpu_intf2_out>;
};
};
--
2.39.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH 8/8] arm64: dts: qcom: sm8350: Hook up DSI1 to MDP
2023-01-20 21:01 ` [PATCH 8/8] arm64: dts: qcom: sm8350: Hook up DSI1 to MDP Konrad Dybcio
@ 2023-01-21 8:48 ` Dmitry Baryshkov
0 siblings, 0 replies; 18+ messages in thread
From: Dmitry Baryshkov @ 2023-01-21 8:48 UTC (permalink / raw)
To: Konrad Dybcio, linux-arm-msm, andersson, agross, krzysztof.kozlowski
Cc: marijn.suijten, Rob Clark, Abhinav Kumar, Sean Paul,
David Airlie, Daniel Vetter, Douglas Anderson, Loic Poulain,
Neil Armstrong, Rajeev Nandan, Stephen Boyd, dri-devel,
freedreno, linux-kernel, Rob Herring, Krzysztof Kozlowski,
Robert Foss, devicetree
On 20/01/2023 23:01, Konrad Dybcio wrote:
> Somehow DSI1 was not hooked up to MDP resulting in it not working.
> Fix it.
>
> Fixes: d4a4410583ed ("arm64: dts: qcom: sm8350: Add display system nodes")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sm8350.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/8] drm/msm/dsi: Allow 2 CTRLs on v2.5.0
2023-01-20 21:00 [PATCH 1/8] drm/msm/dsi: Allow 2 CTRLs on v2.5.0 Konrad Dybcio
` (6 preceding siblings ...)
2023-01-20 21:01 ` [PATCH 8/8] arm64: dts: qcom: sm8350: Hook up DSI1 to MDP Konrad Dybcio
@ 2023-01-21 8:42 ` Dmitry Baryshkov
2023-01-21 10:18 ` Dmitry Baryshkov
2023-01-30 23:46 ` (subset) " Bjorn Andersson
9 siblings, 0 replies; 18+ messages in thread
From: Dmitry Baryshkov @ 2023-01-21 8:42 UTC (permalink / raw)
To: Konrad Dybcio, linux-arm-msm, andersson, agross, krzysztof.kozlowski
Cc: marijn.suijten, Rob Clark, Abhinav Kumar, Sean Paul,
David Airlie, Daniel Vetter, Douglas Anderson, Loic Poulain,
Neil Armstrong, Rajeev Nandan, Stephen Boyd, dri-devel,
freedreno, linux-kernel
On 20/01/2023 23:00, Konrad Dybcio wrote:
> v2.5.0 support was originally added for SC7280, but this hw is also
> present on SM8350, which has one more DSI host. Bump up the dsi count
> and fill in the register of the secondary host to allow it to probe.
>
> This should not have any adverse effects on SC7280, as the secondary
> CTRL will only be touched if it's defined, anyway.
>
> Fixes: 65c391b31994 ("drm/msm/dsi: Add DSI support for SC7280")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> drivers/gpu/drm/msm/dsi/dsi_cfg.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/8] drm/msm/dsi: Allow 2 CTRLs on v2.5.0
2023-01-20 21:00 [PATCH 1/8] drm/msm/dsi: Allow 2 CTRLs on v2.5.0 Konrad Dybcio
` (7 preceding siblings ...)
2023-01-21 8:42 ` [PATCH 1/8] drm/msm/dsi: Allow 2 CTRLs on v2.5.0 Dmitry Baryshkov
@ 2023-01-21 10:18 ` Dmitry Baryshkov
2023-01-30 23:46 ` (subset) " Bjorn Andersson
9 siblings, 0 replies; 18+ messages in thread
From: Dmitry Baryshkov @ 2023-01-21 10:18 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross, krzysztof.kozlowski, Konrad Dybcio
Cc: marijn.suijten, Rob Clark, Abhinav Kumar, Sean Paul,
David Airlie, Daniel Vetter, Douglas Anderson, Loic Poulain,
Neil Armstrong, Rajeev Nandan, Stephen Boyd, dri-devel,
freedreno, linux-kernel
On Fri, 20 Jan 2023 22:00:53 +0100, Konrad Dybcio wrote:
> v2.5.0 support was originally added for SC7280, but this hw is also
> present on SM8350, which has one more DSI host. Bump up the dsi count
> and fill in the register of the secondary host to allow it to probe.
>
> This should not have any adverse effects on SC7280, as the secondary
> CTRL will only be touched if it's defined, anyway.
>
> [...]
Applied, thanks!
[1/8] drm/msm/dsi: Allow 2 CTRLs on v2.5.0
https://gitlab.freedesktop.org/lumag/msm/-/commit/1fe5158e7894
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: (subset) [PATCH 1/8] drm/msm/dsi: Allow 2 CTRLs on v2.5.0
2023-01-20 21:00 [PATCH 1/8] drm/msm/dsi: Allow 2 CTRLs on v2.5.0 Konrad Dybcio
` (8 preceding siblings ...)
2023-01-21 10:18 ` Dmitry Baryshkov
@ 2023-01-30 23:46 ` Bjorn Andersson
9 siblings, 0 replies; 18+ messages in thread
From: Bjorn Andersson @ 2023-01-30 23:46 UTC (permalink / raw)
To: agross, linux-arm-msm, konrad.dybcio, krzysztof.kozlowski
Cc: neil.armstrong, dmitry.baryshkov, sean, dri-devel, airlied,
robdclark, freedreno, marijn.suijten, daniel, linux-kernel,
dianders, quic_rajeevny, loic.poulain, quic_abhinavk, swboyd
On Fri, 20 Jan 2023 22:00:53 +0100, Konrad Dybcio wrote:
> v2.5.0 support was originally added for SC7280, but this hw is also
> present on SM8350, which has one more DSI host. Bump up the dsi count
> and fill in the register of the secondary host to allow it to probe.
>
> This should not have any adverse effects on SC7280, as the secondary
> CTRL will only be touched if it's defined, anyway.
>
> [...]
Applied, thanks!
[2/8] arm64: dts: qcom: sm8350: Add missing #address/size-cells to DSIn
commit: 6636818ecf0f1d448360835017473cf94a0ee967
[3/8] arm64: dts: qcom: sm8350: Fix DSI1 interrupt
commit: 1eed7995d9da0489e5a46c13bd888ffa987ead98
[4/8] arm64: dts: qcom: sm8350: Feed DSI1 PHY clocks to DISPCC
commit: 0af6a4012b3815ebca7b8080a286edc01e4a89e1
[5/8] arm64: dts: qcom: sm8350: Fix DSI PHY compatibles
commit: 45cd807de14388010a279765486c13f8ac540dfa
[6/8] arm64: dts: qcom: sm8350: Fix DSI PLL size
commit: e3e654ced376060d64ede8e2dfde0b1bac0f9086
[7/8] arm64: dts: qcom: sm8350: Add mdss_ prefix to DSIn out labels
commit: 2a07efb8c08619888428cc8fd47643c438111f29
[8/8] arm64: dts: qcom: sm8350: Hook up DSI1 to MDP
commit: b904227a4b693fbb9d5eabc9d7100dc01d9eb973
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 18+ messages in thread