linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Richard Zhu <hongxing.zhu@nxp.com>
Cc: l.stach@pengutronix.de, bhelgaas@google.com, robh+dt@kernel.org,
	lorenzo.pieralisi@arm.com, kishon@ti.com, kw@linux.com,
	frank.li@nxp.com, linux-pci@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de,
	linux-imx@nxp.com
Subject: Re: [PATCH v5 04/14] arm64: dts: Add i.MX8MM PCIe EP support
Date: Thu, 26 Jan 2023 14:47:30 +0800	[thread overview]
Message-ID: <20230126064728.GQ20713@T480> (raw)
In-Reply-To: <1673847684-31893-5-git-send-email-hongxing.zhu@nxp.com>

On Mon, Jan 16, 2023 at 01:41:14PM +0800, Richard Zhu wrote:
> Add i.MX8MM PCIe EP support.
> 
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mm.dtsi | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index 4ee89fdcf59b..8124761f629c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -1293,6 +1293,26 @@ pcie0: pcie@33800000 {
>  			status = "disabled";
>  		};
>  
> +		pcie0_ep: pcie_ep@33800000 {

Hyphen is more preferable than underscore in name node.

I fixed it (and the other two patches) up, and applied all DTS patches.

Shawn

> +			compatible = "fsl,imx8mm-pcie-ep";
> +			reg = <0x33800000 0x400000>,
> +			      <0x18000000 0x8000000>;
> +			reg-names = "regs", "addr_space";
> +			num-lanes = <1>;
> +			interrupts = <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupt-names = "dma";
> +			fsl,max-link-speed = <2>;
> +			power-domains = <&pgc_pcie>;
> +			resets = <&src IMX8MQ_RESET_PCIE_CTRL_APPS_EN>,
> +				 <&src IMX8MQ_RESET_PCIE_CTRL_APPS_TURNOFF>;
> +			reset-names = "apps", "turnoff";
> +			phys = <&pcie_phy>;
> +			phy-names = "pcie-phy";
> +			num-ib-windows = <4>;
> +			num-ob-windows = <4>;
> +			status = "disabled";
> +		};
> +
>  		gpu_3d: gpu@38000000 {
>  			compatible = "vivante,gc";
>  			reg = <0x38000000 0x8000>;
> -- 
> 2.25.1
> 

  reply	other threads:[~2023-01-26  6:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-16  5:41 [PATCH v5 0/14] Add i.MX PCIe EP mode support Richard Zhu
2023-01-16  5:41 ` [PATCH v5 01/14] dt-bindings: imx6q-pcie: Add i.MX8MM PCIe EP mode compatible string Richard Zhu
2023-01-16  5:41 ` [PATCH v5 02/14] dt-bindings: imx6q-pcie: Add i.MX8MQ " Richard Zhu
2023-01-16  5:41 ` [PATCH v5 03/14] dt-bindings: imx6q-pcie: Add i.MX8MP " Richard Zhu
2023-01-16  5:41 ` [PATCH v5 04/14] arm64: dts: Add i.MX8MM PCIe EP support Richard Zhu
2023-01-26  6:47   ` Shawn Guo [this message]
2023-01-26  8:37     ` Shawn Guo
2023-01-16  5:41 ` [PATCH v5 05/14] arm64: dts: Add i.MX8MM PCIe EP support on EVK board Richard Zhu
2023-01-16  5:41 ` [PATCH v5 06/14] arm64: dts: Add i.MX8MQ PCIe EP support Richard Zhu
2023-01-16  5:41 ` [PATCH v5 07/14] arm64: dts: Add i.MX8MQ PCIe EP support on EVK board Richard Zhu
2023-01-16  5:41 ` [PATCH v5 08/14] arm64: dts: Add i.MX8MP PCIe EP support Richard Zhu
2023-01-16  5:41 ` [PATCH v5 09/14] arm64: dts: Add i.MX8MP PCIe EP support on EVK board Richard Zhu
2023-01-16  5:41 ` [PATCH v5 10/14] misc: pci_endpoint_test: Add i.MX8 PCIe EP device support Richard Zhu
2023-01-16  5:41 ` [PATCH v5 11/14] PCI: imx6: Add i.MX PCIe EP mode support Richard Zhu
2023-01-16  5:41 ` [PATCH v5 12/14] PCI: imx6: Add i.MX8MQ PCIe EP support Richard Zhu
2023-01-16  5:41 ` [PATCH v5 13/14] PCI: imx6: Add i.MX8MM " Richard Zhu
2023-01-16  5:41 ` [PATCH v5 14/14] PCI: imx6: Add i.MX8MP " Richard Zhu
2023-01-16  9:45 ` (subset) [PATCH v5 0/14] Add i.MX PCIe EP mode support Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230126064728.GQ20713@T480 \
    --to=shawnguo@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frank.li@nxp.com \
    --cc=hongxing.zhu@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=kishon@ti.com \
    --cc=kw@linux.com \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).