* [PATCH v2] mfd: ntxec: Add version number for EC in Tolino Vision
@ 2023-01-27 16:58 Andreas Kemnade
2023-01-27 17:15 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Kemnade @ 2023-01-27 16:58 UTC (permalink / raw)
To: j.neuschaefer, lee, linux-kernel; +Cc: Andreas Kemnade
The EC firmware has a different version number than anything
defined until now.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
Changes in V2:
use the same formatting as the other version numbers
drivers/mfd/ntxec.c | 1 +
include/linux/mfd/ntxec.h | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/ntxec.c b/drivers/mfd/ntxec.c
index e16a7a82a929..b02785b10d48 100644
--- a/drivers/mfd/ntxec.c
+++ b/drivers/mfd/ntxec.c
@@ -175,6 +175,7 @@ static int ntxec_probe(struct i2c_client *client)
/* Bail out if we encounter an unknown firmware version */
switch (version) {
case NTXEC_VERSION_KOBO_AURA:
+ case NTXEC_VERSION_TOLINO_VISION:
subdevs = ntxec_subdev;
n_subdevs = ARRAY_SIZE(ntxec_subdev);
break;
diff --git a/include/linux/mfd/ntxec.h b/include/linux/mfd/ntxec.h
index cc6f07bfa2b3..e5880c346da9 100644
--- a/include/linux/mfd/ntxec.h
+++ b/include/linux/mfd/ntxec.h
@@ -34,5 +34,5 @@ static inline u16 ntxec_reg8(u8 value)
/* Known firmware versions */
#define NTXEC_VERSION_KOBO_AURA 0xd726 /* found in Kobo Aura */
#define NTXEC_VERSION_TOLINO_SHINE2 0xf110 /* found in Tolino Shine 2 HD */
-
+#define NTXEC_VERSION_TOLINO_VISION 0xe135 /* found in Tolino Vision, contains RTC, ADC, PWM, home pad */
#endif
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] mfd: ntxec: Add version number for EC in Tolino Vision
2023-01-27 16:58 [PATCH v2] mfd: ntxec: Add version number for EC in Tolino Vision Andreas Kemnade
@ 2023-01-27 17:15 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2023-01-27 17:15 UTC (permalink / raw)
To: Andreas Kemnade; +Cc: j.neuschaefer, linux-kernel
On Fri, 27 Jan 2023, Andreas Kemnade wrote:
> The EC firmware has a different version number than anything
> defined until now.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> Changes in V2:
> use the same formatting as the other version numbers
>
> drivers/mfd/ntxec.c | 1 +
> include/linux/mfd/ntxec.h | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
Applied, thanks
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-27 17:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-27 16:58 [PATCH v2] mfd: ntxec: Add version number for EC in Tolino Vision Andreas Kemnade
2023-01-27 17:15 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).