* [PATCH bpf-next] bpf: Build-time assert that cpumask offset is zero
@ 2023-01-28 14:15 David Vernet
2023-01-28 20:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: David Vernet @ 2023-01-28 14:15 UTC (permalink / raw)
To: bpf
Cc: ast, daniel, andrii, martin.lau, song, yhs, john.fastabend,
kpsingh, sdf, haoluo, jolsa, linux-kernel, kernel-team
The first element of a struct bpf_cpumask is a cpumask_t. This is done
to allow struct bpf_cpumask to be cast to a struct cpumask. If this
element were ever moved to another field, any BPF program passing a
struct bpf_cpumask * to a kfunc expecting a const struct cpumask * would
immediately fail to load. Add a build-time assertion so this is
assumption is captured and verified.
Signed-off-by: David Vernet <void@manifault.com>
---
kernel/bpf/cpumask.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/kernel/bpf/cpumask.c b/kernel/bpf/cpumask.c
index 25355a0a367a..6bbb67dfc998 100644
--- a/kernel/bpf/cpumask.c
+++ b/kernel/bpf/cpumask.c
@@ -52,6 +52,9 @@ struct bpf_cpumask *bpf_cpumask_create(void)
{
struct bpf_cpumask *cpumask;
+ /* cpumask must be the first element so struct bpf_cpumask be cast to struct cpumask. */
+ BUILD_BUG_ON(offsetof(struct bpf_cpumask, cpumask) != 0);
+
cpumask = bpf_mem_alloc(&bpf_cpumask_ma, sizeof(*cpumask));
if (!cpumask)
return NULL;
--
2.39.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH bpf-next] bpf: Build-time assert that cpumask offset is zero
2023-01-28 14:15 [PATCH bpf-next] bpf: Build-time assert that cpumask offset is zero David Vernet
@ 2023-01-28 20:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-01-28 20:30 UTC (permalink / raw)
To: David Vernet
Cc: bpf, ast, daniel, andrii, martin.lau, song, yhs, john.fastabend,
kpsingh, sdf, haoluo, jolsa, linux-kernel, kernel-team
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:
On Sat, 28 Jan 2023 08:15:37 -0600 you wrote:
> The first element of a struct bpf_cpumask is a cpumask_t. This is done
> to allow struct bpf_cpumask to be cast to a struct cpumask. If this
> element were ever moved to another field, any BPF program passing a
> struct bpf_cpumask * to a kfunc expecting a const struct cpumask * would
> immediately fail to load. Add a build-time assertion so this is
> assumption is captured and verified.
>
> [...]
Here is the summary with links:
- [bpf-next] bpf: Build-time assert that cpumask offset is zero
https://git.kernel.org/bpf/bpf-next/c/cb4a21ea592f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-28 20:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-28 14:15 [PATCH bpf-next] bpf: Build-time assert that cpumask offset is zero David Vernet
2023-01-28 20:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).