linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: wpcm450: Add nuvoton,shm = <&shm> to FIU node
@ 2023-01-29 11:26 Jonathan Neuschäfer
  2023-02-01  4:32 ` Joel Stanley
  0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Neuschäfer @ 2023-01-29 11:26 UTC (permalink / raw)
  To: openbmc
  Cc: Jonathan Neuschäfer, Rob Herring, Krzysztof Kozlowski,
	Joel Stanley, devicetree, linux-kernel

The Flash Interface Unit (FIU) should have a reference to the Shared
Memory controller (SHM) so that flash access from the host (x86 computer
managed by the WPCM450 BMC) can be blocked during flash access by the
FIU driver.

Fixes: 38abcb0d68767 ("ARM: dts: wpcm450: Add FIU SPI controller node")
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
 arch/arm/boot/dts/nuvoton-wpcm450.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/nuvoton-wpcm450.dtsi b/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
index 299fcbba3089b..fda2f13093f98 100644
--- a/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
+++ b/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
@@ -478,6 +478,7 @@ fiu: spi-controller@c8000000 {
 			reg = <0xc8000000 0x1000>, <0xc0000000 0x4000000>;
 			reg-names = "control", "memory";
 			clocks = <&clk WPCM450_CLK_FIU>;
+			nuvoton,shm = <&shm>;
 			status = "disabled";
 		};

--
2.39.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: wpcm450: Add nuvoton,shm = <&shm> to FIU node
  2023-01-29 11:26 [PATCH] ARM: dts: wpcm450: Add nuvoton,shm = <&shm> to FIU node Jonathan Neuschäfer
@ 2023-02-01  4:32 ` Joel Stanley
  0 siblings, 0 replies; 2+ messages in thread
From: Joel Stanley @ 2023-02-01  4:32 UTC (permalink / raw)
  To: Jonathan Neuschäfer
  Cc: openbmc, Rob Herring, Krzysztof Kozlowski, devicetree, linux-kernel

On Sun, 29 Jan 2023 at 11:26, Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote:
>
> The Flash Interface Unit (FIU) should have a reference to the Shared
> Memory controller (SHM) so that flash access from the host (x86 computer
> managed by the WPCM450 BMC) can be blocked during flash access by the
> FIU driver.
>
> Fixes: 38abcb0d68767 ("ARM: dts: wpcm450: Add FIU SPI controller node")
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>

Reviewed-by: Joel Stanley <joel@jms.id.au>

I'll send this to the soc maintainers.


> ---
>  arch/arm/boot/dts/nuvoton-wpcm450.dtsi | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/nuvoton-wpcm450.dtsi b/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
> index 299fcbba3089b..fda2f13093f98 100644
> --- a/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
> +++ b/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
> @@ -478,6 +478,7 @@ fiu: spi-controller@c8000000 {
>                         reg = <0xc8000000 0x1000>, <0xc0000000 0x4000000>;
>                         reg-names = "control", "memory";
>                         clocks = <&clk WPCM450_CLK_FIU>;
> +                       nuvoton,shm = <&shm>;
>                         status = "disabled";
>                 };
>
> --
> 2.39.0
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-02-01  4:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-29 11:26 [PATCH] ARM: dts: wpcm450: Add nuvoton,shm = <&shm> to FIU node Jonathan Neuschäfer
2023-02-01  4:32 ` Joel Stanley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).