* [PATCH] tracing: Fix wrong return in kprobe_event_gen_test.c
@ 2023-01-31 7:58 Anton Gusev
2023-01-31 15:13 ` Steven Rostedt
2023-01-31 15:37 ` Masami Hiramatsu
0 siblings, 2 replies; 3+ messages in thread
From: Anton Gusev @ 2023-01-31 7:58 UTC (permalink / raw)
To: Steven Rostedt
Cc: Anton Gusev, Masami Hiramatsu, linux-kernel, linux-trace-kernel
Overwriting the error code with the deletion result may cause the
function to return 0 despite encountering an error. Commit b111545d26c0
("tracing: Remove the useless value assignment in
test_create_synth_event()") solves a similar issue by
returning the original error code, so this patch does the same.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Anton Gusev <aagusev@ispras.ru>
---
kernel/trace/kprobe_event_gen_test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/trace/kprobe_event_gen_test.c b/kernel/trace/kprobe_event_gen_test.c
index c736487fc0e4..e0c420eb0b2b 100644
--- a/kernel/trace/kprobe_event_gen_test.c
+++ b/kernel/trace/kprobe_event_gen_test.c
@@ -146,7 +146,7 @@ static int __init test_gen_kprobe_cmd(void)
if (trace_event_file_is_valid(gen_kprobe_test))
gen_kprobe_test = NULL;
/* We got an error after creating the event, delete it */
- ret = kprobe_event_delete("gen_kprobe_test");
+ kprobe_event_delete("gen_kprobe_test");
goto out;
}
@@ -211,7 +211,7 @@ static int __init test_gen_kretprobe_cmd(void)
if (trace_event_file_is_valid(gen_kretprobe_test))
gen_kretprobe_test = NULL;
/* We got an error after creating the event, delete it */
- ret = kprobe_event_delete("gen_kretprobe_test");
+ kprobe_event_delete("gen_kretprobe_test");
goto out;
}
--
2.39.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tracing: Fix wrong return in kprobe_event_gen_test.c
2023-01-31 7:58 [PATCH] tracing: Fix wrong return in kprobe_event_gen_test.c Anton Gusev
@ 2023-01-31 15:13 ` Steven Rostedt
2023-01-31 15:37 ` Masami Hiramatsu
1 sibling, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2023-01-31 15:13 UTC (permalink / raw)
To: Anton Gusev; +Cc: Masami Hiramatsu, linux-kernel, linux-trace-kernel
On Tue, 31 Jan 2023 10:58:18 +0300
Anton Gusev <aagusev@ispras.ru> wrote:
> Overwriting the error code with the deletion result may cause the
> function to return 0 despite encountering an error. Commit b111545d26c0
> ("tracing: Remove the useless value assignment in
> test_create_synth_event()") solves a similar issue by
> returning the original error code, so this patch does the same.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Anton Gusev <aagusev@ispras.ru>
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Thanks Anton!
-- Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tracing: Fix wrong return in kprobe_event_gen_test.c
2023-01-31 7:58 [PATCH] tracing: Fix wrong return in kprobe_event_gen_test.c Anton Gusev
2023-01-31 15:13 ` Steven Rostedt
@ 2023-01-31 15:37 ` Masami Hiramatsu
1 sibling, 0 replies; 3+ messages in thread
From: Masami Hiramatsu @ 2023-01-31 15:37 UTC (permalink / raw)
To: Anton Gusev
Cc: Steven Rostedt, Masami Hiramatsu, linux-kernel, linux-trace-kernel
On Tue, 31 Jan 2023 10:58:18 +0300
Anton Gusev <aagusev@ispras.ru> wrote:
> Overwriting the error code with the deletion result may cause the
> function to return 0 despite encountering an error. Commit b111545d26c0
> ("tracing: Remove the useless value assignment in
> test_create_synth_event()") solves a similar issue by
> returning the original error code, so this patch does the same.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Anton Gusev <aagusev@ispras.ru>
Oops, thanks for the fix!
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> ---
> kernel/trace/kprobe_event_gen_test.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/trace/kprobe_event_gen_test.c b/kernel/trace/kprobe_event_gen_test.c
> index c736487fc0e4..e0c420eb0b2b 100644
> --- a/kernel/trace/kprobe_event_gen_test.c
> +++ b/kernel/trace/kprobe_event_gen_test.c
> @@ -146,7 +146,7 @@ static int __init test_gen_kprobe_cmd(void)
> if (trace_event_file_is_valid(gen_kprobe_test))
> gen_kprobe_test = NULL;
> /* We got an error after creating the event, delete it */
> - ret = kprobe_event_delete("gen_kprobe_test");
> + kprobe_event_delete("gen_kprobe_test");
> goto out;
> }
>
> @@ -211,7 +211,7 @@ static int __init test_gen_kretprobe_cmd(void)
> if (trace_event_file_is_valid(gen_kretprobe_test))
> gen_kretprobe_test = NULL;
> /* We got an error after creating the event, delete it */
> - ret = kprobe_event_delete("gen_kretprobe_test");
> + kprobe_event_delete("gen_kretprobe_test");
> goto out;
> }
>
> --
> 2.39.1
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-31 15:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-31 7:58 [PATCH] tracing: Fix wrong return in kprobe_event_gen_test.c Anton Gusev
2023-01-31 15:13 ` Steven Rostedt
2023-01-31 15:37 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).