* [PATCH 2/3] arm64: dts: qcom: sm8350-hdk: correct LT9611 pin function
2023-02-01 15:43 [PATCH 1/3] arm64: dts: qcom: sm8350-hdk: align pin config node names with bindings Krzysztof Kozlowski
@ 2023-02-01 15:43 ` Krzysztof Kozlowski
2023-02-01 15:47 ` Konrad Dybcio
2023-02-01 15:43 ` [PATCH 3/3] dt-bindings: pinctrl: qcom,sm8350: add input-disable Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-01 15:43 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Vinod Koul, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
SM8350 pin controller does not have "normal" pin function, so use
"gpio".
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
index ece1a7cb8b3b..8b7cc45b0919 100644
--- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
@@ -725,7 +725,7 @@ usb_hub_enabled_state: usb-hub-enabled-state {
lt9611_state: lt9611-state {
rst-pins {
pins = "gpio48";
- function = "normal";
+ function = "gpio";
output-high;
input-disable;
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 2/3] arm64: dts: qcom: sm8350-hdk: correct LT9611 pin function
2023-02-01 15:43 ` [PATCH 2/3] arm64: dts: qcom: sm8350-hdk: correct LT9611 pin function Krzysztof Kozlowski
@ 2023-02-01 15:47 ` Konrad Dybcio
2023-02-02 9:36 ` Krzysztof Kozlowski
0 siblings, 1 reply; 10+ messages in thread
From: Konrad Dybcio @ 2023-02-01 15:47 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Vinod Koul, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
On 1.02.2023 16:43, Krzysztof Kozlowski wrote:
> SM8350 pin controller does not have "normal" pin function, so use
> "gpio".
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Makes one wonder if it was ever tested, as this would have probably
failed when setting pinctrl settings..
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> index ece1a7cb8b3b..8b7cc45b0919 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> @@ -725,7 +725,7 @@ usb_hub_enabled_state: usb-hub-enabled-state {
> lt9611_state: lt9611-state {
> rst-pins {
> pins = "gpio48";
> - function = "normal";
> + function = "gpio";
>
> output-high;
> input-disable;
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 2/3] arm64: dts: qcom: sm8350-hdk: correct LT9611 pin function
2023-02-01 15:47 ` Konrad Dybcio
@ 2023-02-02 9:36 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-02 9:36 UTC (permalink / raw)
To: Konrad Dybcio, Andy Gross, Bjorn Andersson, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Vinod Koul, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
On 01/02/2023 16:47, Konrad Dybcio wrote:
>
>
> On 1.02.2023 16:43, Krzysztof Kozlowski wrote:
>> SM8350 pin controller does not have "normal" pin function, so use
>> "gpio".
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
> Makes one wonder if it was ever tested, as this would have probably
> failed when setting pinctrl settings..
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Fixes: d96d8f9192be ("arm64: dts: qcom: sm8350-hdk: Enable lt9611uxc dsi-hdmi bridge")
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 3/3] dt-bindings: pinctrl: qcom,sm8350: add input-disable
2023-02-01 15:43 [PATCH 1/3] arm64: dts: qcom: sm8350-hdk: align pin config node names with bindings Krzysztof Kozlowski
2023-02-01 15:43 ` [PATCH 2/3] arm64: dts: qcom: sm8350-hdk: correct LT9611 pin function Krzysztof Kozlowski
@ 2023-02-01 15:43 ` Krzysztof Kozlowski
2023-02-02 23:47 ` Rob Herring
2023-02-03 7:17 ` (subset) " Krzysztof Kozlowski
2023-02-01 15:46 ` [PATCH 1/3] arm64: dts: qcom: sm8350-hdk: align pin config node names with bindings Konrad Dybcio
2023-02-09 4:23 ` (subset) " Bjorn Andersson
3 siblings, 2 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-01 15:43 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Vinod Koul, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The SM8350 HDK8350 board uses input-disable property, so allow it:
sm8350-hdk.dtb: pinctrl@f100000: lt9611-state: 'oneOf' conditional failed, one must be fixed:
...
'input-disable' does not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/pinctrl/qcom,sm8350-tlmm.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-tlmm.yaml
index 49a74f351e99..e13d50d6d388 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-tlmm.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-tlmm.yaml
@@ -109,6 +109,7 @@ $defs:
bias-pull-down: true
bias-pull-up: true
drive-strength: true
+ input-disable: true
input-enable: true
output-high: true
output-low: true
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 3/3] dt-bindings: pinctrl: qcom,sm8350: add input-disable
2023-02-01 15:43 ` [PATCH 3/3] dt-bindings: pinctrl: qcom,sm8350: add input-disable Krzysztof Kozlowski
@ 2023-02-02 23:47 ` Rob Herring
2023-02-03 7:17 ` (subset) " Krzysztof Kozlowski
1 sibling, 0 replies; 10+ messages in thread
From: Rob Herring @ 2023-02-02 23:47 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-kernel, Rob Herring, Andy Gross, Linus Walleij,
Krzysztof Kozlowski, Konrad Dybcio, linux-arm-msm, Vinod Koul,
devicetree, Bjorn Andersson, linux-gpio
On Wed, 01 Feb 2023 16:43:21 +0100, Krzysztof Kozlowski wrote:
> The SM8350 HDK8350 board uses input-disable property, so allow it:
>
> sm8350-hdk.dtb: pinctrl@f100000: lt9611-state: 'oneOf' conditional failed, one must be fixed:
> ...
> 'input-disable' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/pinctrl/qcom,sm8350-tlmm.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: (subset) [PATCH 3/3] dt-bindings: pinctrl: qcom,sm8350: add input-disable
2023-02-01 15:43 ` [PATCH 3/3] dt-bindings: pinctrl: qcom,sm8350: add input-disable Krzysztof Kozlowski
2023-02-02 23:47 ` Rob Herring
@ 2023-02-03 7:17 ` Krzysztof Kozlowski
1 sibling, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-03 7:17 UTC (permalink / raw)
To: linux-kernel, linux-arm-msm, Krzysztof Kozlowski, Rob Herring,
Vinod Koul, Krzysztof Kozlowski, Konrad Dybcio, linux-gpio,
Andy Gross, devicetree, Linus Walleij, Bjorn Andersson
On Wed, 1 Feb 2023 16:43:21 +0100, Krzysztof Kozlowski wrote:
> The SM8350 HDK8350 board uses input-disable property, so allow it:
>
> sm8350-hdk.dtb: pinctrl@f100000: lt9611-state: 'oneOf' conditional failed, one must be fixed:
> ...
> 'input-disable' does not match any of the regexes: 'pinctrl-[0-9]+'
>
>
> [...]
Applied, thanks!
[3/3] dt-bindings: pinctrl: qcom,sm8350: add input-disable
https://git.kernel.org/krzk/linux-dt/c/91d04c759c85f1fc2d3ed7d1b5bc1a7dbab87f92
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] arm64: dts: qcom: sm8350-hdk: align pin config node names with bindings
2023-02-01 15:43 [PATCH 1/3] arm64: dts: qcom: sm8350-hdk: align pin config node names with bindings Krzysztof Kozlowski
2023-02-01 15:43 ` [PATCH 2/3] arm64: dts: qcom: sm8350-hdk: correct LT9611 pin function Krzysztof Kozlowski
2023-02-01 15:43 ` [PATCH 3/3] dt-bindings: pinctrl: qcom,sm8350: add input-disable Krzysztof Kozlowski
@ 2023-02-01 15:46 ` Konrad Dybcio
2023-02-02 9:36 ` Krzysztof Kozlowski
2023-02-09 4:23 ` (subset) " Bjorn Andersson
3 siblings, 1 reply; 10+ messages in thread
From: Konrad Dybcio @ 2023-02-01 15:46 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Vinod Koul, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
On 1.02.2023 16:43, Krzysztof Kozlowski wrote:
> Bindings expect pins to be named with certain pattern.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
Do we want a Fixes: here?
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
>
> Endless work... People keep sending patches without running dtbs_check
> faster than I am fixing existing warnings.
> ---
> arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> index df841230d1b7..ece1a7cb8b3b 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> @@ -723,7 +723,7 @@ usb_hub_enabled_state: usb-hub-enabled-state {
> };
>
> lt9611_state: lt9611-state {
> - rst {
> + rst-pins {
> pins = "gpio48";
> function = "normal";
>
> @@ -731,7 +731,7 @@ rst {
> input-disable;
> };
>
> - irq {
> + irq-pins {
> pins = "gpio50";
> function = "gpio";
> bias-disable;
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 1/3] arm64: dts: qcom: sm8350-hdk: align pin config node names with bindings
2023-02-01 15:46 ` [PATCH 1/3] arm64: dts: qcom: sm8350-hdk: align pin config node names with bindings Konrad Dybcio
@ 2023-02-02 9:36 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-02 9:36 UTC (permalink / raw)
To: Konrad Dybcio, Andy Gross, Bjorn Andersson, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Vinod Koul, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
On 01/02/2023 16:46, Konrad Dybcio wrote:
>
>
> On 1.02.2023 16:43, Krzysztof Kozlowski wrote:
>> Bindings expect pins to be named with certain pattern.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
> Do we want a Fixes: here?
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Could be:
Fixes: d96d8f9192be ("arm64: dts: qcom: sm8350-hdk: Enable lt9611uxc dsi-hdmi bridge")
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: (subset) [PATCH 1/3] arm64: dts: qcom: sm8350-hdk: align pin config node names with bindings
2023-02-01 15:43 [PATCH 1/3] arm64: dts: qcom: sm8350-hdk: align pin config node names with bindings Krzysztof Kozlowski
` (2 preceding siblings ...)
2023-02-01 15:46 ` [PATCH 1/3] arm64: dts: qcom: sm8350-hdk: align pin config node names with bindings Konrad Dybcio
@ 2023-02-09 4:23 ` Bjorn Andersson
3 siblings, 0 replies; 10+ messages in thread
From: Bjorn Andersson @ 2023-02-09 4:23 UTC (permalink / raw)
To: Andy Gross, linux-gpio, Rob Herring, Krzysztof Kozlowski,
Konrad Dybcio, devicetree, Krzysztof Kozlowski, Vinod Koul,
linux-kernel, Linus Walleij, linux-arm-msm
On Wed, 1 Feb 2023 16:43:19 +0100, Krzysztof Kozlowski wrote:
> Bindings expect pins to be named with certain pattern.
>
>
Applied, thanks!
[1/3] arm64: dts: qcom: sm8350-hdk: align pin config node names with bindings
commit: 9927f8a59f42b6c0bde9ba770ffe9d9d9bce79da
[2/3] arm64: dts: qcom: sm8350-hdk: correct LT9611 pin function
commit: cd06d923304355762d426b030a30d99fdf765b84
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 10+ messages in thread