linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] tools/lib/thermal: fix thermal_sampling_exit()
@ 2023-02-02 10:28 Vincent Guittot
  2023-02-02 15:56 ` Daniel Lezcano
  0 siblings, 1 reply; 2+ messages in thread
From: Vincent Guittot @ 2023-02-02 10:28 UTC (permalink / raw)
  To: daniel.lezcano, rafael, amitk, rui.zhang, linux-pm, linux-kernel
  Cc: Vincent Guittot

thermal_sampling_init() suscribes to THERMAL_GENL_SAMPLING_GROUP_NAME group
so thermal_sampling_exit() should unsubscribe from the same group.

Fixes: 47c4b0de080a ("tools/lib/thermal: Add a thermal library")
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
---
 tools/lib/thermal/sampling.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/lib/thermal/sampling.c b/tools/lib/thermal/sampling.c
index ee818f4e9654..70577423a9f0 100644
--- a/tools/lib/thermal/sampling.c
+++ b/tools/lib/thermal/sampling.c
@@ -54,7 +54,7 @@ int thermal_sampling_fd(struct thermal_handler *th)
 thermal_error_t thermal_sampling_exit(struct thermal_handler *th)
 {
 	if (nl_unsubscribe_thermal(th->sk_sampling, th->cb_sampling,
-				   THERMAL_GENL_EVENT_GROUP_NAME))
+				   THERMAL_GENL_SAMPLING_GROUP_NAME))
 		return THERMAL_ERROR;
 
 	nl_thermal_disconnect(th->sk_sampling, th->cb_sampling);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] tools/lib/thermal: fix thermal_sampling_exit()
  2023-02-02 10:28 [PATCH] tools/lib/thermal: fix thermal_sampling_exit() Vincent Guittot
@ 2023-02-02 15:56 ` Daniel Lezcano
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Lezcano @ 2023-02-02 15:56 UTC (permalink / raw)
  To: Vincent Guittot, rafael, amitk, rui.zhang, linux-pm, linux-kernel

On 02/02/2023 11:28, Vincent Guittot wrote:
> thermal_sampling_init() suscribes to THERMAL_GENL_SAMPLING_GROUP_NAME group
> so thermal_sampling_exit() should unsubscribe from the same group.
> 
> Fixes: 47c4b0de080a ("tools/lib/thermal: Add a thermal library")
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
> ---

Thanks for the fix, applied


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-02-02 15:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-02 10:28 [PATCH] tools/lib/thermal: fix thermal_sampling_exit() Vincent Guittot
2023-02-02 15:56 ` Daniel Lezcano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).