* [PATCH v1] remoteproc: mediatek: Check the SCP image format
@ 2023-02-10 3:13 Tinghan Shen
2023-02-10 11:32 ` Matthias Brugger
2023-02-12 20:24 ` Mathieu Poirier
0 siblings, 2 replies; 4+ messages in thread
From: Tinghan Shen @ 2023-02-10 3:13 UTC (permalink / raw)
To: Bjorn Andersson, Mathieu Poirier, Matthias Brugger,
AngeloGioacchino Del Regno
Cc: linux-remoteproc, linux-kernel, linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group, Tinghan Shen
Do a sanity check on the SCP image before loading it to avoid
driver crashes.
Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
---
drivers/remoteproc/mtk_scp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
index d421a2ccaa1e..0861b76f185f 100644
--- a/drivers/remoteproc/mtk_scp.c
+++ b/drivers/remoteproc/mtk_scp.c
@@ -649,6 +649,7 @@ static const struct rproc_ops scp_ops = {
.load = scp_load,
.da_to_va = scp_da_to_va,
.parse_fw = scp_parse_fw,
+ .sanity_check = rproc_elf_sanity_check,
};
/**
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1] remoteproc: mediatek: Check the SCP image format
2023-02-10 3:13 [PATCH v1] remoteproc: mediatek: Check the SCP image format Tinghan Shen
@ 2023-02-10 11:32 ` Matthias Brugger
2023-02-10 14:22 ` AngeloGioacchino Del Regno
2023-02-12 20:24 ` Mathieu Poirier
1 sibling, 1 reply; 4+ messages in thread
From: Matthias Brugger @ 2023-02-10 11:32 UTC (permalink / raw)
To: Tinghan Shen, Bjorn Andersson, Mathieu Poirier,
AngeloGioacchino Del Regno
Cc: linux-remoteproc, linux-kernel, linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group
On 10/02/2023 04:13, Tinghan Shen wrote:
> Do a sanity check on the SCP image before loading it to avoid
> driver crashes.
>
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/remoteproc/mtk_scp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
> index d421a2ccaa1e..0861b76f185f 100644
> --- a/drivers/remoteproc/mtk_scp.c
> +++ b/drivers/remoteproc/mtk_scp.c
> @@ -649,6 +649,7 @@ static const struct rproc_ops scp_ops = {
> .load = scp_load,
> .da_to_va = scp_da_to_va,
> .parse_fw = scp_parse_fw,
> + .sanity_check = rproc_elf_sanity_check,
> };
>
> /**
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] remoteproc: mediatek: Check the SCP image format
2023-02-10 11:32 ` Matthias Brugger
@ 2023-02-10 14:22 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 4+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-02-10 14:22 UTC (permalink / raw)
To: Matthias Brugger, Tinghan Shen, Bjorn Andersson, Mathieu Poirier
Cc: linux-remoteproc, linux-kernel, linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group
Il 10/02/23 12:32, Matthias Brugger ha scritto:
>
>
> On 10/02/2023 04:13, Tinghan Shen wrote:
>> Do a sanity check on the SCP image before loading it to avoid
>> driver crashes.
>>
>> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] remoteproc: mediatek: Check the SCP image format
2023-02-10 3:13 [PATCH v1] remoteproc: mediatek: Check the SCP image format Tinghan Shen
2023-02-10 11:32 ` Matthias Brugger
@ 2023-02-12 20:24 ` Mathieu Poirier
1 sibling, 0 replies; 4+ messages in thread
From: Mathieu Poirier @ 2023-02-12 20:24 UTC (permalink / raw)
To: Tinghan Shen
Cc: Bjorn Andersson, Matthias Brugger, AngeloGioacchino Del Regno,
linux-remoteproc, linux-kernel, linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group
On Fri, Feb 10, 2023 at 11:13:54AM +0800, Tinghan Shen wrote:
> Do a sanity check on the SCP image before loading it to avoid
> driver crashes.
>
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> ---
> drivers/remoteproc/mtk_scp.c | 1 +
> 1 file changed, 1 insertion(+)
>
I have applied this patch.
Thanks,
Mathieu
> diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
> index d421a2ccaa1e..0861b76f185f 100644
> --- a/drivers/remoteproc/mtk_scp.c
> +++ b/drivers/remoteproc/mtk_scp.c
> @@ -649,6 +649,7 @@ static const struct rproc_ops scp_ops = {
> .load = scp_load,
> .da_to_va = scp_da_to_va,
> .parse_fw = scp_parse_fw,
> + .sanity_check = rproc_elf_sanity_check,
> };
>
> /**
> --
> 2.18.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-12 20:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-10 3:13 [PATCH v1] remoteproc: mediatek: Check the SCP image format Tinghan Shen
2023-02-10 11:32 ` Matthias Brugger
2023-02-10 14:22 ` AngeloGioacchino Del Regno
2023-02-12 20:24 ` Mathieu Poirier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).