* [PATCH] cxl: avoid returning uninitialized error code
@ 2023-02-13 10:12 Arnd Bergmann
2023-02-14 16:35 ` Dan Williams
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2023-02-13 10:12 UTC (permalink / raw)
To: Alison Schofield, Vishal Verma, Ira Weiny, Ben Widawsky,
Dan Williams, Jonathan Cameron
Cc: Arnd Bergmann, Dave Jiang, Dan Carpenter, linux-cxl, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The new cxl_add_to_region() function returns an uninitialized
value on success:
drivers/cxl/core/region.c:2628:6: error: variable 'rc' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
if (IS_ERR(cxlr)) {
^~~~~~~~~~~~
drivers/cxl/core/region.c:2654:9: note: uninitialized use occurs here
return rc;
Simplify the logic to have the rc variable always initialized in the
same place.
Fixes: a32320b71f08 ("cxl/region: Add region autodiscovery")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/cxl/core/region.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
index fe1d8392870e..f29028148806 100644
--- a/drivers/cxl/core/region.c
+++ b/drivers/cxl/core/region.c
@@ -2625,10 +2625,9 @@ int cxl_add_to_region(struct cxl_port *root, struct cxl_endpoint_decoder *cxled)
cxlr = to_cxl_region(region_dev);
mutex_unlock(&cxlrd->range_lock);
- if (IS_ERR(cxlr)) {
- rc = PTR_ERR(cxlr);
+ rc = PTR_ERR_OR_ZERO(cxlr);
+ if (rc)
goto out;
- }
attach_target(cxlr, cxled, -1, TASK_UNINTERRUPTIBLE);
--
2.39.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] cxl: avoid returning uninitialized error code
2023-02-13 10:12 [PATCH] cxl: avoid returning uninitialized error code Arnd Bergmann
@ 2023-02-14 16:35 ` Dan Williams
0 siblings, 0 replies; 2+ messages in thread
From: Dan Williams @ 2023-02-14 16:35 UTC (permalink / raw)
To: Arnd Bergmann, Alison Schofield, Vishal Verma, Ira Weiny,
Ben Widawsky, Dan Williams, Jonathan Cameron
Cc: Arnd Bergmann, Dave Jiang, Dan Carpenter, linux-cxl, linux-kernel
Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The new cxl_add_to_region() function returns an uninitialized
> value on success:
>
> drivers/cxl/core/region.c:2628:6: error: variable 'rc' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
> if (IS_ERR(cxlr)) {
> ^~~~~~~~~~~~
> drivers/cxl/core/region.c:2654:9: note: uninitialized use occurs here
> return rc;
>
> Simplify the logic to have the rc variable always initialized in the
> same place.
>
> Fixes: a32320b71f08 ("cxl/region: Add region autodiscovery")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Looks good, thanks Arnd.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-14 16:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-13 10:12 [PATCH] cxl: avoid returning uninitialized error code Arnd Bergmann
2023-02-14 16:35 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).