* [PATCH v1 1/1] dmaengine: Actually use devm_add_action_or_reset()
@ 2023-02-13 11:21 Andy Shevchenko
2023-03-08 16:39 ` Andy Shevchenko
2023-03-17 17:43 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2023-02-13 11:21 UTC (permalink / raw)
To: Vinod Koul, dmaengine, linux-kernel; +Cc: Andy Shevchenko
It appears that the commit a1beaa50b583 ("dmaengine: Simplify
dmaenginem_async_device_register() function") mentions
devm_add_action_or_reset() the actual change utilised devm_add_action()
call by mistake.
Fix the issue by switching to devm_add_action_or_reset().
Fixes: a1beaa50b583 ("dmaengine: Simplify dmaenginem_async_device_register() function")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/dma/dmaengine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
index c24bca210104..826b98284fa1 100644
--- a/drivers/dma/dmaengine.c
+++ b/drivers/dma/dmaengine.c
@@ -1342,7 +1342,7 @@ int dmaenginem_async_device_register(struct dma_device *device)
if (ret)
return ret;
- return devm_add_action(device->dev, dmaenginem_async_device_unregister, device);
+ return devm_add_action_or_reset(device->dev, dmaenginem_async_device_unregister, device);
}
EXPORT_SYMBOL(dmaenginem_async_device_register);
--
2.39.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] dmaengine: Actually use devm_add_action_or_reset()
2023-02-13 11:21 [PATCH v1 1/1] dmaengine: Actually use devm_add_action_or_reset() Andy Shevchenko
@ 2023-03-08 16:39 ` Andy Shevchenko
2023-03-17 17:43 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2023-03-08 16:39 UTC (permalink / raw)
To: Vinod Koul, dmaengine, linux-kernel
On Mon, Feb 13, 2023 at 01:21:38PM +0200, Andy Shevchenko wrote:
> It appears that the commit a1beaa50b583 ("dmaengine: Simplify
> dmaenginem_async_device_register() function") mentions
> devm_add_action_or_reset() the actual change utilised devm_add_action()
> call by mistake.
>
> Fix the issue by switching to devm_add_action_or_reset().
Vinod, are you okay with this fix?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] dmaengine: Actually use devm_add_action_or_reset()
2023-02-13 11:21 [PATCH v1 1/1] dmaengine: Actually use devm_add_action_or_reset() Andy Shevchenko
2023-03-08 16:39 ` Andy Shevchenko
@ 2023-03-17 17:43 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2023-03-17 17:43 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: dmaengine, linux-kernel
On 13-02-23, 13:21, Andy Shevchenko wrote:
> It appears that the commit a1beaa50b583 ("dmaengine: Simplify
> dmaenginem_async_device_register() function") mentions
> devm_add_action_or_reset() the actual change utilised devm_add_action()
> call by mistake.
>
> Fix the issue by switching to devm_add_action_or_reset().
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-17 17:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-13 11:21 [PATCH v1 1/1] dmaengine: Actually use devm_add_action_or_reset() Andy Shevchenko
2023-03-08 16:39 ` Andy Shevchenko
2023-03-17 17:43 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).