* [PATCH v2 1/2] dt-bindings: net: snps,dwmac: Fix snps,reset-delays-us dependency
@ 2023-02-14 17:15 Andrew Halaney
2023-02-14 17:15 ` [PATCH v2 2/2] arm64: dts: imx8dxl-evk: Fix eqos phy reset gpio Andrew Halaney
2023-02-16 5:40 ` [PATCH v2 1/2] dt-bindings: net: snps,dwmac: Fix snps,reset-delays-us dependency patchwork-bot+netdevbpf
0 siblings, 2 replies; 5+ messages in thread
From: Andrew Halaney @ 2023-02-14 17:15 UTC (permalink / raw)
To: devicetree
Cc: davem, edumazet, kuba, pabeni, robh+dt, krzysztof.kozlowski+dt,
shawnguo, s.hauer, kernel, festevam, linux-imx, alexandre.torgue,
peppe.cavallaro, joabreu, mripard, shenwei.wang, netdev,
linux-kernel, linux-arm-kernel, Andrew Halaney,
Krzysztof Kozlowski
The schema had snps,reset-delay-us as dependent on snps,reset-gpio. The
actual property is called snps,reset-delays-us, so fix this to catch any
devicetree defining snsps,reset-delays-us without snps,reset-gpio.
Fixes: 7db3545aef5f ("dt-bindings: net: stmmac: Convert the binding to a schemas")
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
---
Changes since v1:
* collected Krzysztof's review
Documentation/devicetree/bindings/net/snps,dwmac.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
index e88a86623fce..16b7d2904696 100644
--- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
@@ -552,7 +552,7 @@ required:
dependencies:
snps,reset-active-low: ["snps,reset-gpio"]
- snps,reset-delay-us: ["snps,reset-gpio"]
+ snps,reset-delays-us: ["snps,reset-gpio"]
allOf:
- $ref: "ethernet-controller.yaml#"
--
2.39.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] arm64: dts: imx8dxl-evk: Fix eqos phy reset gpio
2023-02-14 17:15 [PATCH v2 1/2] dt-bindings: net: snps,dwmac: Fix snps,reset-delays-us dependency Andrew Halaney
@ 2023-02-14 17:15 ` Andrew Halaney
2023-02-16 8:26 ` Krzysztof Kozlowski
2023-03-14 0:58 ` Shawn Guo
2023-02-16 5:40 ` [PATCH v2 1/2] dt-bindings: net: snps,dwmac: Fix snps,reset-delays-us dependency patchwork-bot+netdevbpf
1 sibling, 2 replies; 5+ messages in thread
From: Andrew Halaney @ 2023-02-14 17:15 UTC (permalink / raw)
To: devicetree
Cc: davem, edumazet, kuba, pabeni, robh+dt, krzysztof.kozlowski+dt,
shawnguo, s.hauer, kernel, festevam, linux-imx, alexandre.torgue,
peppe.cavallaro, joabreu, mripard, shenwei.wang, netdev,
linux-kernel, linux-arm-kernel, Andrew Halaney
The deprecated property is named snps,reset-gpio, but this devicetree
used snps,reset-gpios instead which results in the reset not being used
and the following make dtbs_check error:
./arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: ethernet@5b050000: 'snps,reset-gpio' is a dependency of 'snps,reset-delays-us'
From schema: ./Documentation/devicetree/bindings/net/snps,dwmac.yaml
Use the preferred method of defining the reset gpio in the phy node
itself. Note that this drops the 10 us pre-delay, but prior this wasn't
used at all and a pre-delay doesn't make much sense in this context so
it should be fine.
Fixes: 8dd495d12374 ("arm64: dts: freescale: add support for i.MX8DXL EVK board")
Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
---
Changes since v1:
* Moved the reset into the ethernet-phy node itself instead of
fixing the deprecated usage (for that reason I did not collect
Fabio's review tag)
arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
index 1bcf228a22b8..852420349c01 100644
--- a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
@@ -121,8 +121,6 @@ &eqos {
phy-handle = <ðphy0>;
nvmem-cells = <&fec_mac1>;
nvmem-cell-names = "mac-address";
- snps,reset-gpios = <&pca6416_1 2 GPIO_ACTIVE_LOW>;
- snps,reset-delays-us = <10 20 200000>;
status = "okay";
mdio {
@@ -136,6 +134,9 @@ ethphy0: ethernet-phy@0 {
eee-broken-1000t;
qca,disable-smarteee;
qca,disable-hibernation-mode;
+ reset-gpios = <&pca6416_1 2 GPIO_ACTIVE_LOW>;
+ reset-assert-us = <20>;
+ reset-deassert-us = <200000>;
vddio-supply = <&vddio0>;
vddio0: vddio-regulator {
--
2.39.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: net: snps,dwmac: Fix snps,reset-delays-us dependency
2023-02-14 17:15 [PATCH v2 1/2] dt-bindings: net: snps,dwmac: Fix snps,reset-delays-us dependency Andrew Halaney
2023-02-14 17:15 ` [PATCH v2 2/2] arm64: dts: imx8dxl-evk: Fix eqos phy reset gpio Andrew Halaney
@ 2023-02-16 5:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-02-16 5:40 UTC (permalink / raw)
To: Andrew Halaney
Cc: devicetree, davem, edumazet, kuba, pabeni, robh+dt,
krzysztof.kozlowski+dt, shawnguo, s.hauer, kernel, festevam,
linux-imx, alexandre.torgue, peppe.cavallaro, joabreu, mripard,
shenwei.wang, netdev, linux-kernel, linux-arm-kernel,
krzysztof.kozlowski
Hello:
This series was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 14 Feb 2023 11:15:04 -0600 you wrote:
> The schema had snps,reset-delay-us as dependent on snps,reset-gpio. The
> actual property is called snps,reset-delays-us, so fix this to catch any
> devicetree defining snsps,reset-delays-us without snps,reset-gpio.
>
> Fixes: 7db3545aef5f ("dt-bindings: net: stmmac: Convert the binding to a schemas")
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
>
> [...]
Here is the summary with links:
- [v2,1/2] dt-bindings: net: snps,dwmac: Fix snps,reset-delays-us dependency
https://git.kernel.org/netdev/net-next/c/affb6a3fd8f4
- [v2,2/2] arm64: dts: imx8dxl-evk: Fix eqos phy reset gpio
(no matching commit)
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: imx8dxl-evk: Fix eqos phy reset gpio
2023-02-14 17:15 ` [PATCH v2 2/2] arm64: dts: imx8dxl-evk: Fix eqos phy reset gpio Andrew Halaney
@ 2023-02-16 8:26 ` Krzysztof Kozlowski
2023-03-14 0:58 ` Shawn Guo
1 sibling, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-16 8:26 UTC (permalink / raw)
To: Andrew Halaney, devicetree
Cc: davem, edumazet, kuba, pabeni, robh+dt, krzysztof.kozlowski+dt,
shawnguo, s.hauer, kernel, festevam, linux-imx, alexandre.torgue,
peppe.cavallaro, joabreu, mripard, shenwei.wang, netdev,
linux-kernel, linux-arm-kernel
On 14/02/2023 18:15, Andrew Halaney wrote:
> The deprecated property is named snps,reset-gpio, but this devicetree
> used snps,reset-gpios instead which results in the reset not being used
> and the following make dtbs_check error:
>
> ./arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: ethernet@5b050000: 'snps,reset-gpio' is a dependency of 'snps,reset-delays-us'
> From schema: ./Documentation/devicetree/bindings/net/snps,dwmac.yaml
>
> Use the preferred method of defining the reset gpio in the phy node
> itself. Note that this drops the 10 us pre-delay, but prior this wasn't
> used at all and a pre-delay doesn't make much sense in this context so
> it should be fine.
>
> Fixes: 8dd495d12374 ("arm64: dts: freescale: add support for i.MX8DXL EVK board")
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
> ---
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: imx8dxl-evk: Fix eqos phy reset gpio
2023-02-14 17:15 ` [PATCH v2 2/2] arm64: dts: imx8dxl-evk: Fix eqos phy reset gpio Andrew Halaney
2023-02-16 8:26 ` Krzysztof Kozlowski
@ 2023-03-14 0:58 ` Shawn Guo
1 sibling, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2023-03-14 0:58 UTC (permalink / raw)
To: Andrew Halaney
Cc: devicetree, davem, edumazet, kuba, pabeni, robh+dt,
krzysztof.kozlowski+dt, s.hauer, kernel, festevam, linux-imx,
alexandre.torgue, peppe.cavallaro, joabreu, mripard,
shenwei.wang, netdev, linux-kernel, linux-arm-kernel
On Tue, Feb 14, 2023 at 11:15:05AM -0600, Andrew Halaney wrote:
> The deprecated property is named snps,reset-gpio, but this devicetree
> used snps,reset-gpios instead which results in the reset not being used
> and the following make dtbs_check error:
>
> ./arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: ethernet@5b050000: 'snps,reset-gpio' is a dependency of 'snps,reset-delays-us'
> From schema: ./Documentation/devicetree/bindings/net/snps,dwmac.yaml
>
> Use the preferred method of defining the reset gpio in the phy node
> itself. Note that this drops the 10 us pre-delay, but prior this wasn't
> used at all and a pre-delay doesn't make much sense in this context so
> it should be fine.
>
> Fixes: 8dd495d12374 ("arm64: dts: freescale: add support for i.MX8DXL EVK board")
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-03-14 0:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-14 17:15 [PATCH v2 1/2] dt-bindings: net: snps,dwmac: Fix snps,reset-delays-us dependency Andrew Halaney
2023-02-14 17:15 ` [PATCH v2 2/2] arm64: dts: imx8dxl-evk: Fix eqos phy reset gpio Andrew Halaney
2023-02-16 8:26 ` Krzysztof Kozlowski
2023-03-14 0:58 ` Shawn Guo
2023-02-16 5:40 ` [PATCH v2 1/2] dt-bindings: net: snps,dwmac: Fix snps,reset-delays-us dependency patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).