[PATCH v3] octeontx2-pf: Use correct struct reference in test condition

[PATCH v3] octeontx2-pf: Use correct struct reference in test condition

[Deepak R Varma]

Fix the typo/copy-paste error by replacing struct variable ah_esp_mask name
by ah_esp_hdr.
Issue identified using doublebitand.cocci Coccinelle semantic patch.

Fixes: b7cf966126eb ("octeontx2-pf: Add flow classification using IP next level protocol")
Link: https://lore.kernel.org/all/20210111112537.3277-1-naveenm@marvell.com/
Signed-off-by: Deepak R Varma <drv@mailo.com>
---
Please note: Proposed change is compile/build tested only.

Changes in v3:
   1. Include Fixes tag as suggested by Jakub Kicinski <kuba@kernel.org>

Changes in v2:
   1. The variable is not repeating but is typed in wrong. Use the correct
      variable instead. Correction provided by
      Subbaraya Sundeep Bhatta <sbhatta@marvell.com>

 drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c
index 684cb8ec9f21..10e11262d48a 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c
@@ -793,7 +793,7 @@ static int otx2_prepare_ipv6_flow(struct ethtool_rx_flow_spec *fsp,
 
 		/* NPC profile doesn't extract AH/ESP header fields */
 		if ((ah_esp_mask->spi & ah_esp_hdr->spi) ||
-		    (ah_esp_mask->tclass & ah_esp_mask->tclass))
+		    (ah_esp_mask->tclass & ah_esp_hdr->tclass))
 			return -EOPNOTSUPP;
 
 		if (flow_type == AH_V6_FLOW)
-- 
2.34.1

Re: [PATCH v3] octeontx2-pf: Use correct struct reference in test condition

[Jakub Kicinski]

On Wed, 22 Feb 2023 18:58:48 +0530 Deepak R Varma wrote:
> Fix the typo/copy-paste error by replacing struct variable ah_esp_mask name
> by ah_esp_hdr.
> Issue identified using doublebitand.cocci Coccinelle semantic patch.
> 
> Fixes: b7cf966126eb ("octeontx2-pf: Add flow classification using IP next level protocol")
> Link: https://lore.kernel.org/all/20210111112537.3277-1-naveenm@marvell.com/
> Signed-off-by: Deepak R Varma <drv@mailo.com>

Applied, thanks!