* [PATCH] mailbox: qcom-ipcc: Support multiple channels for a given client
@ 2023-02-23 6:13 Huang Yiwei
2023-02-24 3:27 ` Guru Das Srinagesh
0 siblings, 1 reply; 2+ messages in thread
From: Huang Yiwei @ 2023-02-23 6:13 UTC (permalink / raw)
To: mani, agross, andersson, konrad.dybcio, jassisinghbrar
Cc: Huang Yiwei, linux-arm-msm, linux-kernel, quic_satyap,
quic_aiquny, quic_gurus
Recently a new use case where two signals for the same protocol and
client is needed, that means there will be more than one channel
for a mbox node. Current driver only supports one channel, so need
to remove the limitation and let the driver find every channel
correctly.
Signed-off-by: Huang Yiwei <quic_hyiwei@quicinc.com>
---
drivers/mailbox/qcom-ipcc.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/mailbox/qcom-ipcc.c b/drivers/mailbox/qcom-ipcc.c
index 7e27acf6c0cc..367658af089e 100644
--- a/drivers/mailbox/qcom-ipcc.c
+++ b/drivers/mailbox/qcom-ipcc.c
@@ -226,11 +226,9 @@ static int qcom_ipcc_setup_mbox(struct qcom_ipcc *ipcc,
for (j = 0; j < i; j++) {
ret = of_parse_phandle_with_args(client_dn, "mboxes",
"#mbox-cells", j, &curr_ph);
- of_node_put(curr_ph.np);
- if (!ret && curr_ph.np == controller_dn) {
+ if (!ret && curr_ph.np == controller_dn)
ipcc->num_chans++;
- break;
- }
+ of_node_put(curr_ph.np);
}
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mailbox: qcom-ipcc: Support multiple channels for a given client
2023-02-23 6:13 [PATCH] mailbox: qcom-ipcc: Support multiple channels for a given client Huang Yiwei
@ 2023-02-24 3:27 ` Guru Das Srinagesh
0 siblings, 0 replies; 2+ messages in thread
From: Guru Das Srinagesh @ 2023-02-24 3:27 UTC (permalink / raw)
To: Huang Yiwei
Cc: mani, agross, andersson, konrad.dybcio, jassisinghbrar,
linux-arm-msm, linux-kernel, quic_satyap, quic_aiquny
On Feb 23 2023 14:13, Huang Yiwei wrote:
> Recently a new use case where two signals for the same protocol and
> client is needed, that means there will be more than one channel
> for a mbox node. Current driver only supports one channel, so need
> to remove the limitation and let the driver find every channel
> correctly.
>
> Signed-off-by: Huang Yiwei <quic_hyiwei@quicinc.com>
> ---
> drivers/mailbox/qcom-ipcc.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mailbox/qcom-ipcc.c b/drivers/mailbox/qcom-ipcc.c
> index 7e27acf6c0cc..367658af089e 100644
> --- a/drivers/mailbox/qcom-ipcc.c
> +++ b/drivers/mailbox/qcom-ipcc.c
> @@ -226,11 +226,9 @@ static int qcom_ipcc_setup_mbox(struct qcom_ipcc *ipcc,
> for (j = 0; j < i; j++) {
> ret = of_parse_phandle_with_args(client_dn, "mboxes",
> "#mbox-cells", j, &curr_ph);
> - of_node_put(curr_ph.np);
> - if (!ret && curr_ph.np == controller_dn) {
> + if (!ret && curr_ph.np == controller_dn)
> ipcc->num_chans++;
> - break;
> - }
> + of_node_put(curr_ph.np);
of_node_put can stay where it is - the main change is the removal of the break,
is it not?
Guru Das.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-24 3:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-23 6:13 [PATCH] mailbox: qcom-ipcc: Support multiple channels for a given client Huang Yiwei
2023-02-24 3:27 ` Guru Das Srinagesh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).