* [PATCH v2 2/2] net: phy: at803x: remove set/get wol callbacks for AR8032
@ 2023-02-24 22:51 Li Yang
2023-02-25 3:39 ` Jakub Kicinski
0 siblings, 1 reply; 4+ messages in thread
From: Li Yang @ 2023-02-24 22:51 UTC (permalink / raw)
To: Andrew Lunn, Heiner Kallweit, Russell King, David S . Miller,
Jakub Kicinski, David Bauer
Cc: netdev, linux-kernel, Li Yang
Since the AR8032 part does not support wol, remove related callbacks
from it.
Fixes: 5800091a2061 ("net: phy: at803x: add support for AR8032 PHY")
Signed-off-by: Li Yang <leoyang.li@nxp.com>
---
drivers/net/phy/at803x.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index 2102279b3964..ac47a1d681b2 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -2079,8 +2079,6 @@ static struct phy_driver at803x_driver[] = {
.flags = PHY_POLL_CABLE_TEST,
.config_init = at803x_config_init,
.link_change_notify = at803x_link_change_notify,
- .set_wol = at803x_set_wol,
- .get_wol = at803x_get_wol,
.suspend = at803x_suspend,
.resume = at803x_resume,
/* PHY_BASIC_FEATURES */
--
2.38.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 2/2] net: phy: at803x: remove set/get wol callbacks for AR8032
2023-02-24 22:51 [PATCH v2 2/2] net: phy: at803x: remove set/get wol callbacks for AR8032 Li Yang
@ 2023-02-25 3:39 ` Jakub Kicinski
0 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2023-02-25 3:39 UTC (permalink / raw)
To: Li Yang
Cc: Andrew Lunn, Heiner Kallweit, Russell King, David S . Miller,
David Bauer, netdev, linux-kernel
On Fri, 24 Feb 2023 16:51:58 -0600 Li Yang wrote:
> Since the AR8032 part does not support wol, remove related callbacks
> from it.
>
> Fixes: 5800091a2061 ("net: phy: at803x: add support for AR8032 PHY")
> Signed-off-by: Li Yang <leoyang.li@nxp.com>
You need to repost the entire series, please, both patches.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 2/2] net: phy: at803x: remove set/get wol callbacks for AR8032
2023-02-21 23:14 ` [PATCH v2 2/2] net: phy: at803x: remove set/get wol callbacks for AR8032 Li Yang
@ 2023-02-24 3:05 ` Jakub Kicinski
0 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2023-02-24 3:05 UTC (permalink / raw)
To: Li Yang
Cc: Andrew Lunn, Heiner Kallweit, Russell King, David S . Miller,
Luo Jie, netdev, linux-kernel
On Tue, 21 Feb 2023 17:14:11 -0600 Li Yang wrote:
> Since the AR8032 part does not support wol, remove related callbacks
> from it.
>
> Fixes: 5800091a2061 ("net: phy: at803x: add support for AR8032 PHY")
Is there a reason you didn't CC David Bauer <mail@david-bauer.net>,
the author of the change under Fixes? If no please repost and add him.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 2/2] net: phy: at803x: remove set/get wol callbacks for AR8032
2023-02-21 23:14 [PATCH v2 1/2] net: phy: at803x: fix the wol setting functions Li Yang
@ 2023-02-21 23:14 ` Li Yang
2023-02-24 3:05 ` Jakub Kicinski
0 siblings, 1 reply; 4+ messages in thread
From: Li Yang @ 2023-02-21 23:14 UTC (permalink / raw)
To: Andrew Lunn, Heiner Kallweit, Russell King, David S . Miller,
Jakub Kicinski, Luo Jie
Cc: netdev, linux-kernel, Li Yang
Since the AR8032 part does not support wol, remove related callbacks
from it.
Fixes: 5800091a2061 ("net: phy: at803x: add support for AR8032 PHY")
Signed-off-by: Li Yang <leoyang.li@nxp.com>
---
drivers/net/phy/at803x.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index 2102279b3964..ac47a1d681b2 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -2079,8 +2079,6 @@ static struct phy_driver at803x_driver[] = {
.flags = PHY_POLL_CABLE_TEST,
.config_init = at803x_config_init,
.link_change_notify = at803x_link_change_notify,
- .set_wol = at803x_set_wol,
- .get_wol = at803x_get_wol,
.suspend = at803x_suspend,
.resume = at803x_resume,
/* PHY_BASIC_FEATURES */
--
2.38.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-25 3:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-24 22:51 [PATCH v2 2/2] net: phy: at803x: remove set/get wol callbacks for AR8032 Li Yang
2023-02-25 3:39 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2023-02-21 23:14 [PATCH v2 1/2] net: phy: at803x: fix the wol setting functions Li Yang
2023-02-21 23:14 ` [PATCH v2 2/2] net: phy: at803x: remove set/get wol callbacks for AR8032 Li Yang
2023-02-24 3:05 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).