From: Johan Hovold <johan+linaro@kernel.org>
To: Georgi Djakov <djakov@kernel.org>
Cc: "Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
"Artur Świgoń" <a.swigon@samsung.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
"Johan Hovold" <johan+linaro@kernel.org>,
"Dan Carpenter" <error27@gmail.com>,
"kernel test robot" <lkp@intel.com>
Subject: [PATCH v2 00/23] interconnect: fix racy provider registration
Date: Mon, 6 Mar 2023 08:56:28 +0100 [thread overview]
Message-ID: <20230306075651.2449-1-johan+linaro@kernel.org> (raw)
The current interconnect provider interface is inherently racy as
providers are expected to be registered before being fully initialised.
This can specifically cause racing DT lookups to fail as I recently
noticed when the Qualcomm cpufreq driver failed to probe:
of_icc_xlate_onecell: invalid index 0
cpu cpu0: error -EINVAL: error finding src node
cpu cpu0: dev_pm_opp_of_find_icc_paths: Unable to get path0: -22
qcom-cpufreq-hw: probe of 18591000.cpufreq failed with error -22
This only happens very rarely, but the bug is easily reproduced by
increasing the race window by adding an msleep() after registering
osm-l3 interconnect provider.
Note that the Qualcomm cpufreq driver is especially susceptible to this
race as the interconnect path is looked up from the CPU nodes so that
driver core does not guarantee the probe order even when device links
are enabled (which they not always are).
This series adds a new interconnect provider registration API which is
used to fix up the interconnect drivers before removing the old racy
API.
Included are also a number of fixes for other bugs found while preparing
the series.
Johan
Changes in v2
- icc_node_destroy() can be called with an arbitrary node id so add the
missing sanity check to handle potential attempts to destroy a
non-existing node (patch 01/23). Reported by Dan Carpenter and the
kernel test robot:
https://lore.kernel.org/oe-kbuild/202302222118.nGz1F0oJ-lkp@intel.com/
Johan Hovold (23):
interconnect: fix mem leak when freeing nodes
interconnect: fix icc_provider_del() error handling
interconnect: fix provider registration API
interconnect: imx: fix registration race
interconnect: qcom: osm-l3: fix registration race
interconnect: qcom: rpm: fix probe child-node error handling
interconnect: qcom: rpm: fix probe PM domain error handling
interconnect: qcom: rpm: fix registration race
interconnect: qcom: rpmh: fix probe child-node error handling
interconnect: qcom: rpmh: fix registration race
interconnect: qcom: msm8974: fix registration race
interconnect: qcom: sm8450: fix registration race
interconnect: qcom: sm8550: fix registration race
interconnect: exynos: fix node leak in probe PM QoS error path
interconnect: exynos: fix registration race
interconnect: exynos: drop redundant link destroy
memory: tegra: fix interconnect registration race
memory: tegra124-emc: fix interconnect registration race
memory: tegra20-emc: fix interconnect registration race
memory: tegra30-emc: fix interconnect registration race
interconnect: drop racy registration API
interconnect: drop unused icc_get() interface
interconnect: drop unused icc_link_destroy() interface
drivers/interconnect/core.c | 152 +++++---------------------
drivers/interconnect/imx/imx.c | 20 ++--
drivers/interconnect/qcom/icc-rpm.c | 33 +++---
drivers/interconnect/qcom/icc-rpmh.c | 30 +++--
drivers/interconnect/qcom/msm8974.c | 20 ++--
drivers/interconnect/qcom/osm-l3.c | 14 +--
drivers/interconnect/qcom/sm8450.c | 22 ++--
drivers/interconnect/qcom/sm8550.c | 22 ++--
drivers/interconnect/samsung/exynos.c | 30 ++---
drivers/memory/tegra/mc.c | 16 ++-
drivers/memory/tegra/tegra124-emc.c | 12 +-
drivers/memory/tegra/tegra20-emc.c | 12 +-
drivers/memory/tegra/tegra30-emc.c | 12 +-
include/linux/interconnect-provider.h | 19 ++--
include/linux/interconnect.h | 8 --
15 files changed, 157 insertions(+), 265 deletions(-)
--
2.39.2
next reply other threads:[~2023-03-06 7:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 7:56 Johan Hovold [this message]
2023-03-06 7:56 ` [PATCH v2 01/23] interconnect: fix mem leak when freeing nodes Johan Hovold
2023-03-07 9:42 ` Luca Ceresoli
2023-03-06 7:56 ` [PATCH v2 02/23] interconnect: fix icc_provider_del() error handling Johan Hovold
2023-03-07 9:43 ` Luca Ceresoli
2023-03-06 7:56 ` [PATCH v2 03/23] interconnect: fix provider registration API Johan Hovold
2023-03-07 9:43 ` Luca Ceresoli
2023-03-06 7:56 ` [PATCH v2 04/23] interconnect: imx: fix registration race Johan Hovold
2023-03-07 9:43 ` Luca Ceresoli
2023-03-07 10:25 ` Johan Hovold
2023-03-06 7:56 ` [PATCH v2 05/23] interconnect: qcom: osm-l3: " Johan Hovold
2023-03-06 7:56 ` [PATCH v2 06/23] interconnect: qcom: rpm: fix probe child-node error handling Johan Hovold
2023-03-06 7:56 ` [PATCH v2 07/23] interconnect: qcom: rpm: fix probe PM domain " Johan Hovold
2023-03-06 7:56 ` [PATCH v2 08/23] interconnect: qcom: rpm: fix registration race Johan Hovold
2023-03-06 7:56 ` [PATCH v2 09/23] interconnect: qcom: rpmh: fix probe child-node error handling Johan Hovold
2023-03-06 7:56 ` [PATCH v2 10/23] interconnect: qcom: rpmh: fix registration race Johan Hovold
2023-03-06 7:56 ` [PATCH v2 11/23] interconnect: qcom: msm8974: " Johan Hovold
2023-03-06 7:56 ` [PATCH v2 12/23] interconnect: qcom: sm8450: " Johan Hovold
2023-03-06 7:56 ` [PATCH v2 13/23] interconnect: qcom: sm8550: " Johan Hovold
2023-03-06 9:03 ` Abel Vesa
2023-03-06 9:34 ` Johan Hovold
2023-03-06 9:39 ` Abel Vesa
2023-03-06 10:04 ` Johan Hovold
2023-03-06 7:56 ` [PATCH v2 14/23] interconnect: exynos: fix node leak in probe PM QoS error path Johan Hovold
2023-03-06 7:56 ` [PATCH v2 15/23] interconnect: exynos: fix registration race Johan Hovold
2023-03-06 7:56 ` [PATCH v2 16/23] interconnect: exynos: drop redundant link destroy Johan Hovold
2023-03-06 7:56 ` [PATCH v2 17/23] memory: tegra: fix interconnect registration race Johan Hovold
2023-03-06 7:56 ` [PATCH v2 18/23] memory: tegra124-emc: " Johan Hovold
2023-03-06 7:56 ` [PATCH v2 19/23] memory: tegra20-emc: " Johan Hovold
2023-03-06 7:56 ` [PATCH v2 20/23] memory: tegra30-emc: " Johan Hovold
2023-03-06 7:56 ` [PATCH v2 21/23] interconnect: drop racy registration API Johan Hovold
2023-03-06 7:56 ` [PATCH v2 22/23] interconnect: drop unused icc_get() interface Johan Hovold
2023-03-06 7:56 ` [PATCH v2 23/23] interconnect: drop unused icc_link_destroy() interface Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230306075651.2449-1-johan+linaro@kernel.org \
--to=johan+linaro@kernel.org \
--cc=a.swigon@samsung.com \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=djakov@kernel.org \
--cc=error27@gmail.com \
--cc=festevam@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lkp@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=s.nawrocki@samsung.com \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).