From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: [steev:lenovo-x13s-v6.2 114/188] drivers/interconnect/core.c:853 icc_node_destroy() error: we previously assumed 'node' could be null (see line 846)
Date: Wed, 22 Feb 2023 22:04:16 +0800 [thread overview]
Message-ID: <202302222118.nGz1F0oJ-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: Johan Hovold <johan+linaro@kernel.org>
CC: Steev Klimaszewski <steev@kali.org>
tree: https://github.com/steev/linux lenovo-x13s-v6.2
head: b9925baa3e5cf7919e9736257505a214b66dcdd2
commit: f89ce4d6ffc2c5e73c476d0d264951feef193f17 [114/188] interconnect: fix mem leak when freeing nodes
:::::: branch date: 10 hours ago
:::::: commit date: 10 hours ago
config: microblaze-randconfig-m031-20230222 (https://download.01.org/0day-ci/archive/20230222/202302222118.nGz1F0oJ-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Link: https://lore.kernel.org/r/202302222118.nGz1F0oJ-lkp@intel.com/
smatch warnings:
drivers/interconnect/core.c:853 icc_node_destroy() error: we previously assumed 'node' could be null (see line 846)
vim +/node +853 drivers/interconnect/core.c
11f1ceca7031de Georgi Djakov 2019-01-16 834
11f1ceca7031de Georgi Djakov 2019-01-16 835 /**
11f1ceca7031de Georgi Djakov 2019-01-16 836 * icc_node_destroy() - destroy a node
11f1ceca7031de Georgi Djakov 2019-01-16 837 * @id: node id
11f1ceca7031de Georgi Djakov 2019-01-16 838 */
11f1ceca7031de Georgi Djakov 2019-01-16 839 void icc_node_destroy(int id)
11f1ceca7031de Georgi Djakov 2019-01-16 840 {
11f1ceca7031de Georgi Djakov 2019-01-16 841 struct icc_node *node;
11f1ceca7031de Georgi Djakov 2019-01-16 842
11f1ceca7031de Georgi Djakov 2019-01-16 843 mutex_lock(&icc_lock);
11f1ceca7031de Georgi Djakov 2019-01-16 844
11f1ceca7031de Georgi Djakov 2019-01-16 845 node = node_find(id);
11f1ceca7031de Georgi Djakov 2019-01-16 @846 if (node) {
11f1ceca7031de Georgi Djakov 2019-01-16 847 idr_remove(&icc_idr, node->id);
11f1ceca7031de Georgi Djakov 2019-01-16 848 WARN_ON(!hlist_empty(&node->req_list));
11f1ceca7031de Georgi Djakov 2019-01-16 849 }
11f1ceca7031de Georgi Djakov 2019-01-16 850
11f1ceca7031de Georgi Djakov 2019-01-16 851 mutex_unlock(&icc_lock);
11f1ceca7031de Georgi Djakov 2019-01-16 852
f89ce4d6ffc2c5 Johan Hovold 2023-01-31 @853 kfree(node->links);
11f1ceca7031de Georgi Djakov 2019-01-16 854 kfree(node);
11f1ceca7031de Georgi Djakov 2019-01-16 855 }
11f1ceca7031de Georgi Djakov 2019-01-16 856 EXPORT_SYMBOL_GPL(icc_node_destroy);
11f1ceca7031de Georgi Djakov 2019-01-16 857
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: oe-kbuild@lists.linux.dev, Johan Hovold <johan+linaro@kernel.org>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
Steev Klimaszewski <steev@kali.org>
Subject: [steev:lenovo-x13s-v6.2 114/188] drivers/interconnect/core.c:853 icc_node_destroy() error: we previously assumed 'node' could be null (see line 846)
Date: Wed, 22 Feb 2023 17:25:01 +0300 [thread overview]
Message-ID: <202302222118.nGz1F0oJ-lkp@intel.com> (raw)
Message-ID: <20230222142501.e2Ww9rIEWNpya_SgX_trPNyvabnXSc0GO0nguCT9crU@z> (raw)
tree: https://github.com/steev/linux lenovo-x13s-v6.2
head: b9925baa3e5cf7919e9736257505a214b66dcdd2
commit: f89ce4d6ffc2c5e73c476d0d264951feef193f17 [114/188] interconnect: fix mem leak when freeing nodes
config: microblaze-randconfig-m031-20230222 (https://download.01.org/0day-ci/archive/20230222/202302222118.nGz1F0oJ-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Link: https://lore.kernel.org/r/202302222118.nGz1F0oJ-lkp@intel.com/
smatch warnings:
drivers/interconnect/core.c:853 icc_node_destroy() error: we previously assumed 'node' could be null (see line 846)
vim +/node +853 drivers/interconnect/core.c
11f1ceca7031de Georgi Djakov 2019-01-16 839 void icc_node_destroy(int id)
11f1ceca7031de Georgi Djakov 2019-01-16 840 {
11f1ceca7031de Georgi Djakov 2019-01-16 841 struct icc_node *node;
11f1ceca7031de Georgi Djakov 2019-01-16 842
11f1ceca7031de Georgi Djakov 2019-01-16 843 mutex_lock(&icc_lock);
11f1ceca7031de Georgi Djakov 2019-01-16 844
11f1ceca7031de Georgi Djakov 2019-01-16 845 node = node_find(id);
11f1ceca7031de Georgi Djakov 2019-01-16 @846 if (node) {
If node is NULL
11f1ceca7031de Georgi Djakov 2019-01-16 847 idr_remove(&icc_idr, node->id);
11f1ceca7031de Georgi Djakov 2019-01-16 848 WARN_ON(!hlist_empty(&node->req_list));
11f1ceca7031de Georgi Djakov 2019-01-16 849 }
11f1ceca7031de Georgi Djakov 2019-01-16 850
11f1ceca7031de Georgi Djakov 2019-01-16 851 mutex_unlock(&icc_lock);
11f1ceca7031de Georgi Djakov 2019-01-16 852
f89ce4d6ffc2c5 Johan Hovold 2023-01-31 @853 kfree(node->links);
then this will crash
11f1ceca7031de Georgi Djakov 2019-01-16 854 kfree(node);
11f1ceca7031de Georgi Djakov 2019-01-16 855 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next reply other threads:[~2023-02-22 14:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 14:04 kernel test robot [this message]
2023-02-22 14:25 ` [steev:lenovo-x13s-v6.2 114/188] drivers/interconnect/core.c:853 icc_node_destroy() error: we previously assumed 'node' could be null (see line 846) Dan Carpenter
2023-02-22 15:44 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202302222118.nGz1F0oJ-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).