* [PATCH] arm64: dts: qcom: sa8540p-ride: correct name of remoteproc_nsp0 firmware
@ 2023-03-07 23:23 Brian Masney
2023-03-08 11:02 ` Krzysztof Kozlowski
2023-03-15 23:34 ` Bjorn Andersson
0 siblings, 2 replies; 6+ messages in thread
From: Brian Masney @ 2023-03-07 23:23 UTC (permalink / raw)
To: andersson
Cc: quic_shazhuss, agross, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt, linux-arm-msm, devicetree, linux-kernel
The cdsp.mbn firmware that's referenced in sa8540p-ride.dts is actually
named cdsp0.mbn in the deliverables from Qualcomm. Let's go ahead and
correct the name to match what's in Qualcomm's deliverable.
Signed-off-by: Brian Masney <bmasney@redhat.com>
---
arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
index 6c547f1b13dc..0f560a4661eb 100644
--- a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
+++ b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
@@ -177,7 +177,7 @@ &qup2_uart17 {
};
&remoteproc_nsp0 {
- firmware-name = "qcom/sa8540p/cdsp.mbn";
+ firmware-name = "qcom/sa8540p/cdsp0.mbn";
status = "okay";
};
--
2.39.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sa8540p-ride: correct name of remoteproc_nsp0 firmware
2023-03-07 23:23 [PATCH] arm64: dts: qcom: sa8540p-ride: correct name of remoteproc_nsp0 firmware Brian Masney
@ 2023-03-08 11:02 ` Krzysztof Kozlowski
2023-03-08 12:06 ` Brian Masney
2023-03-15 23:34 ` Bjorn Andersson
1 sibling, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-08 11:02 UTC (permalink / raw)
To: Brian Masney, andersson
Cc: quic_shazhuss, agross, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt, linux-arm-msm, devicetree, linux-kernel
On 08/03/2023 00:23, Brian Masney wrote:
> The cdsp.mbn firmware that's referenced in sa8540p-ride.dts is actually
> named cdsp0.mbn in the deliverables from Qualcomm. Let's go ahead and
> correct the name to match what's in Qualcomm's deliverable.
I don't think vendor deliverables matter. linux-firmware is here more
important. The file will be cdsp.mbn in the firmware, won't it?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sa8540p-ride: correct name of remoteproc_nsp0 firmware
2023-03-08 11:02 ` Krzysztof Kozlowski
@ 2023-03-08 12:06 ` Brian Masney
2023-03-08 12:36 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Brian Masney @ 2023-03-08 12:06 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: andersson, quic_shazhuss, agross, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt, linux-arm-msm, devicetree, linux-kernel
On Wed, Mar 08, 2023 at 12:02:04PM +0100, Krzysztof Kozlowski wrote:
> On 08/03/2023 00:23, Brian Masney wrote:
> > The cdsp.mbn firmware that's referenced in sa8540p-ride.dts is actually
> > named cdsp0.mbn in the deliverables from Qualcomm. Let's go ahead and
> > correct the name to match what's in Qualcomm's deliverable.
>
> I don't think vendor deliverables matter. linux-firmware is here more
> important. The file will be cdsp.mbn in the firmware, won't it?
cdsp0.mbn and cdsp1.mbn for the sa8540p are not in linux-firmware and I
far as I know there's no plan for someone to submit those since QC would
need to approve that. I can ask though since the DTS for these two bits
has been submitted upstream.
Brian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sa8540p-ride: correct name of remoteproc_nsp0 firmware
2023-03-08 12:06 ` Brian Masney
@ 2023-03-08 12:36 ` Krzysztof Kozlowski
2023-03-09 21:55 ` Bjorn Andersson
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-08 12:36 UTC (permalink / raw)
To: Brian Masney
Cc: andersson, quic_shazhuss, agross, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt, linux-arm-msm, devicetree, linux-kernel
On 08/03/2023 13:06, Brian Masney wrote:
> On Wed, Mar 08, 2023 at 12:02:04PM +0100, Krzysztof Kozlowski wrote:
>> On 08/03/2023 00:23, Brian Masney wrote:
>>> The cdsp.mbn firmware that's referenced in sa8540p-ride.dts is actually
>>> named cdsp0.mbn in the deliverables from Qualcomm. Let's go ahead and
>>> correct the name to match what's in Qualcomm's deliverable.
>>
>> I don't think vendor deliverables matter. linux-firmware is here more
>> important. The file will be cdsp.mbn in the firmware, won't it?
>
> cdsp0.mbn and cdsp1.mbn for the sa8540p are not in linux-firmware and I
> far as I know there's no plan for someone to submit those since QC would
> need to approve that. I can ask though since the DTS for these two bits
> has been submitted upstream.
If they are never going to be submitted, vendor is allowed to rename
them all the time in their "deliverables". Are you going to rename the
file every time Qualcomm decides to rename them? There is no single
guarantee the names would be fixed, because vendor is allowed to do
absolutely anything.
Sorry, but any argument in upstream DTS that "someone downstream does
something" is deemed to fail in many cases.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sa8540p-ride: correct name of remoteproc_nsp0 firmware
2023-03-08 12:36 ` Krzysztof Kozlowski
@ 2023-03-09 21:55 ` Bjorn Andersson
0 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2023-03-09 21:55 UTC (permalink / raw)
To: Krzysztof Kozlowski, Brian Masney
Cc: quic_shazhuss, agross, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt, linux-arm-msm, devicetree, linux-kernel
On Wed, Mar 08, 2023 at 01:36:52PM +0100, Krzysztof Kozlowski wrote:
> On 08/03/2023 13:06, Brian Masney wrote:
> > On Wed, Mar 08, 2023 at 12:02:04PM +0100, Krzysztof Kozlowski wrote:
> >> On 08/03/2023 00:23, Brian Masney wrote:
> >>> The cdsp.mbn firmware that's referenced in sa8540p-ride.dts is actually
> >>> named cdsp0.mbn in the deliverables from Qualcomm. Let's go ahead and
> >>> correct the name to match what's in Qualcomm's deliverable.
> >>
> >> I don't think vendor deliverables matter. linux-firmware is here more
> >> important. The file will be cdsp.mbn in the firmware, won't it?
> >
> > cdsp0.mbn and cdsp1.mbn for the sa8540p are not in linux-firmware and I
> > far as I know there's no plan for someone to submit those since QC would
> > need to approve that. I can ask though since the DTS for these two bits
> > has been submitted upstream.
>
> If they are never going to be submitted, vendor is allowed to rename
> them all the time in their "deliverables". Are you going to rename the
> file every time Qualcomm decides to rename them? There is no single
> guarantee the names would be fixed, because vendor is allowed to do
> absolutely anything.
>
cdsp0.mbn and cdsp1.mbn are better names, so let's use this patch to
define that if/when they are pushed to linux-firmware it should follow
this scheme.
> Sorry, but any argument in upstream DTS that "someone downstream does
> something" is deemed to fail in many cases.
>
That is indeed an insufficient argument, in many cases.
Regards,
Bjorn
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sa8540p-ride: correct name of remoteproc_nsp0 firmware
2023-03-07 23:23 [PATCH] arm64: dts: qcom: sa8540p-ride: correct name of remoteproc_nsp0 firmware Brian Masney
2023-03-08 11:02 ` Krzysztof Kozlowski
@ 2023-03-15 23:34 ` Bjorn Andersson
1 sibling, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2023-03-15 23:34 UTC (permalink / raw)
To: Brian Masney
Cc: linux-arm-msm, konrad.dybcio, agross, robh+dt, devicetree,
quic_shazhuss, krzysztof.kozlowski+dt, linux-kernel
On Tue, 7 Mar 2023 18:23:40 -0500, Brian Masney wrote:
> The cdsp.mbn firmware that's referenced in sa8540p-ride.dts is actually
> named cdsp0.mbn in the deliverables from Qualcomm. Let's go ahead and
> correct the name to match what's in Qualcomm's deliverable.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: sa8540p-ride: correct name of remoteproc_nsp0 firmware
commit: b891251b40d4dc4cfd28341f62f6784c02ad3a78
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-03-15 23:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-07 23:23 [PATCH] arm64: dts: qcom: sa8540p-ride: correct name of remoteproc_nsp0 firmware Brian Masney
2023-03-08 11:02 ` Krzysztof Kozlowski
2023-03-08 12:06 ` Brian Masney
2023-03-08 12:36 ` Krzysztof Kozlowski
2023-03-09 21:55 ` Bjorn Andersson
2023-03-15 23:34 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).