* [PATCH 01/18] mfd: da903x: remove MODULE_LICENSE in non-modules
@ 2023-03-08 19:42 Nick Alcock
2023-03-08 19:42 ` [PATCH 02/18] mfd: da9052: " Nick Alcock
` (17 more replies)
0 siblings, 18 replies; 20+ messages in thread
From: Nick Alcock @ 2023-03-08 19:42 UTC (permalink / raw)
To: lee; +Cc: Luis Chamberlain, linux-modules, linux-kernel, Support Opensource
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Support Opensource <support.opensource@diasemi.com>
Cc: Lee Jones <lee@kernel.org>
---
drivers/mfd/da903x.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mfd/da903x.c b/drivers/mfd/da903x.c
index 44a25d642ce94..6570b33a5a77b 100644
--- a/drivers/mfd/da903x.c
+++ b/drivers/mfd/da903x.c
@@ -563,4 +563,3 @@ module_exit(da903x_exit);
MODULE_DESCRIPTION("PMIC Driver for Dialog Semiconductor DA9034");
MODULE_AUTHOR("Eric Miao <eric.miao@marvell.com>");
MODULE_AUTHOR("Mike Rapoport <mike@compulab.co.il>");
-MODULE_LICENSE("GPL v2");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 02/18] mfd: da9052: remove MODULE_LICENSE in non-modules
2023-03-08 19:42 [PATCH 01/18] mfd: da903x: remove MODULE_LICENSE in non-modules Nick Alcock
@ 2023-03-08 19:42 ` Nick Alcock
2023-03-08 19:42 ` [PATCH 03/18] mfd: da9052-i2c: " Nick Alcock
` (16 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: Nick Alcock @ 2023-03-08 19:42 UTC (permalink / raw)
To: lee; +Cc: Luis Chamberlain, linux-modules, linux-kernel, Support Opensource
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Support Opensource <support.opensource@diasemi.com>
Cc: Lee Jones <lee@kernel.org>
---
drivers/mfd/da9052-core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mfd/da9052-core.c b/drivers/mfd/da9052-core.c
index 8b42d2f7024f5..150448cd2eb08 100644
--- a/drivers/mfd/da9052-core.c
+++ b/drivers/mfd/da9052-core.c
@@ -653,4 +653,3 @@ void da9052_device_exit(struct da9052 *da9052)
MODULE_AUTHOR("David Dajun Chen <dchen@diasemi.com>");
MODULE_DESCRIPTION("DA9052 MFD Core");
-MODULE_LICENSE("GPL");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 03/18] mfd: da9052-i2c: remove MODULE_LICENSE in non-modules
2023-03-08 19:42 [PATCH 01/18] mfd: da903x: remove MODULE_LICENSE in non-modules Nick Alcock
2023-03-08 19:42 ` [PATCH 02/18] mfd: da9052: " Nick Alcock
@ 2023-03-08 19:42 ` Nick Alcock
2023-03-08 19:42 ` [PATCH 04/18] mfd: da9052-spi: " Nick Alcock
` (15 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: Nick Alcock @ 2023-03-08 19:42 UTC (permalink / raw)
To: lee; +Cc: Luis Chamberlain, linux-modules, linux-kernel, Support Opensource
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Support Opensource <support.opensource@diasemi.com>
Cc: Lee Jones <lee@kernel.org>
---
drivers/mfd/da9052-i2c.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mfd/da9052-i2c.c b/drivers/mfd/da9052-i2c.c
index ecb8077cdaaf9..03db7a2ccf7a0 100644
--- a/drivers/mfd/da9052-i2c.c
+++ b/drivers/mfd/da9052-i2c.c
@@ -209,4 +209,3 @@ module_exit(da9052_i2c_exit);
MODULE_AUTHOR("David Dajun Chen <dchen@diasemi.com>");
MODULE_DESCRIPTION("I2C driver for Dialog DA9052 PMIC");
-MODULE_LICENSE("GPL");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 04/18] mfd: da9052-spi: remove MODULE_LICENSE in non-modules
2023-03-08 19:42 [PATCH 01/18] mfd: da903x: remove MODULE_LICENSE in non-modules Nick Alcock
2023-03-08 19:42 ` [PATCH 02/18] mfd: da9052: " Nick Alcock
2023-03-08 19:42 ` [PATCH 03/18] mfd: da9052-i2c: " Nick Alcock
@ 2023-03-08 19:42 ` Nick Alcock
2023-03-08 19:42 ` [PATCH 05/18] mfd: da9055: " Nick Alcock
` (14 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: Nick Alcock @ 2023-03-08 19:42 UTC (permalink / raw)
To: lee; +Cc: Luis Chamberlain, linux-modules, linux-kernel, Support Opensource
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Support Opensource <support.opensource@diasemi.com>
Cc: Lee Jones <lee@kernel.org>
---
drivers/mfd/da9052-spi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mfd/da9052-spi.c b/drivers/mfd/da9052-spi.c
index b79a57b45c1e8..be5f2b34e18ae 100644
--- a/drivers/mfd/da9052-spi.c
+++ b/drivers/mfd/da9052-spi.c
@@ -102,4 +102,3 @@ module_exit(da9052_spi_exit);
MODULE_AUTHOR("David Dajun Chen <dchen@diasemi.com>");
MODULE_DESCRIPTION("SPI driver for Dialog DA9052 PMIC");
-MODULE_LICENSE("GPL");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 05/18] mfd: da9055: remove MODULE_LICENSE in non-modules
2023-03-08 19:42 [PATCH 01/18] mfd: da903x: remove MODULE_LICENSE in non-modules Nick Alcock
` (2 preceding siblings ...)
2023-03-08 19:42 ` [PATCH 04/18] mfd: da9052-spi: " Nick Alcock
@ 2023-03-08 19:42 ` Nick Alcock
2023-03-08 19:42 ` [PATCH 06/18] mfd: da9055-i2c: " Nick Alcock
` (13 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: Nick Alcock @ 2023-03-08 19:42 UTC (permalink / raw)
To: lee; +Cc: Luis Chamberlain, linux-modules, linux-kernel, Support Opensource
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Support Opensource <support.opensource@diasemi.com>
Cc: Lee Jones <lee@kernel.org>
---
drivers/mfd/da9055-core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mfd/da9055-core.c b/drivers/mfd/da9055-core.c
index c3bcbd8905c6c..768302e05baa1 100644
--- a/drivers/mfd/da9055-core.c
+++ b/drivers/mfd/da9055-core.c
@@ -398,5 +398,4 @@ void da9055_device_exit(struct da9055 *da9055)
}
MODULE_DESCRIPTION("Core support for the DA9055 PMIC");
-MODULE_LICENSE("GPL");
MODULE_AUTHOR("David Dajun Chen <dchen@diasemi.com>");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 06/18] mfd: da9055-i2c: remove MODULE_LICENSE in non-modules
2023-03-08 19:42 [PATCH 01/18] mfd: da903x: remove MODULE_LICENSE in non-modules Nick Alcock
` (3 preceding siblings ...)
2023-03-08 19:42 ` [PATCH 05/18] mfd: da9055: " Nick Alcock
@ 2023-03-08 19:42 ` Nick Alcock
2023-03-08 19:42 ` [PATCH 07/18] mfd: stmpe-i2c: " Nick Alcock
` (12 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: Nick Alcock @ 2023-03-08 19:42 UTC (permalink / raw)
To: lee; +Cc: Luis Chamberlain, linux-modules, linux-kernel, Support Opensource
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Support Opensource <support.opensource@diasemi.com>
Cc: Lee Jones <lee@kernel.org>
---
drivers/mfd/da9055-i2c.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mfd/da9055-i2c.c b/drivers/mfd/da9055-i2c.c
index 702abff506a1a..537fd5de3e6d4 100644
--- a/drivers/mfd/da9055-i2c.c
+++ b/drivers/mfd/da9055-i2c.c
@@ -97,4 +97,3 @@ module_exit(da9055_i2c_exit);
MODULE_AUTHOR("David Dajun Chen <dchen@diasemi.com>");
MODULE_DESCRIPTION("I2C driver for Dialog DA9055 PMIC");
-MODULE_LICENSE("GPL");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 07/18] mfd: stmpe-i2c: remove MODULE_LICENSE in non-modules
2023-03-08 19:42 [PATCH 01/18] mfd: da903x: remove MODULE_LICENSE in non-modules Nick Alcock
` (4 preceding siblings ...)
2023-03-08 19:42 ` [PATCH 06/18] mfd: da9055-i2c: " Nick Alcock
@ 2023-03-08 19:42 ` Nick Alcock
2023-03-08 19:42 ` [PATCH 08/18] mfd: stmpe-spi: " Nick Alcock
` (11 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: Nick Alcock @ 2023-03-08 19:42 UTC (permalink / raw)
To: lee
Cc: Luis Chamberlain, linux-modules, linux-kernel, Maxime Coquelin,
Alexandre Torgue, linux-stm32, linux-arm-kernel
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Lee Jones <lee@kernel.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-arm-kernel@lists.infradead.org
---
drivers/mfd/stmpe-i2c.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mfd/stmpe-i2c.c b/drivers/mfd/stmpe-i2c.c
index d4944fc1feb18..7998e0db1e158 100644
--- a/drivers/mfd/stmpe-i2c.c
+++ b/drivers/mfd/stmpe-i2c.c
@@ -135,6 +135,5 @@ static void __exit stmpe_exit(void)
}
module_exit(stmpe_exit);
-MODULE_LICENSE("GPL v2");
MODULE_DESCRIPTION("STMPE MFD I2C Interface Driver");
MODULE_AUTHOR("Rabin Vincent <rabin.vincent@stericsson.com>");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 08/18] mfd: stmpe-spi: remove MODULE_LICENSE in non-modules
2023-03-08 19:42 [PATCH 01/18] mfd: da903x: remove MODULE_LICENSE in non-modules Nick Alcock
` (5 preceding siblings ...)
2023-03-08 19:42 ` [PATCH 07/18] mfd: stmpe-i2c: " Nick Alcock
@ 2023-03-08 19:42 ` Nick Alcock
2023-03-08 19:42 ` [PATCH 09/18] mfd: 88pm860x: " Nick Alcock
` (10 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: Nick Alcock @ 2023-03-08 19:42 UTC (permalink / raw)
To: lee
Cc: Luis Chamberlain, linux-modules, linux-kernel, Maxime Coquelin,
Alexandre Torgue, linux-stm32, linux-arm-kernel
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Lee Jones <lee@kernel.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-arm-kernel@lists.infradead.org
---
drivers/mfd/stmpe-spi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mfd/stmpe-spi.c b/drivers/mfd/stmpe-spi.c
index e9cbf33502b3d..792236f56399a 100644
--- a/drivers/mfd/stmpe-spi.c
+++ b/drivers/mfd/stmpe-spi.c
@@ -154,6 +154,5 @@ static void __exit stmpe_exit(void)
}
module_exit(stmpe_exit);
-MODULE_LICENSE("GPL v2");
MODULE_DESCRIPTION("STMPE MFD SPI Interface Driver");
MODULE_AUTHOR("Viresh Kumar <vireshk@kernel.org>");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 09/18] mfd: 88pm860x: remove MODULE_LICENSE in non-modules
2023-03-08 19:42 [PATCH 01/18] mfd: da903x: remove MODULE_LICENSE in non-modules Nick Alcock
` (6 preceding siblings ...)
2023-03-08 19:42 ` [PATCH 08/18] mfd: stmpe-spi: " Nick Alcock
@ 2023-03-08 19:42 ` Nick Alcock
2023-03-08 19:42 ` [PATCH 10/18] mfd: da9055: do not cite as modular Nick Alcock
` (9 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: Nick Alcock @ 2023-03-08 19:42 UTC (permalink / raw)
To: lee; +Cc: Luis Chamberlain, linux-modules, linux-kernel
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Lee Jones <lee@kernel.org>
---
drivers/mfd/88pm860x-core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mfd/88pm860x-core.c b/drivers/mfd/88pm860x-core.c
index 6ba7169cb953a..3c57e537d57fb 100644
--- a/drivers/mfd/88pm860x-core.c
+++ b/drivers/mfd/88pm860x-core.c
@@ -1276,4 +1276,3 @@ module_exit(pm860x_i2c_exit);
MODULE_DESCRIPTION("PMIC Driver for Marvell 88PM860x");
MODULE_AUTHOR("Haojian Zhuang <haojian.zhuang@marvell.com>");
-MODULE_LICENSE("GPL");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 10/18] mfd: da9055: do not cite as modular
2023-03-08 19:42 [PATCH 01/18] mfd: da903x: remove MODULE_LICENSE in non-modules Nick Alcock
` (7 preceding siblings ...)
2023-03-08 19:42 ` [PATCH 09/18] mfd: 88pm860x: " Nick Alcock
@ 2023-03-08 19:42 ` Nick Alcock
2023-03-09 18:29 ` Vincenzo Palazzo
2023-03-08 19:43 ` [PATCH 11/18] mfd: tc3589x: remove MODULE_LICENSE in non-modules Nick Alcock
` (8 subsequent siblings)
17 siblings, 1 reply; 20+ messages in thread
From: Nick Alcock @ 2023-03-08 19:42 UTC (permalink / raw)
To: lee; +Cc: linux-modules, linux-kernel
This driver cannot be built as a module, so don't suggest otherwise
in Kconfig help.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Lee Jones <lee@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Lee Jones <lee@kernel.org>
---
drivers/mfd/Kconfig | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index fcc141e067b9b..6d32348bdb809 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -353,9 +353,6 @@ config MFD_DA9055
Additional drivers must be enabled in order to use the functionality
of the device.
- This driver can be built as a module. If built as a module it will be
- called "da9055"
-
config MFD_DA9062
tristate "Dialog Semiconductor DA9062/61 PMIC Support"
select MFD_CORE
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 11/18] mfd: tc3589x: remove MODULE_LICENSE in non-modules
2023-03-08 19:42 [PATCH 01/18] mfd: da903x: remove MODULE_LICENSE in non-modules Nick Alcock
` (8 preceding siblings ...)
2023-03-08 19:42 ` [PATCH 10/18] mfd: da9055: do not cite as modular Nick Alcock
@ 2023-03-08 19:43 ` Nick Alcock
2023-03-08 19:43 ` [PATCH 12/18] mfd: tps6586x: " Nick Alcock
` (7 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: Nick Alcock @ 2023-03-08 19:43 UTC (permalink / raw)
To: lee; +Cc: Luis Chamberlain, linux-modules, linux-kernel
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Lee Jones <lee@kernel.org>
---
drivers/mfd/tc3589x.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mfd/tc3589x.c b/drivers/mfd/tc3589x.c
index 1f6e0d682cd9f..cbfe19d1b1459 100644
--- a/drivers/mfd/tc3589x.c
+++ b/drivers/mfd/tc3589x.c
@@ -502,6 +502,5 @@ static void __exit tc3589x_exit(void)
}
module_exit(tc3589x_exit);
-MODULE_LICENSE("GPL v2");
MODULE_DESCRIPTION("TC3589x MFD core driver");
MODULE_AUTHOR("Hanumath Prasad, Rabin Vincent");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 12/18] mfd: tps6586x: remove MODULE_LICENSE in non-modules
2023-03-08 19:42 [PATCH 01/18] mfd: da903x: remove MODULE_LICENSE in non-modules Nick Alcock
` (9 preceding siblings ...)
2023-03-08 19:43 ` [PATCH 11/18] mfd: tc3589x: remove MODULE_LICENSE in non-modules Nick Alcock
@ 2023-03-08 19:43 ` Nick Alcock
2023-03-08 19:43 ` [PATCH 13/18] mfd: ezx-pcap: " Nick Alcock
` (6 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: Nick Alcock @ 2023-03-08 19:43 UTC (permalink / raw)
To: lee; +Cc: Luis Chamberlain, linux-modules, linux-kernel
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Lee Jones <lee@kernel.org>
---
drivers/mfd/tps6586x.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c
index 2d947f3f606a6..90e23232b6b0e 100644
--- a/drivers/mfd/tps6586x.c
+++ b/drivers/mfd/tps6586x.c
@@ -638,4 +638,3 @@ module_exit(tps6586x_exit);
MODULE_DESCRIPTION("TPS6586X core driver");
MODULE_AUTHOR("Mike Rapoport <mike@compulab.co.il>");
-MODULE_LICENSE("GPL");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 13/18] mfd: ezx-pcap: remove MODULE_LICENSE in non-modules
2023-03-08 19:42 [PATCH 01/18] mfd: da903x: remove MODULE_LICENSE in non-modules Nick Alcock
` (10 preceding siblings ...)
2023-03-08 19:43 ` [PATCH 12/18] mfd: tps6586x: " Nick Alcock
@ 2023-03-08 19:43 ` Nick Alcock
2023-03-08 19:43 ` [PATCH 14/18] mfd: lp8788: " Nick Alcock
` (5 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: Nick Alcock @ 2023-03-08 19:43 UTC (permalink / raw)
To: lee; +Cc: Luis Chamberlain, linux-modules, linux-kernel
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Lee Jones <lee@kernel.org>
---
drivers/mfd/ezx-pcap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mfd/ezx-pcap.c b/drivers/mfd/ezx-pcap.c
index 3d5ce18aa9ae7..8d006f6be48c7 100644
--- a/drivers/mfd/ezx-pcap.c
+++ b/drivers/mfd/ezx-pcap.c
@@ -528,7 +528,6 @@ static void __exit ezx_pcap_exit(void)
subsys_initcall(ezx_pcap_init);
module_exit(ezx_pcap_exit);
-MODULE_LICENSE("GPL");
MODULE_AUTHOR("Daniel Ribeiro / Harald Welte");
MODULE_DESCRIPTION("Motorola PCAP2 ASIC Driver");
MODULE_ALIAS("spi:ezx-pcap");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 14/18] mfd: lp8788: remove MODULE_LICENSE in non-modules
2023-03-08 19:42 [PATCH 01/18] mfd: da903x: remove MODULE_LICENSE in non-modules Nick Alcock
` (11 preceding siblings ...)
2023-03-08 19:43 ` [PATCH 13/18] mfd: ezx-pcap: " Nick Alcock
@ 2023-03-08 19:43 ` Nick Alcock
2023-03-08 19:43 ` [PATCH 15/18] mfd: omap-usb-host: " Nick Alcock
` (4 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: Nick Alcock @ 2023-03-08 19:43 UTC (permalink / raw)
To: lee; +Cc: Luis Chamberlain, linux-modules, linux-kernel
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Lee Jones <lee@kernel.org>
---
drivers/mfd/lp8788.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mfd/lp8788.c b/drivers/mfd/lp8788.c
index fe809b64147e6..18583addaae28 100644
--- a/drivers/mfd/lp8788.c
+++ b/drivers/mfd/lp8788.c
@@ -244,4 +244,3 @@ module_exit(lp8788_exit);
MODULE_DESCRIPTION("TI LP8788 MFD Driver");
MODULE_AUTHOR("Milo Kim");
-MODULE_LICENSE("GPL");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 15/18] mfd: omap-usb-host: remove MODULE_LICENSE in non-modules
2023-03-08 19:42 [PATCH 01/18] mfd: da903x: remove MODULE_LICENSE in non-modules Nick Alcock
` (12 preceding siblings ...)
2023-03-08 19:43 ` [PATCH 14/18] mfd: lp8788: " Nick Alcock
@ 2023-03-08 19:43 ` Nick Alcock
2023-03-08 19:43 ` [PATCH 16/18] mfd: omap-usb-tll: " Nick Alcock
` (3 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: Nick Alcock @ 2023-03-08 19:43 UTC (permalink / raw)
To: lee
Cc: Luis Chamberlain, linux-modules, linux-kernel, Tony Lindgren, linux-omap
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Tony Lindgren <tony@atomide.com>
Cc: Lee Jones <lee@kernel.org>
Cc: linux-omap@vger.kernel.org
---
drivers/mfd/omap-usb-host.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index 787d2ae863752..7f57751095938 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -853,7 +853,6 @@ static struct platform_driver usbhs_omap_driver = {
MODULE_AUTHOR("Keshava Munegowda <keshava_mgowda@ti.com>");
MODULE_AUTHOR("Roger Quadros <rogerq@ti.com>");
MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
-MODULE_LICENSE("GPL v2");
MODULE_DESCRIPTION("usb host common core driver for omap EHCI and OHCI");
static int omap_usbhs_drvinit(void)
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 16/18] mfd: omap-usb-tll: remove MODULE_LICENSE in non-modules
2023-03-08 19:42 [PATCH 01/18] mfd: da903x: remove MODULE_LICENSE in non-modules Nick Alcock
` (13 preceding siblings ...)
2023-03-08 19:43 ` [PATCH 15/18] mfd: omap-usb-host: " Nick Alcock
@ 2023-03-08 19:43 ` Nick Alcock
2023-03-08 19:43 ` [PATCH 17/18] mfd: twl4030-audio: " Nick Alcock
` (2 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: Nick Alcock @ 2023-03-08 19:43 UTC (permalink / raw)
To: lee
Cc: Luis Chamberlain, linux-modules, linux-kernel, Tony Lindgren, linux-omap
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Tony Lindgren <tony@atomide.com>
Cc: Lee Jones <lee@kernel.org>
Cc: linux-omap@vger.kernel.org
---
drivers/mfd/omap-usb-tll.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
index 080d7970a3774..8ca4067da6cd3 100644
--- a/drivers/mfd/omap-usb-tll.c
+++ b/drivers/mfd/omap-usb-tll.c
@@ -450,7 +450,6 @@ EXPORT_SYMBOL_GPL(omap_tll_disable);
MODULE_AUTHOR("Keshava Munegowda <keshava_mgowda@ti.com>");
MODULE_AUTHOR("Roger Quadros <rogerq@ti.com>");
-MODULE_LICENSE("GPL v2");
MODULE_DESCRIPTION("usb tll driver for TI OMAP EHCI and OHCI controllers");
static int __init omap_usbtll_drvinit(void)
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 17/18] mfd: twl4030-audio: remove MODULE_LICENSE in non-modules
2023-03-08 19:42 [PATCH 01/18] mfd: da903x: remove MODULE_LICENSE in non-modules Nick Alcock
` (14 preceding siblings ...)
2023-03-08 19:43 ` [PATCH 16/18] mfd: omap-usb-tll: " Nick Alcock
@ 2023-03-08 19:43 ` Nick Alcock
2023-03-08 19:43 ` [PATCH 18/18] mfd: twl6040: " Nick Alcock
2023-03-16 15:42 ` [PATCH 01/18] mfd: da903x: " Lee Jones
17 siblings, 0 replies; 20+ messages in thread
From: Nick Alcock @ 2023-03-08 19:43 UTC (permalink / raw)
To: lee
Cc: Luis Chamberlain, linux-modules, linux-kernel, Tony Lindgren, linux-omap
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Tony Lindgren <tony@atomide.com>
Cc: Lee Jones <lee@kernel.org>
Cc: linux-omap@vger.kernel.org
---
drivers/mfd/twl4030-audio.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mfd/twl4030-audio.c b/drivers/mfd/twl4030-audio.c
index 4536d829b43e4..88002f8941e5e 100644
--- a/drivers/mfd/twl4030-audio.c
+++ b/drivers/mfd/twl4030-audio.c
@@ -285,5 +285,4 @@ module_platform_driver(twl4030_audio_driver);
MODULE_AUTHOR("Peter Ujfalusi <peter.ujfalusi@ti.com>");
MODULE_DESCRIPTION("TWL4030 audio block MFD driver");
-MODULE_LICENSE("GPL");
MODULE_ALIAS("platform:twl4030-audio");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 18/18] mfd: twl6040: remove MODULE_LICENSE in non-modules
2023-03-08 19:42 [PATCH 01/18] mfd: da903x: remove MODULE_LICENSE in non-modules Nick Alcock
` (15 preceding siblings ...)
2023-03-08 19:43 ` [PATCH 17/18] mfd: twl4030-audio: " Nick Alcock
@ 2023-03-08 19:43 ` Nick Alcock
2023-03-16 15:42 ` [PATCH 01/18] mfd: da903x: " Lee Jones
17 siblings, 0 replies; 20+ messages in thread
From: Nick Alcock @ 2023-03-08 19:43 UTC (permalink / raw)
To: lee
Cc: Luis Chamberlain, linux-modules, linux-kernel, Tony Lindgren, linux-omap
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Tony Lindgren <tony@atomide.com>
Cc: Lee Jones <lee@kernel.org>
Cc: linux-omap@vger.kernel.org
---
drivers/mfd/twl6040.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mfd/twl6040.c b/drivers/mfd/twl6040.c
index fc97fa5a2d0c3..e982119bbefa5 100644
--- a/drivers/mfd/twl6040.c
+++ b/drivers/mfd/twl6040.c
@@ -839,4 +839,3 @@ module_i2c_driver(twl6040_driver);
MODULE_DESCRIPTION("TWL6040 MFD");
MODULE_AUTHOR("Misael Lopez Cruz <misael.lopez@ti.com>");
MODULE_AUTHOR("Jorge Eduardo Candelaria <jorge.candelaria@ti.com>");
-MODULE_LICENSE("GPL");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH 10/18] mfd: da9055: do not cite as modular
2023-03-08 19:42 ` [PATCH 10/18] mfd: da9055: do not cite as modular Nick Alcock
@ 2023-03-09 18:29 ` Vincenzo Palazzo
0 siblings, 0 replies; 20+ messages in thread
From: Vincenzo Palazzo @ 2023-03-09 18:29 UTC (permalink / raw)
To: Nick Alcock, lee; +Cc: linux-modules, linux-kernel
> This driver cannot be built as a module, so don't suggest otherwise
> in Kconfig help.
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Lee Jones <lee@kernel.org>
> Cc: linux-modules@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Lee Jones <lee@kernel.org>
> ---
Reviewed-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 01/18] mfd: da903x: remove MODULE_LICENSE in non-modules
2023-03-08 19:42 [PATCH 01/18] mfd: da903x: remove MODULE_LICENSE in non-modules Nick Alcock
` (16 preceding siblings ...)
2023-03-08 19:43 ` [PATCH 18/18] mfd: twl6040: " Nick Alcock
@ 2023-03-16 15:42 ` Lee Jones
17 siblings, 0 replies; 20+ messages in thread
From: Lee Jones @ 2023-03-16 15:42 UTC (permalink / raw)
To: Nick Alcock
Cc: Luis Chamberlain, linux-modules, linux-kernel, Support Opensource
On Wed, 08 Mar 2023, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: linux-modules@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Support Opensource <support.opensource@diasemi.com>
> Cc: Lee Jones <lee@kernel.org>
> ---
> drivers/mfd/da903x.c | 1 -
> 1 file changed, 1 deletion(-)
All applied, thanks
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2023-03-16 15:44 UTC | newest]
Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-08 19:42 [PATCH 01/18] mfd: da903x: remove MODULE_LICENSE in non-modules Nick Alcock
2023-03-08 19:42 ` [PATCH 02/18] mfd: da9052: " Nick Alcock
2023-03-08 19:42 ` [PATCH 03/18] mfd: da9052-i2c: " Nick Alcock
2023-03-08 19:42 ` [PATCH 04/18] mfd: da9052-spi: " Nick Alcock
2023-03-08 19:42 ` [PATCH 05/18] mfd: da9055: " Nick Alcock
2023-03-08 19:42 ` [PATCH 06/18] mfd: da9055-i2c: " Nick Alcock
2023-03-08 19:42 ` [PATCH 07/18] mfd: stmpe-i2c: " Nick Alcock
2023-03-08 19:42 ` [PATCH 08/18] mfd: stmpe-spi: " Nick Alcock
2023-03-08 19:42 ` [PATCH 09/18] mfd: 88pm860x: " Nick Alcock
2023-03-08 19:42 ` [PATCH 10/18] mfd: da9055: do not cite as modular Nick Alcock
2023-03-09 18:29 ` Vincenzo Palazzo
2023-03-08 19:43 ` [PATCH 11/18] mfd: tc3589x: remove MODULE_LICENSE in non-modules Nick Alcock
2023-03-08 19:43 ` [PATCH 12/18] mfd: tps6586x: " Nick Alcock
2023-03-08 19:43 ` [PATCH 13/18] mfd: ezx-pcap: " Nick Alcock
2023-03-08 19:43 ` [PATCH 14/18] mfd: lp8788: " Nick Alcock
2023-03-08 19:43 ` [PATCH 15/18] mfd: omap-usb-host: " Nick Alcock
2023-03-08 19:43 ` [PATCH 16/18] mfd: omap-usb-tll: " Nick Alcock
2023-03-08 19:43 ` [PATCH 17/18] mfd: twl4030-audio: " Nick Alcock
2023-03-08 19:43 ` [PATCH 18/18] mfd: twl6040: " Nick Alcock
2023-03-16 15:42 ` [PATCH 01/18] mfd: da903x: " Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).