* [PATCH] bus: imx-weim: fix branch condition evaluates to a garbage value
@ 2023-02-17 13:59 Ivan Bornyakov
2023-02-24 6:05 ` Ivan Bornyakov
2023-03-14 1:18 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Ivan Bornyakov @ 2023-02-17 13:59 UTC (permalink / raw)
To: linux-imx
Cc: Ivan Bornyakov, shawnguo, s.hauer, kernel, festevam,
linux-arm-kernel, linux-kernel, stable
If bus type is other than imx50_weim_devtype and have no child devices,
variable 'ret' in function weim_parse_dt() will not be initialized, but
will be used as branch condition and return value. Fix this by
initializing 'ret' with 0.
This was discovered with help of clang-analyzer, but the situation is
quite possible in real life.
Signed-off-by: Ivan Bornyakov <i.bornyakov@metrotek.ru>
Cc: stable@vger.kernel.org
---
drivers/bus/imx-weim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
index 828c66bbaa67..55d917bd1f3f 100644
--- a/drivers/bus/imx-weim.c
+++ b/drivers/bus/imx-weim.c
@@ -204,8 +204,8 @@ static int weim_parse_dt(struct platform_device *pdev)
const struct of_device_id *of_id = of_match_device(weim_id_table,
&pdev->dev);
const struct imx_weim_devtype *devtype = of_id->data;
+ int ret = 0, have_child = 0;
struct device_node *child;
- int ret, have_child = 0;
struct weim_priv *priv;
void __iomem *base;
u32 reg;
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bus: imx-weim: fix branch condition evaluates to a garbage value
2023-02-17 13:59 [PATCH] bus: imx-weim: fix branch condition evaluates to a garbage value Ivan Bornyakov
@ 2023-02-24 6:05 ` Ivan Bornyakov
2023-03-14 1:18 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Ivan Bornyakov @ 2023-02-24 6:05 UTC (permalink / raw)
To: linux-imx
Cc: shawnguo, s.hauer, kernel, festevam, linux-arm-kernel,
linux-kernel, stable, i.bornyakov
On Fri, Feb 17, 2023 at 04:59:50PM +0300, Ivan Bornyakov wrote:
> If bus type is other than imx50_weim_devtype and have no child devices,
> variable 'ret' in function weim_parse_dt() will not be initialized, but
> will be used as branch condition and return value. Fix this by
> initializing 'ret' with 0.
>
> This was discovered with help of clang-analyzer, but the situation is
> quite possible in real life.
>
> Signed-off-by: Ivan Bornyakov <i.bornyakov@metrotek.ru>
> Cc: stable@vger.kernel.org
> ---
> drivers/bus/imx-weim.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> index 828c66bbaa67..55d917bd1f3f 100644
> --- a/drivers/bus/imx-weim.c
> +++ b/drivers/bus/imx-weim.c
> @@ -204,8 +204,8 @@ static int weim_parse_dt(struct platform_device *pdev)
> const struct of_device_id *of_id = of_match_device(weim_id_table,
> &pdev->dev);
> const struct imx_weim_devtype *devtype = of_id->data;
> + int ret = 0, have_child = 0;
> struct device_node *child;
> - int ret, have_child = 0;
> struct weim_priv *priv;
> void __iomem *base;
> u32 reg;
> --
> 2.39.2
>
Friendly ping.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bus: imx-weim: fix branch condition evaluates to a garbage value
2023-02-17 13:59 [PATCH] bus: imx-weim: fix branch condition evaluates to a garbage value Ivan Bornyakov
2023-02-24 6:05 ` Ivan Bornyakov
@ 2023-03-14 1:18 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2023-03-14 1:18 UTC (permalink / raw)
To: Ivan Bornyakov
Cc: linux-imx, s.hauer, kernel, festevam, linux-arm-kernel,
linux-kernel, stable
On Fri, Feb 17, 2023 at 04:59:50PM +0300, Ivan Bornyakov wrote:
> If bus type is other than imx50_weim_devtype and have no child devices,
> variable 'ret' in function weim_parse_dt() will not be initialized, but
> will be used as branch condition and return value. Fix this by
> initializing 'ret' with 0.
>
> This was discovered with help of clang-analyzer, but the situation is
> quite possible in real life.
>
> Signed-off-by: Ivan Bornyakov <i.bornyakov@metrotek.ru>
> Cc: stable@vger.kernel.org
Applied with Fixes tag below. Let me know if it's incorrect.
Fixes: 52c47b63412b ("bus: imx-weim: improve error handling upon child probe-failure")
Shawn
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-14 1:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-17 13:59 [PATCH] bus: imx-weim: fix branch condition evaluates to a garbage value Ivan Bornyakov
2023-02-24 6:05 ` Ivan Bornyakov
2023-03-14 1:18 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).