linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mtd: rawnand: remove unused is_imx51_nfc and imx53_nfc functions
@ 2023-03-21 11:46 Tom Rix
  2023-03-22 16:08 ` Miquel Raynal
  0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2023-03-21 11:46 UTC (permalink / raw)
  To: miquel.raynal, richard, vigneshr, nathan, ndesaulniers
  Cc: linux-mtd, linux-kernel, llvm, Tom Rix

clang with W=1 reports
drivers/mtd/nand/raw/mxc_nand.c:1602:19: error: unused function
  'is_imx51_nfc' [-Werror,-Wunused-function]
static inline int is_imx51_nfc(struct mxc_nand_host *host)
                  ^
drivers/mtd/nand/raw/mxc_nand.c:1607:19: error: unused function
  'is_imx53_nfc' [-Werror,-Wunused-function]
static inline int is_imx53_nfc(struct mxc_nand_host *host)
                  ^
These functions are not used, so remove them.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/mtd/nand/raw/mxc_nand.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/mtd/nand/raw/mxc_nand.c b/drivers/mtd/nand/raw/mxc_nand.c
index f6c96341b896..f61ffcbe57c8 100644
--- a/drivers/mtd/nand/raw/mxc_nand.c
+++ b/drivers/mtd/nand/raw/mxc_nand.c
@@ -1599,16 +1599,6 @@ static inline int is_imx25_nfc(struct mxc_nand_host *host)
 	return host->devtype_data == &imx25_nand_devtype_data;
 }
 
-static inline int is_imx51_nfc(struct mxc_nand_host *host)
-{
-	return host->devtype_data == &imx51_nand_devtype_data;
-}
-
-static inline int is_imx53_nfc(struct mxc_nand_host *host)
-{
-	return host->devtype_data == &imx53_nand_devtype_data;
-}
-
 static const struct of_device_id mxcnd_dt_ids[] = {
 	{ .compatible = "fsl,imx21-nand", .data = &imx21_nand_devtype_data, },
 	{ .compatible = "fsl,imx27-nand", .data = &imx27_nand_devtype_data, },
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mtd: rawnand: remove unused is_imx51_nfc and imx53_nfc functions
  2023-03-21 11:46 [PATCH] mtd: rawnand: remove unused is_imx51_nfc and imx53_nfc functions Tom Rix
@ 2023-03-22 16:08 ` Miquel Raynal
  0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2023-03-22 16:08 UTC (permalink / raw)
  To: Tom Rix, miquel.raynal, richard, vigneshr, nathan, ndesaulniers
  Cc: linux-mtd, linux-kernel, llvm

On Tue, 2023-03-21 at 11:46:38 UTC, Tom Rix wrote:
> clang with W=1 reports
> drivers/mtd/nand/raw/mxc_nand.c:1602:19: error: unused function
>   'is_imx51_nfc' [-Werror,-Wunused-function]
> static inline int is_imx51_nfc(struct mxc_nand_host *host)
>                   ^
> drivers/mtd/nand/raw/mxc_nand.c:1607:19: error: unused function
>   'is_imx53_nfc' [-Werror,-Wunused-function]
> static inline int is_imx53_nfc(struct mxc_nand_host *host)
>                   ^
> These functions are not used, so remove them.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-03-22 16:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-21 11:46 [PATCH] mtd: rawnand: remove unused is_imx51_nfc and imx53_nfc functions Tom Rix
2023-03-22 16:08 ` Miquel Raynal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).