* [PATCH] mtd: rawnand: mxc: Remove the unused function is_imx51_nfc()
@ 2023-03-17 7:40 Jiapeng Chong
2023-03-22 14:55 ` Miquel Raynal
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2023-03-17 7:40 UTC (permalink / raw)
To: miquel.raynal
Cc: richard, vigneshr, linux-mtd, linux-kernel, Jiapeng Chong, Abaci Robot
The function is_imx51_nfc is defined in the mxc_nand.c file, but not
called elsewhere, so remove this unused function.
drivers/mtd/nand/raw/mxc_nand.c:1602:19: warning: unused function 'is_imx51_nfc'.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4559
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/mtd/nand/raw/mxc_nand.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/mtd/nand/raw/mxc_nand.c b/drivers/mtd/nand/raw/mxc_nand.c
index f6c96341b896..16d795c25609 100644
--- a/drivers/mtd/nand/raw/mxc_nand.c
+++ b/drivers/mtd/nand/raw/mxc_nand.c
@@ -1599,11 +1599,6 @@ static inline int is_imx25_nfc(struct mxc_nand_host *host)
return host->devtype_data == &imx25_nand_devtype_data;
}
-static inline int is_imx51_nfc(struct mxc_nand_host *host)
-{
- return host->devtype_data == &imx51_nand_devtype_data;
-}
-
static inline int is_imx53_nfc(struct mxc_nand_host *host)
{
return host->devtype_data == &imx53_nand_devtype_data;
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mtd: rawnand: mxc: Remove the unused function is_imx51_nfc()
2023-03-17 7:40 [PATCH] mtd: rawnand: mxc: Remove the unused function is_imx51_nfc() Jiapeng Chong
@ 2023-03-22 14:55 ` Miquel Raynal
0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2023-03-22 14:55 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: richard, vigneshr, linux-mtd, linux-kernel, Abaci Robot
Hi,
jiapeng.chong@linux.alibaba.com wrote on Fri, 17 Mar 2023 15:40:41
+0800:
> The function is_imx51_nfc is defined in the mxc_nand.c file, but not
> called elsewhere, so remove this unused function.
>
> drivers/mtd/nand/raw/mxc_nand.c:1602:19: warning: unused function 'is_imx51_nfc'.
Thanks for your patch, but apparently is_imx53_nfc() is also unused,
strange the robot did not pick this up. Anyway, no need to resend, I
received another patch removing both functions already.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4559
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/mtd/nand/raw/mxc_nand.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/mxc_nand.c b/drivers/mtd/nand/raw/mxc_nand.c
> index f6c96341b896..16d795c25609 100644
> --- a/drivers/mtd/nand/raw/mxc_nand.c
> +++ b/drivers/mtd/nand/raw/mxc_nand.c
> @@ -1599,11 +1599,6 @@ static inline int is_imx25_nfc(struct mxc_nand_host *host)
> return host->devtype_data == &imx25_nand_devtype_data;
> }
>
> -static inline int is_imx51_nfc(struct mxc_nand_host *host)
> -{
> - return host->devtype_data == &imx51_nand_devtype_data;
> -}
> -
> static inline int is_imx53_nfc(struct mxc_nand_host *host)
> {
> return host->devtype_data == &imx53_nand_devtype_data;
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-22 14:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-17 7:40 [PATCH] mtd: rawnand: mxc: Remove the unused function is_imx51_nfc() Jiapeng Chong
2023-03-22 14:55 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).