* [PATCH] nvme-pci: mark Lexar NM760 as IGNORE_DEV_SUBNQN
@ 2023-03-26 9:29 Juraj Pecigos
2023-03-26 23:05 ` Chaitanya Kulkarni
0 siblings, 1 reply; 2+ messages in thread
From: Juraj Pecigos @ 2023-03-26 9:29 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Juraj Pecigos, Keith Busch, Jens Axboe, Sagi Grimberg,
linux-nvme, linux-kernel
A system with more than one of these SSDs will only have one usable.
The kernel fails to detect more than one nvme device due to duplicate
cntlids.
before:
[ 9.395229] nvme 0000:01:00.0: platform quirk: setting simple suspend
[ 9.395262] nvme nvme0: pci function 0000:01:00.0
[ 9.395282] nvme 0000:03:00.0: platform quirk: setting simple suspend
[ 9.395305] nvme nvme1: pci function 0000:03:00.0
[ 9.409873] nvme nvme0: Duplicate cntlid 1 with nvme1, subsys nqn.2022-07.com.siliconmotion:nvm-subsystem-sn- , rejecting
[ 9.409982] nvme nvme0: Removing after probe failure status: -22
[ 9.427487] nvme nvme1: allocated 64 MiB host memory buffer.
[ 9.445088] nvme nvme1: 16/0/0 default/read/poll queues
[ 9.449898] nvme nvme1: Ignoring bogus Namespace Identifiers
after:
[ 1.161890] nvme 0000:01:00.0: platform quirk: setting simple suspend
[ 1.162660] nvme nvme0: pci function 0000:01:00.0
[ 1.162684] nvme 0000:03:00.0: platform quirk: setting simple suspend
[ 1.162707] nvme nvme1: pci function 0000:03:00.0
[ 1.191354] nvme nvme0: allocated 64 MiB host memory buffer.
[ 1.193378] nvme nvme1: allocated 64 MiB host memory buffer.
[ 1.211044] nvme nvme1: 16/0/0 default/read/poll queues
[ 1.211080] nvme nvme0: 16/0/0 default/read/poll queues
[ 1.216145] nvme nvme0: Ignoring bogus Namespace Identifiers
[ 1.216261] nvme nvme1: Ignoring bogus Namespace Identifiers
Adding the NVME_QUIRK_IGNORE_DEV_SUBNQN quirk to resolves the issue.
Signed-off-by: Juraj Pecigos <kernel@juraj.dev>
---
drivers/nvme/host/pci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index b615906263f3..282d808400c5 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3441,7 +3441,8 @@ static const struct pci_device_id nvme_id_table[] = {
{ PCI_DEVICE(0x1d97, 0x1d97), /* Lexar NM620 */
.driver_data = NVME_QUIRK_BOGUS_NID, },
{ PCI_DEVICE(0x1d97, 0x2269), /* Lexar NM760 */
- .driver_data = NVME_QUIRK_BOGUS_NID, },
+ .driver_data = NVME_QUIRK_BOGUS_NID |
+ NVME_QUIRK_IGNORE_DEV_SUBNQN, },
{ PCI_DEVICE(PCI_VENDOR_ID_AMAZON, 0x0061),
.driver_data = NVME_QUIRK_DMA_ADDRESS_BITS_48, },
{ PCI_DEVICE(PCI_VENDOR_ID_AMAZON, 0x0065),
--
2.40.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nvme-pci: mark Lexar NM760 as IGNORE_DEV_SUBNQN
2023-03-26 9:29 [PATCH] nvme-pci: mark Lexar NM760 as IGNORE_DEV_SUBNQN Juraj Pecigos
@ 2023-03-26 23:05 ` Chaitanya Kulkarni
0 siblings, 0 replies; 2+ messages in thread
From: Chaitanya Kulkarni @ 2023-03-26 23:05 UTC (permalink / raw)
To: Juraj Pecigos, Christoph Hellwig
Cc: Keith Busch, Jens Axboe, Sagi Grimberg, linux-nvme, linux-kernel
On 3/26/23 02:29, Juraj Pecigos wrote:
> A system with more than one of these SSDs will only have one usable.
> The kernel fails to detect more than one nvme device due to duplicate
> cntlids.
>
> before:
> [ 9.395229] nvme 0000:01:00.0: platform quirk: setting simple suspend
> [ 9.395262] nvme nvme0: pci function 0000:01:00.0
> [ 9.395282] nvme 0000:03:00.0: platform quirk: setting simple suspend
> [ 9.395305] nvme nvme1: pci function 0000:03:00.0
> [ 9.409873] nvme nvme0: Duplicate cntlid 1 with nvme1, subsys nqn.2022-07.com.siliconmotion:nvm-subsystem-sn- , rejecting
> [ 9.409982] nvme nvme0: Removing after probe failure status: -22
> [ 9.427487] nvme nvme1: allocated 64 MiB host memory buffer.
> [ 9.445088] nvme nvme1: 16/0/0 default/read/poll queues
> [ 9.449898] nvme nvme1: Ignoring bogus Namespace Identifiers
>
> after:
> [ 1.161890] nvme 0000:01:00.0: platform quirk: setting simple suspend
> [ 1.162660] nvme nvme0: pci function 0000:01:00.0
> [ 1.162684] nvme 0000:03:00.0: platform quirk: setting simple suspend
> [ 1.162707] nvme nvme1: pci function 0000:03:00.0
> [ 1.191354] nvme nvme0: allocated 64 MiB host memory buffer.
> [ 1.193378] nvme nvme1: allocated 64 MiB host memory buffer.
> [ 1.211044] nvme nvme1: 16/0/0 default/read/poll queues
> [ 1.211080] nvme nvme0: 16/0/0 default/read/poll queues
> [ 1.216145] nvme nvme0: Ignoring bogus Namespace Identifiers
> [ 1.216261] nvme nvme1: Ignoring bogus Namespace Identifiers
>
> Adding the NVME_QUIRK_IGNORE_DEV_SUBNQN quirk to resolves the issue.
>
> Signed-off-by: Juraj Pecigos <kernel@juraj.dev>
> ---
>
Just looking at the log in the commit message seems like
this is solving your problem, looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-26 23:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-26 9:29 [PATCH] nvme-pci: mark Lexar NM760 as IGNORE_DEV_SUBNQN Juraj Pecigos
2023-03-26 23:05 ` Chaitanya Kulkarni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).