[PATCH -next] devfreq: exynos-ppmu: Use devm_platform_get_and_ioremap_resource()

[PATCH -next] devfreq: exynos-ppmu: Use devm_platform_get_and_ioremap_resource()

[Yang Li]

According to commit 890cc39a8799 ("drivers: provide
devm_platform_get_and_ioremap_resource()"), convert
platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/devfreq/event/exynos-ppmu.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
index a443e7c42daf..896a6cc93b00 100644
--- a/drivers/devfreq/event/exynos-ppmu.c
+++ b/drivers/devfreq/event/exynos-ppmu.c
@@ -621,8 +621,7 @@ static int exynos_ppmu_parse_dt(struct platform_device *pdev,
 	}
 
 	/* Maps the memory mapped IO to control PPMU register */
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	base = devm_ioremap_resource(dev, res);
+	base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
 	if (IS_ERR(base))
 		return PTR_ERR(base);
 
-- 
2.20.1.7.g153144c

Re: [PATCH -next] devfreq: exynos-ppmu: Use devm_platform_get_and_ioremap_resource()

[Krzysztof Kozlowski]

On 28/03/2023 07:38, Yang Li wrote:
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert

I don't understand why do you reference this commit. There is no bug
introduced there, there is nothing related to this driver.

> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.


Best regards,
Krzysztof

Re: [PATCH -next] devfreq: exynos-ppmu: Use devm_platform_get_and_ioremap_resource()

[Andi Shyti]

Hi,

On Tue, Mar 28, 2023 at 09:19:01AM +0200, Krzysztof Kozlowski wrote:
> On 28/03/2023 07:38, Yang Li wrote:
> > According to commit 890cc39a8799 ("drivers: provide
> > devm_platform_get_and_ioremap_resource()"), convert
> 
> I don't understand why do you reference this commit. There is no bug
> introduced there, there is nothing related to this driver.
> 
> > platform_get_resource(), devm_ioremap_resource() to a single
> > call to devm_platform_get_and_ioremap_resource(), as this is exactly
> > what this function does.

I've seen Yang has sent many of these cleanups, perhaps he can
write something like:

"
Commit 890cc39a8799 ("drivers: provide
devm_platform_get_and_ioremap_resource()") introduces the
devm_platform_get_and_ioremap_resource() function which combines
both platform_get_resource() and devm_ioremap_resource() into a
single call.

Update the code to use the new combined function instead of the
separate calls.
"

With that

Reviewed-by: Andi Shyti <andi.shyti@kernel.org>

Thanks,
Andi

Re: [PATCH -next] devfreq: exynos-ppmu: Use devm_platform_get_and_ioremap_resource()

[Krzysztof Kozlowski]

On 28/03/2023 11:53, Andi Shyti wrote:
> Hi,
> 
> On Tue, Mar 28, 2023 at 09:19:01AM +0200, Krzysztof Kozlowski wrote:
>> On 28/03/2023 07:38, Yang Li wrote:
>>> According to commit 890cc39a8799 ("drivers: provide
>>> devm_platform_get_and_ioremap_resource()"), convert
>>
>> I don't understand why do you reference this commit. There is no bug
>> introduced there, there is nothing related to this driver.
>>
>>> platform_get_resource(), devm_ioremap_resource() to a single
>>> call to devm_platform_get_and_ioremap_resource(), as this is exactly
>>> what this function does.
> 
> I've seen Yang has sent many of these cleanups, perhaps he can
> write something like:
> 
> "
> Commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()") introduces the
> devm_platform_get_and_ioremap_resource() function which combines
> both platform_get_resource() and devm_ioremap_resource() into a
> single call.

I don't think we need to reference that commit at all. It does not
matter when the API was introduced and just makes commit msg unnecessary
long. Instead the commit msg should shortly say why this change is
needed or even worth accepting.

> 
> Update the code to use the new combined function instead of the
> separate calls.

Best regards,
Krzysztof