* linux-next: build warning after merge of the iommufd tree
@ 2023-03-31 4:31 Stephen Rothwell
2023-03-31 5:09 ` Nicolin Chen
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2023-03-31 4:31 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: Jason Gunthorpe, Nicolin Chen, Yi Liu, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 456 bytes --]
Hi all,
After merging the iommufd tree, today's linux-next build (htmldocs)
produced this warning:
drivers/iommu/iommufd/device.c:674: warning: Excess function parameter 'ioas_id' description in 'iommufd_access_create'
Introduced by commits
7540af571dc7 ("iommufd: Create access in vfio_iommufd_emulated_bind()")
8003e9a6c169 ("vfio-iommufd: Make vfio_iommufd_emulated_bind() return iommufd_access ID")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build warning after merge of the iommufd tree
2023-03-31 4:31 linux-next: build warning after merge of the iommufd tree Stephen Rothwell
@ 2023-03-31 5:09 ` Nicolin Chen
2023-03-31 17:44 ` Jason Gunthorpe
0 siblings, 1 reply; 6+ messages in thread
From: Nicolin Chen @ 2023-03-31 5:09 UTC (permalink / raw)
To: Jason Gunthorpe, Stephen Rothwell
Cc: Jason Gunthorpe, Yi Liu, Linux Kernel Mailing List,
Linux Next Mailing List
Thanks for reporting.
On Fri, Mar 31, 2023 at 03:31:46PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the iommufd tree, today's linux-next build (htmldocs)
> produced this warning:
>
> drivers/iommu/iommufd/device.c:674: warning: Excess function parameter 'ioas_id' description in 'iommufd_access_create'
>
> Introduced by commits
>
> 7540af571dc7 ("iommufd: Create access in vfio_iommufd_emulated_bind()")
Should have dropped that line from kdoc in this commit.
diff --git a/drivers/iommu/iommufd/device.c b/drivers/iommu/iommufd/device.c
index fca09bb4e839..d791ab5830b4 100644
--- a/drivers/iommu/iommufd/device.c
+++ b/drivers/iommu/iommufd/device.c
@@ -795,7 +795,6 @@ void iommufd_access_destroy_object(struct iommufd_object *obj)
/**
* iommufd_access_create - Create an iommufd_access
* @ictx: iommufd file descriptor
- * @ioas_id: ID for a IOMMUFD_OBJ_IOAS
* @ops: Driver's ops to associate with the access
* @data: Opaque data to pass into ops functions
*
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: linux-next: build warning after merge of the iommufd tree
2023-03-31 5:09 ` Nicolin Chen
@ 2023-03-31 17:44 ` Jason Gunthorpe
0 siblings, 0 replies; 6+ messages in thread
From: Jason Gunthorpe @ 2023-03-31 17:44 UTC (permalink / raw)
To: Nicolin Chen
Cc: Stephen Rothwell, Yi Liu, Linux Kernel Mailing List,
Linux Next Mailing List
On Thu, Mar 30, 2023 at 10:09:38PM -0700, Nicolin Chen wrote:
> Thanks for reporting.
>
> On Fri, Mar 31, 2023 at 03:31:46PM +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the iommufd tree, today's linux-next build (htmldocs)
> > produced this warning:
> >
> > drivers/iommu/iommufd/device.c:674: warning: Excess function parameter 'ioas_id' description in 'iommufd_access_create'
> >
> > Introduced by commits
> >
> > 7540af571dc7 ("iommufd: Create access in vfio_iommufd_emulated_bind()")
>
> Should have dropped that line from kdoc in this commit.
>
> diff --git a/drivers/iommu/iommufd/device.c b/drivers/iommu/iommufd/device.c
> index fca09bb4e839..d791ab5830b4 100644
> --- a/drivers/iommu/iommufd/device.c
> +++ b/drivers/iommu/iommufd/device.c
> @@ -795,7 +795,6 @@ void iommufd_access_destroy_object(struct iommufd_object *obj)
> /**
> * iommufd_access_create - Create an iommufd_access
> * @ictx: iommufd file descriptor
> - * @ioas_id: ID for a IOMMUFD_OBJ_IOAS
> * @ops: Driver's ops to associate with the access
> * @data: Opaque data to pass into ops functions
> *
Got it thanks
Jason
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build warning after merge of the iommufd tree
2023-03-31 4:41 Stephen Rothwell
@ 2023-03-31 17:45 ` Jason Gunthorpe
0 siblings, 0 replies; 6+ messages in thread
From: Jason Gunthorpe @ 2023-03-31 17:45 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
On Fri, Mar 31, 2023 at 03:41:02PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the iommufd tree, today's linux-next build (htmldocs)
> produced this warning:
>
> Documentation/userspace-api/iommufd:184: drivers/iommu/iommufd/device.c:613: WARNING: Definition list ends without a blank line; unexpected unindent.
>
> Introduced by commit
>
> e8b57a50334c ("iommufd: Add iommufd_device_replace()")
Got it, thanks
Jason
^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: build warning after merge of the iommufd tree
@ 2023-03-31 4:41 Stephen Rothwell
2023-03-31 17:45 ` Jason Gunthorpe
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2023-03-31 4:41 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: Jason Gunthorpe, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 375 bytes --]
Hi all,
After merging the iommufd tree, today's linux-next build (htmldocs)
produced this warning:
Documentation/userspace-api/iommufd:184: drivers/iommu/iommufd/device.c:613: WARNING: Definition list ends without a blank line; unexpected unindent.
Introduced by commit
e8b57a50334c ("iommufd: Add iommufd_device_replace()")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: build warning after merge of the iommufd tree
@ 2022-11-08 5:51 Stephen Rothwell
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2022-11-08 5:51 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: Jason Gunthorpe, Nicolin Chen, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 323 bytes --]
Hi all,
After merging the iommufd tree, today's linux-next build (htmldocs)
produced this warning:
include/uapi/linux/iommufd.h:277: warning: Cannot understand * @size: sizeof(struct iommu_option)
Introduced by commit
5a013b3b3b2f ("iommufd: IOCTLs for the io_pagetable")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-03-31 17:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-31 4:31 linux-next: build warning after merge of the iommufd tree Stephen Rothwell
2023-03-31 5:09 ` Nicolin Chen
2023-03-31 17:44 ` Jason Gunthorpe
-- strict thread matches above, loose matches on Subject: below --
2023-03-31 4:41 Stephen Rothwell
2023-03-31 17:45 ` Jason Gunthorpe
2022-11-08 5:51 Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).