From: Rob Herring <robh@kernel.org>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Cc: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
kernel@collabora.com, linux-arm-kernel@lists.infradead.org,
linux-hwmon@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
Jean Delvare <jdelvare@suse.com>,
Heiko Stuebner <heiko@sntech.de>,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: pwm-fan: Convert to DT schema
Date: Tue, 4 Apr 2023 08:54:59 -0500 [thread overview]
Message-ID: <20230404135459.GA3793612-robh@kernel.org> (raw)
In-Reply-To: <49c226ff-08a3-a7ca-59bd-f0b9cea865e3@collabora.com>
On Mon, Apr 03, 2023 at 07:22:45PM +0300, Cristian Ciocaltea wrote:
> On 4/3/23 17:43, AngeloGioacchino Del Regno wrote:
> > Il 03/04/23 16:32, Cristian Ciocaltea ha scritto:
> >> On 4/3/23 16:10, Rob Herring wrote:
> >>>
> >>> On Mon, 03 Apr 2023 13:50:51 +0300, Cristian Ciocaltea wrote:
> >>>> Convert the PWM fan bindings to DT schema format.
> >>>>
> >>>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> >>>> ---
> >>>> .../devicetree/bindings/hwmon/pwm-fan.txt | 68 +----------
> >>>> .../devicetree/bindings/hwmon/pwm-fan.yaml | 109
> >>>> ++++++++++++++++++
> >>>> 2 files changed, 110 insertions(+), 67 deletions(-)
> >>>> create mode 100644
> >>>> Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
> >>>>
> >>>
> >>> Running 'make dtbs_check' with the schema in this patch gives the
> >>> following warnings. Consider if they are expected or the schema is
> >>> incorrect. These may not be new warnings.
> >>>
> >>> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> >>> This will change in the future.
> >>>
> >>> Full log is available here:
> >>> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230403105052.426135-2-cristian.ciocaltea@collabora.com
> >>>
> >>>
> >>> pwm-fan: 'cooling-max-state', 'cooling-min-state' do not match any of
> >>> the regexes: 'pinctrl-[0-9]+'
> >>> arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dtb
> >>> arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dtb
> >>>
> >>
> >> The only references to the offending cooling-{min|max}-state are located
> >> in a few DTS files. Assuming they are obsolete, may I simply drop them?
> >>
> >
> > If they're obsolete, you can mark them as `deprecated: true` in the
> > binding, but
> > dropping them entirely would be an ABI breakage, so no, you can't.
>
> >From the pwm-fan driver point of view, the properties are not supported
> and I couldn't find any indication that they could have been used in the
> past.
>
> Hence I'm not sure adding them to the binding is the proper way to
> handle this issue.
They can be omitted.
Rob
next prev parent reply other threads:[~2023-04-04 13:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 10:50 [PATCH 0/2] Add PWM fan support to Rock 5B board Cristian Ciocaltea
2023-04-03 10:50 ` [PATCH 1/2] dt-bindings: hwmon: pwm-fan: Convert to DT schema Cristian Ciocaltea
2023-04-03 13:10 ` Rob Herring
2023-04-03 14:32 ` Cristian Ciocaltea
2023-04-03 14:43 ` AngeloGioacchino Del Regno
2023-04-03 16:22 ` Cristian Ciocaltea
2023-04-04 13:54 ` Rob Herring [this message]
2023-04-04 14:17 ` Rob Herring
2023-04-04 14:22 ` Guenter Roeck
2023-04-04 16:32 ` Cristian Ciocaltea
2023-04-03 10:50 ` [PATCH 2/2] arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan Cristian Ciocaltea
2023-04-03 17:56 ` Chris Morgan
2023-04-03 19:27 ` Peter Geis
2023-04-03 21:55 ` Heiko Stübner
2023-04-04 7:06 ` Cristian Ciocaltea
2023-04-04 8:56 ` Christopher Obbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230404135459.GA3793612-robh@kernel.org \
--to=robh@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=cristian.ciocaltea@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jdelvare@suse.com \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).