From: "Heiko Stübner" <heiko@sntech.de>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
Chris Morgan <macroalpha82@gmail.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan
Date: Mon, 03 Apr 2023 23:55:17 +0200 [thread overview]
Message-ID: <4981873.LvFx2qVVIh@diego> (raw)
In-Reply-To: <642b134c.4a0a0220.1d01a.5990@mx.google.com>
Am Montag, 3. April 2023, 19:56:26 CEST schrieb Chris Morgan:
> On Mon, Apr 03, 2023 at 01:50:52PM +0300, Cristian Ciocaltea wrote:
> > Add the necessary DT changes for the Rock 5B board to enable support for
> > the PWM controlled heat sink fan.
>
> Honest question, but should we be adding this to the board file if not
> every device has a PWM fan (they all have the socket for the fan, but
> not the fan)? For example I have a passively cooled case that doesn't
> include a fan.
We also set up the sdmmc host without knowing if the user will plug in
an sd-card ;-) .
So especially in the case where there is a dedicated socket for it,
as you write, we should definitly add it for the board.
By the way, am I correct in thinking that patch 1 and 2 are actually
independent of each other? So I'd just pick patch2 for the Rockchip tree
(as we do have a text-binding) and you can handle the yaml conversion
in a followup or whatever?
Thanks
Heiko
next prev parent reply other threads:[~2023-04-03 21:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 10:50 [PATCH 0/2] Add PWM fan support to Rock 5B board Cristian Ciocaltea
2023-04-03 10:50 ` [PATCH 1/2] dt-bindings: hwmon: pwm-fan: Convert to DT schema Cristian Ciocaltea
2023-04-03 13:10 ` Rob Herring
2023-04-03 14:32 ` Cristian Ciocaltea
2023-04-03 14:43 ` AngeloGioacchino Del Regno
2023-04-03 16:22 ` Cristian Ciocaltea
2023-04-04 13:54 ` Rob Herring
2023-04-04 14:17 ` Rob Herring
2023-04-04 14:22 ` Guenter Roeck
2023-04-04 16:32 ` Cristian Ciocaltea
2023-04-03 10:50 ` [PATCH 2/2] arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan Cristian Ciocaltea
2023-04-03 17:56 ` Chris Morgan
2023-04-03 19:27 ` Peter Geis
2023-04-03 21:55 ` Heiko Stübner [this message]
2023-04-04 7:06 ` Cristian Ciocaltea
2023-04-04 8:56 ` Christopher Obbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4981873.LvFx2qVVIh@diego \
--to=heiko@sntech.de \
--cc=cristian.ciocaltea@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=macroalpha82@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).