* [PATCH] module: stats: fix invalid_mod_bytes typo
@ 2023-04-18 7:17 Arnd Bergmann
2023-04-18 14:20 ` Randy Dunlap
2023-04-18 15:40 ` Luis Chamberlain
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2023-04-18 7:17 UTC (permalink / raw)
To: Luis Chamberlain; +Cc: Arnd Bergmann, linux-modules, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
This was caught by randconfig builds but does not show up in
build testing without CONFIG_MODULE_DECOMPRESS:
kernel/module/stats.c: In function 'mod_stat_bump_invalid':
kernel/module/stats.c:229:42: error: 'invalid_mod_byte' undeclared (first use in this function); did you mean 'invalid_mod_bytes'?
229 | atomic_long_add(info->compressed_len, &invalid_mod_byte);
| ^~~~~~~~~~~~~~~~
| invalid_mod_bytes
Fixes: 0d4ab68ce983 ("module: add debug stats to help identify memory pressure")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
This was probably already reported, sending the fix just in case everyone
else else missed it so far.
---
kernel/module/stats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/module/stats.c b/kernel/module/stats.c
index cdcd60695399..32959ec9581f 100644
--- a/kernel/module/stats.c
+++ b/kernel/module/stats.c
@@ -226,7 +226,7 @@ void mod_stat_bump_invalid(struct load_info *info, int flags)
atomic_inc(&failed_load_modules);
#if defined(CONFIG_MODULE_DECOMPRESS)
if (flags & MODULE_INIT_COMPRESSED_FILE)
- atomic_long_add(info->compressed_len, &invalid_mod_byte);
+ atomic_long_add(info->compressed_len, &invalid_mod_bytes);
#endif
}
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] module: stats: fix invalid_mod_bytes typo
2023-04-18 7:17 [PATCH] module: stats: fix invalid_mod_bytes typo Arnd Bergmann
@ 2023-04-18 14:20 ` Randy Dunlap
2023-04-18 15:40 ` Luis Chamberlain
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2023-04-18 14:20 UTC (permalink / raw)
To: Arnd Bergmann, Luis Chamberlain
Cc: Arnd Bergmann, linux-modules, linux-kernel
On 4/18/23 00:17, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This was caught by randconfig builds but does not show up in
> build testing without CONFIG_MODULE_DECOMPRESS:
>
> kernel/module/stats.c: In function 'mod_stat_bump_invalid':
> kernel/module/stats.c:229:42: error: 'invalid_mod_byte' undeclared (first use in this function); did you mean 'invalid_mod_bytes'?
> 229 | atomic_long_add(info->compressed_len, &invalid_mod_byte);
> | ^~~~~~~~~~~~~~~~
> | invalid_mod_bytes
>
> Fixes: 0d4ab68ce983 ("module: add debug stats to help identify memory pressure")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> This was probably already reported, sending the fix just in case everyone
> else else missed it so far.
> ---
> kernel/module/stats.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/module/stats.c b/kernel/module/stats.c
> index cdcd60695399..32959ec9581f 100644
> --- a/kernel/module/stats.c
> +++ b/kernel/module/stats.c
> @@ -226,7 +226,7 @@ void mod_stat_bump_invalid(struct load_info *info, int flags)
> atomic_inc(&failed_load_modules);
> #if defined(CONFIG_MODULE_DECOMPRESS)
> if (flags & MODULE_INIT_COMPRESSED_FILE)
> - atomic_long_add(info->compressed_len, &invalid_mod_byte);
> + atomic_long_add(info->compressed_len, &invalid_mod_bytes);
> #endif
> }
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] module: stats: fix invalid_mod_bytes typo
2023-04-18 7:17 [PATCH] module: stats: fix invalid_mod_bytes typo Arnd Bergmann
2023-04-18 14:20 ` Randy Dunlap
@ 2023-04-18 15:40 ` Luis Chamberlain
1 sibling, 0 replies; 3+ messages in thread
From: Luis Chamberlain @ 2023-04-18 15:40 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Arnd Bergmann, linux-modules, linux-kernel
On Tue, Apr 18, 2023 at 09:17:51AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This was caught by randconfig builds but does not show up in
> build testing without CONFIG_MODULE_DECOMPRESS:
>
> kernel/module/stats.c: In function 'mod_stat_bump_invalid':
> kernel/module/stats.c:229:42: error: 'invalid_mod_byte' undeclared (first use in this function); did you mean 'invalid_mod_bytes'?
> 229 | atomic_long_add(info->compressed_len, &invalid_mod_byte);
> | ^~~~~~~~~~~~~~~~
> | invalid_mod_bytes
>
> Fixes: 0d4ab68ce983 ("module: add debug stats to help identify memory pressure")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> This was probably already reported, sending the fix just in case everyone
> else else missed it so far.
Oh it was a decompression ifdef, that's why I didn't catch it! But also
I guess 0-day isn't running tests with it enabled either!
Thanks! Applied and pushed!
Luis
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-18 15:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-18 7:17 [PATCH] module: stats: fix invalid_mod_bytes typo Arnd Bergmann
2023-04-18 14:20 ` Randy Dunlap
2023-04-18 15:40 ` Luis Chamberlain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).