[PATCH] qedf: Fix NULL dereference in error handling

* [PATCH] qedf: Fix NULL dereference in error handling
@ 2023-04-17 13:55 Jinhong Zhu
  2023-04-25  3:41 ` Martin K. Petersen
  2023-05-02 14:15 ` Jinhong Zhu
  0 siblings, 2 replies; 5+ messages in thread
From: Jinhong Zhu @ 2023-04-17 13:55 UTC (permalink / raw)
  To: Saurav Kashyap, Javed Hasan, GR-QLogic-Storage-Upstream,
	James E.J. Bottomley, Martin K. Petersen, Jinhong Zhu
  Cc: Dan Carpenter, linux-scsi, linux-kernel

Smatch reported:

drivers/scsi/qedf/qedf_main.c:3056 qedf_alloc_global_queues()
warn: missing unwind goto?

At this point in the function, nothing has been allocated so we can
return directly. In particular the "qedf->global_queues" have not been
allocated so calling qedf_free_global_queues() will lead to a NULL
dereference when we check if (!gl[i]) and "gl" is NULL.

Fixes: 09e062ce83cb ("qedf: Fix NULL dereference in error handling")
Signed-off-by: Jinhong Zhu <jinhongzhu@hust.edu.cn>
Reviewed-by: Dan Carpenter <error27@gmail.com>
---
 drivers/scsi/qedf/qedf_main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index 35e16600fc63..f2c7dd4db9c6 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -3043,9 +3043,8 @@ static int qedf_alloc_global_queues(struct qedf_ctx *qedf)
 	 * addresses of our queues
 	 */
 	if (!qedf->p_cpuq) {
-		status = -EINVAL;
 		QEDF_ERR(&qedf->dbg_ctx, "p_cpuq is NULL.\n");
-		goto mem_alloc_failure;
+		return -EINVAL;
 	}
 
 	qedf->global_queues = kzalloc((sizeof(struct global_queue *)
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread