linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] docs: move tracing tools
@ 2023-04-25 13:02 Costa Shulyupin
  2023-04-25 17:48 ` Steven Rostedt
  0 siblings, 1 reply; 3+ messages in thread
From: Costa Shulyupin @ 2023-04-25 13:02 UTC (permalink / raw)
  To: Jonathan Corbet, linux-doc
  Cc: Costa Shulyupin, Steven Rostedt (Google),
	Daniel Bristot de Oliveira, open list

from list of development tools to user tools
because these tools work on running kernel
and are invoked from user mode

Signed-off-by: Costa Shulyupin <costa.shul@redhat.com>
---
 Documentation/index.rst       | 1 -
 Documentation/tools/index.rst | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/index.rst b/Documentation/index.rst
index 9dfdc826618c..81e1af951731 100644
--- a/Documentation/index.rst
+++ b/Documentation/index.rst
@@ -56,7 +56,6 @@ Various other manuals with useful information for all kernel developers.
    dev-tools/index
    dev-tools/testing-overview
    kernel-hacking/index
-   trace/index
    fault-injection/index
    livepatch/index
    rust/index
diff --git a/Documentation/tools/index.rst b/Documentation/tools/index.rst
index 80488e290e10..6a9a44f7f88a 100644
--- a/Documentation/tools/index.rst
+++ b/Documentation/tools/index.rst
@@ -12,6 +12,7 @@ more additions are needed here:
 
    rtla/index
    rv/index
+   ../trace/index
 
 .. only::  subproject and html
 
-- 
2.40.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] docs: move tracing tools
  2023-04-25 13:02 [PATCH] docs: move tracing tools Costa Shulyupin
@ 2023-04-25 17:48 ` Steven Rostedt
  2023-04-26  9:06   ` Daniel Bristot de Oliveira
  0 siblings, 1 reply; 3+ messages in thread
From: Steven Rostedt @ 2023-04-25 17:48 UTC (permalink / raw)
  To: Costa Shulyupin
  Cc: Jonathan Corbet, linux-doc, Daniel Bristot de Oliveira, open list

On Tue, 25 Apr 2023 16:02:30 +0300
Costa Shulyupin <costa.shul@redhat.com> wrote:

> from list of development tools to user tools
> because these tools work on running kernel
> and are invoked from user mode

Wait what? No!

The trace/ directory has a lot that is kernel internal only. Yes, it may
explain how user space can interact with it, but it's also how internal
kernel processes can use the ftrace infrastructure, and also explains a lot
of the kernel design of that code.

NACK!

-- Steve


> 
> Signed-off-by: Costa Shulyupin <costa.shul@redhat.com>
> ---
>  Documentation/index.rst       | 1 -
>  Documentation/tools/index.rst | 1 +
>  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/index.rst b/Documentation/index.rst
> index 9dfdc826618c..81e1af951731 100644
> --- a/Documentation/index.rst
> +++ b/Documentation/index.rst
> @@ -56,7 +56,6 @@ Various other manuals with useful information for all kernel developers.
>     dev-tools/index
>     dev-tools/testing-overview
>     kernel-hacking/index
> -   trace/index
>     fault-injection/index
>     livepatch/index
>     rust/index
> diff --git a/Documentation/tools/index.rst b/Documentation/tools/index.rst
> index 80488e290e10..6a9a44f7f88a 100644
> --- a/Documentation/tools/index.rst
> +++ b/Documentation/tools/index.rst
> @@ -12,6 +12,7 @@ more additions are needed here:
>  
>     rtla/index
>     rv/index
> +   ../trace/index
>  
>  .. only::  subproject and html
>  


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] docs: move tracing tools
  2023-04-25 17:48 ` Steven Rostedt
@ 2023-04-26  9:06   ` Daniel Bristot de Oliveira
  0 siblings, 0 replies; 3+ messages in thread
From: Daniel Bristot de Oliveira @ 2023-04-26  9:06 UTC (permalink / raw)
  To: Steven Rostedt, Costa Shulyupin; +Cc: Jonathan Corbet, linux-doc, open list

On 4/25/23 19:48, Steven Rostedt wrote:
> On Tue, 25 Apr 2023 16:02:30 +0300
> Costa Shulyupin <costa.shul@redhat.com> wrote:
> 
>> from list of development tools to user tools
>> because these tools work on running kernel
>> and are invoked from user mode
> Wait what? No!
> 
> The trace/ directory has a lot that is kernel internal only. Yes, it may
> explain how user space can interact with it, but it's also how internal
> kernel processes can use the ftrace infrastructure, and also explains a lot
> of the kernel design of that code.
> 
> NACK!

NACK++

-- Daniel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-04-26  9:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-25 13:02 [PATCH] docs: move tracing tools Costa Shulyupin
2023-04-25 17:48 ` Steven Rostedt
2023-04-26  9:06   ` Daniel Bristot de Oliveira

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).