From: Bjorn Helgaas <helgaas@kernel.org>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Hans de Goede <hdegoede@redhat.com>,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
Sanket Goswami <Sanket.Goswami@amd.com>,
Richard gong <richard.gong@amd.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/2] amd_nb: Add PCI ID for family 19h model 78h
Date: Thu, 27 Apr 2023 11:46:51 -0500 [thread overview]
Message-ID: <20230427164651.GA255475@bhelgaas> (raw)
In-Reply-To: <20230427053338.16653-2-mario.limonciello@amd.com>
On Thu, Apr 27, 2023 at 12:33:36AM -0500, Mario Limonciello wrote:
> s2idle previously worked on this system, but it regressed in kernel
> 6.4 due to commit 310e782a99c7 ("platform/x86/amd: pmc: Utilize SMN
> index 0 for driver probe").
>
> The reason for the regression is that before this commit the SMN
> communication was hardcoded, but after amd_smn_read() is used which
> relies upon the misc PCI ID used by DF function 3 being included in
> a table. The ID was missing for model 78h, so this meant that the
> amd_smn_read() wouldn't work.
>
> Add the missing ID into amd_nb, restoring s2idle on this system.
Is there a long-term solution for this that will not require adding
new IDs every time new hardware comes out?
drivers/platform/x86/amd/pmc.c already matches ACPI IDs; maybe there's
some way for the platform to provide the information you need via
ACPI or something?
Bjorn
next prev parent reply other threads:[~2023-04-27 16:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 5:33 [PATCH 0/2] Regression in s2idle for family 19h model 78h Mario Limonciello
2023-04-27 5:33 ` [PATCH 1/2] amd_nb: Add PCI ID " Mario Limonciello
2023-04-27 16:46 ` Bjorn Helgaas [this message]
2023-04-27 16:50 ` Limonciello, Mario
2023-04-27 16:48 ` Bjorn Helgaas
2023-05-08 8:52 ` Borislav Petkov
2023-05-06 14:05 ` Guenter Roeck
2023-05-07 12:51 ` Mario Limonciello
2023-05-08 11:13 ` Thorsten Leemhuis
2023-05-08 11:25 ` Borislav Petkov
2023-05-08 13:28 ` Guenter Roeck
2023-05-08 13:44 ` Borislav Petkov
2023-05-11 19:51 ` Limonciello, Mario
2023-05-11 20:09 ` Thorsten Leemhuis
2023-05-11 21:50 ` Sasha Levin
2023-05-15 12:26 ` Greg KH
2023-05-08 9:40 ` [tip: x86/urgent] x86/amd_nb: " tip-bot2 for Mario Limonciello
2023-04-27 5:33 ` [PATCH 2/2] k10temp: Add pci ID for family 19, " Mario Limonciello
2023-04-27 9:52 ` Guenter Roeck
2023-05-08 9:40 ` [tip: x86/urgent] hwmon: (k10temp) Add PCI " tip-bot2 for Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230427164651.GA255475@bhelgaas \
--to=helgaas@kernel.org \
--cc=Sanket.Goswami@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mingo@redhat.com \
--cc=richard.gong@amd.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).