From: "Limonciello, Mario" <Mario.Limonciello@amd.com>
To: Sasha Levin <sashal@kernel.org>
Cc: Thorsten Leemhuis <linux@leemhuis.info>,
Linux regressions mailing list <regressions@lists.linux.dev>,
Bjorn Helgaas <bhelgaas@google.com>,
Hans de Goede <hdegoede@redhat.com>,
"S-k, Shyam-sundar" <Shyam-sundar.S-k@amd.com>,
"Goswami, Sanket" <Sanket.Goswami@amd.com>,
"Gong, Richard" <Richard.Gong@amd.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Borislav Petkov <bp@alien8.de>,
Guenter Roeck <linux@roeck-us.net>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH 1/2] amd_nb: Add PCI ID for family 19h model 78h
Date: Thu, 11 May 2023 19:51:42 +0000 [thread overview]
Message-ID: <MN0PR12MB610132F2277B0F1DB1039A15E2749@MN0PR12MB6101.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230508134414.GCZFj8rieNwF1AOerB@fat_crate.local>
[AMD Official Use Only - General]
+stable, Sasha
> > Together with this patch there are now at least two regressions if
> > -rc1 whch could have been avoided and may impact testability on
> > affected systems.
>
> Are you saying that this patch which fixes s2idle on some random box
> should've gone to Linus *immediately*?
>
> And read my mail again:
>
> "Some fixes need longer testing because there have been cases where
> a fix breaks something else."
>
> So yes, I disagree with rushing fixes immediately. If they're obvious
> - whatever that means - then sure but not all of them are such.
>
> --
Unfortunately, it looks like the broken commit got backported into 6.1.28,
but the fix still isn't in Linus' tree.
Sasha,
Can you please pick up
https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/urgent&id=23a5b8bb022c1e071ca91b1a9c10f0ad6a0966e9
for 6.1.29 to fix the regression?
Thanks,
next prev parent reply other threads:[~2023-05-11 19:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 5:33 [PATCH 0/2] Regression in s2idle for family 19h model 78h Mario Limonciello
2023-04-27 5:33 ` [PATCH 1/2] amd_nb: Add PCI ID " Mario Limonciello
2023-04-27 16:46 ` Bjorn Helgaas
2023-04-27 16:50 ` Limonciello, Mario
2023-04-27 16:48 ` Bjorn Helgaas
2023-05-08 8:52 ` Borislav Petkov
2023-05-06 14:05 ` Guenter Roeck
2023-05-07 12:51 ` Mario Limonciello
2023-05-08 11:13 ` Thorsten Leemhuis
2023-05-08 11:25 ` Borislav Petkov
2023-05-08 13:28 ` Guenter Roeck
2023-05-08 13:44 ` Borislav Petkov
2023-05-11 19:51 ` Limonciello, Mario [this message]
2023-05-11 20:09 ` Thorsten Leemhuis
2023-05-11 21:50 ` Sasha Levin
2023-05-15 12:26 ` Greg KH
2023-05-08 9:40 ` [tip: x86/urgent] x86/amd_nb: " tip-bot2 for Mario Limonciello
2023-04-27 5:33 ` [PATCH 2/2] k10temp: Add pci ID for family 19, " Mario Limonciello
2023-04-27 9:52 ` Guenter Roeck
2023-05-08 9:40 ` [tip: x86/urgent] hwmon: (k10temp) Add PCI " tip-bot2 for Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN0PR12MB610132F2277B0F1DB1039A15E2749@MN0PR12MB6101.namprd12.prod.outlook.com \
--to=mario.limonciello@amd.com \
--cc=Richard.Gong@amd.com \
--cc=Sanket.Goswami@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=linux@roeck-us.net \
--cc=mingo@redhat.com \
--cc=regressions@lists.linux.dev \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).