* [PATCH v2 0/2] drm/panel: panel-simple: Add BOE EV121WXM-N10-1850 panel support
@ 2023-05-08 8:38 Liu Ying
2023-05-08 8:38 ` [PATCH v2 1/2] dt-bindings: display: simple: Add BOE EV121WXM-N10-1850 panel Liu Ying
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Liu Ying @ 2023-05-08 8:38 UTC (permalink / raw)
To: dri-devel, devicetree, linux-kernel
Cc: neil.armstrong, sam, airlied, daniel, robh+dt,
krzysztof.kozlowski+dt, conor+dt, thierry.reding, linux-imx,
krzysztof.kozlowski
Hi,
This patch series aims to add BOE EV121WXM-N10-1850 panel support
in the DRM simple panel driver.
Patch 1/2 adds dt-bindings support for the panel.
Patch 2/2 adds the panel support in the DRM simple panel driver.
v1->v2:
* Add Krzysztof's A-b tag on patch 1/2.
* Use struct display_timing in patch 2/2 to tell minimum and maximum
pixel clock rates.
* Set bus_flags to DRM_BUS_FLAG_DE_HIGH in struct panel_desc in patch 2/2.
Liu Ying (2):
dt-bindings: display: simple: Add BOE EV121WXM-N10-1850 panel
drm/panel: panel-simple: Add BOE EV121WXM-N10-1850 panel support
.../bindings/display/panel/panel-simple.yaml | 2 ++
drivers/gpu/drm/panel/panel-simple.c | 34 +++++++++++++++++++
2 files changed, 36 insertions(+)
--
2.37.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 1/2] dt-bindings: display: simple: Add BOE EV121WXM-N10-1850 panel
2023-05-08 8:38 [PATCH v2 0/2] drm/panel: panel-simple: Add BOE EV121WXM-N10-1850 panel support Liu Ying
@ 2023-05-08 8:38 ` Liu Ying
2023-05-08 9:27 ` Rob Herring
2023-05-08 8:38 ` [PATCH v2 2/2] drm/panel: panel-simple: Add BOE EV121WXM-N10-1850 panel support Liu Ying
2023-05-11 8:48 ` [PATCH v2 0/2] " Neil Armstrong
2 siblings, 1 reply; 7+ messages in thread
From: Liu Ying @ 2023-05-08 8:38 UTC (permalink / raw)
To: dri-devel, devicetree, linux-kernel
Cc: neil.armstrong, sam, airlied, daniel, robh+dt,
krzysztof.kozlowski+dt, conor+dt, thierry.reding, linux-imx,
krzysztof.kozlowski
Add BOE EV121WXM-N10-1850 12.1" WXGA (1280x800) TFT LCD panel
compatible string. The panel has a LVDS display interface.
The panel's product specification can be found at:
http://www.onetech.com.tw/files/EV121WXM-N10-1850ProductSpecification_20180801.pdf
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
v1->v2:
* Add Krzysztof's A-b tag.
.../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index 01560fe226dd..b9dbc5bb065d 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -77,6 +77,8 @@ properties:
- auo,t215hvn01
# Shanghai AVIC Optoelectronics 7" 1024x600 color TFT-LCD panel
- avic,tm070ddh03
+ # BOE EV121WXM-N10-1850 12.1" WXGA (1280x800) TFT LCD panel
+ - boe,ev121wxm-n10-1850
# BOE HV070WSA-100 7.01" WSVGA TFT LCD panel
- boe,hv070wsa-100
# BOE OPTOELECTRONICS TECHNOLOGY 10.1" WXGA TFT LCD panel
--
2.37.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 2/2] drm/panel: panel-simple: Add BOE EV121WXM-N10-1850 panel support
2023-05-08 8:38 [PATCH v2 0/2] drm/panel: panel-simple: Add BOE EV121WXM-N10-1850 panel support Liu Ying
2023-05-08 8:38 ` [PATCH v2 1/2] dt-bindings: display: simple: Add BOE EV121WXM-N10-1850 panel Liu Ying
@ 2023-05-08 8:38 ` Liu Ying
2023-05-09 7:49 ` neil.armstrong
2023-05-11 8:48 ` [PATCH v2 0/2] " Neil Armstrong
2 siblings, 1 reply; 7+ messages in thread
From: Liu Ying @ 2023-05-08 8:38 UTC (permalink / raw)
To: dri-devel, devicetree, linux-kernel
Cc: neil.armstrong, sam, airlied, daniel, robh+dt,
krzysztof.kozlowski+dt, conor+dt, thierry.reding, linux-imx,
krzysztof.kozlowski
Add BOE EV121WXM-N10-1850 12.1" WXGA (1280x800) TFT LCD panel support.
The panel has a LVDS display interface.
The panel's product specification can be found at:
http://www.onetech.com.tw/files/EV121WXM-N10-1850ProductSpecification_20180801.pdf
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
v1->v2:
* Use struct display_timing to tell minimum and maximum pixel clock rates.
* Set bus_flags to DRM_BUS_FLAG_DE_HIGH in struct panel_desc.
drivers/gpu/drm/panel/panel-simple.c | 34 ++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 065f378bba9d..b1590a7e2cda 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1211,6 +1211,37 @@ static const struct panel_desc bananapi_s070wv20_ct16 = {
},
};
+static const struct display_timing boe_ev121wxm_n10_1850_timing = {
+ .pixelclock = { 69922000, 71000000, 72293000 },
+ .hactive = { 1280, 1280, 1280 },
+ .hfront_porch = { 48, 48, 48 },
+ .hback_porch = { 80, 80, 80 },
+ .hsync_len = { 32, 32, 32 },
+ .vactive = { 800, 800, 800 },
+ .vfront_porch = { 3, 3, 3 },
+ .vback_porch = { 14, 14, 14 },
+ .vsync_len = { 6, 6, 6 },
+};
+
+static const struct panel_desc boe_ev121wxm_n10_1850 = {
+ .timings = &boe_ev121wxm_n10_1850_timing,
+ .num_timings = 1,
+ .bpc = 8,
+ .size = {
+ .width = 261,
+ .height = 163,
+ },
+ .delay = {
+ .prepare = 9,
+ .enable = 300,
+ .unprepare = 300,
+ .disable = 560,
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+ .bus_flags = DRM_BUS_FLAG_DE_HIGH,
+ .connector_type = DRM_MODE_CONNECTOR_LVDS,
+};
+
static const struct drm_display_mode boe_hv070wsa_mode = {
.clock = 42105,
.hdisplay = 1024,
@@ -3984,6 +4015,9 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "bananapi,s070wv20-ct16",
.data = &bananapi_s070wv20_ct16,
+ }, {
+ .compatible = "boe,ev121wxm-n10-1850",
+ .data = &boe_ev121wxm_n10_1850,
}, {
.compatible = "boe,hv070wsa-100",
.data = &boe_hv070wsa
--
2.37.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: display: simple: Add BOE EV121WXM-N10-1850 panel
2023-05-08 8:38 ` [PATCH v2 1/2] dt-bindings: display: simple: Add BOE EV121WXM-N10-1850 panel Liu Ying
@ 2023-05-08 9:27 ` Rob Herring
2023-05-08 10:13 ` Krzysztof Kozlowski
0 siblings, 1 reply; 7+ messages in thread
From: Rob Herring @ 2023-05-08 9:27 UTC (permalink / raw)
To: Liu Ying
Cc: thierry.reding, linux-kernel, krzysztof.kozlowski+dt,
krzysztof.kozlowski, neil.armstrong, robh+dt, conor+dt, daniel,
sam, devicetree, airlied, dri-devel, linux-imx
On Mon, 08 May 2023 16:38:25 +0800, Liu Ying wrote:
> Add BOE EV121WXM-N10-1850 12.1" WXGA (1280x800) TFT LCD panel
> compatible string. The panel has a LVDS display interface.
>
> The panel's product specification can be found at:
> http://www.onetech.com.tw/files/EV121WXM-N10-1850ProductSpecification_20180801.pdf
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
> v1->v2:
> * Add Krzysztof's A-b tag.
>
> .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.example.dtb: pcie-ep@33800000: Unevaluated properties are not allowed ('assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks' were unexpected)
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: camera@3c: port:endpoint:data-lanes: [[1]] is too short
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.example.dtb: camera-sensor@3c: port:endpoint:data-lanes: [[1]] is too short
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml
doc reference errors (make refcheckdocs):
Documentation/usb/gadget_uvc.rst: Documentation/userspace-api/media/v4l/pixfmt-packed.yuv.rst
MAINTAINERS: Documentation/devicetree/bindings/pwm/pwm-apple.yaml
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230508083826.1016206-2-victor.liu@nxp.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: display: simple: Add BOE EV121WXM-N10-1850 panel
2023-05-08 9:27 ` Rob Herring
@ 2023-05-08 10:13 ` Krzysztof Kozlowski
0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-08 10:13 UTC (permalink / raw)
To: Rob Herring, Liu Ying
Cc: thierry.reding, linux-kernel, krzysztof.kozlowski+dt,
neil.armstrong, robh+dt, conor+dt, daniel, sam, devicetree,
airlied, dri-devel, linux-imx
On 08/05/2023 11:27, Rob Herring wrote:
>
> On Mon, 08 May 2023 16:38:25 +0800, Liu Ying wrote:
>> Add BOE EV121WXM-N10-1850 12.1" WXGA (1280x800) TFT LCD panel
>> compatible string. The panel has a LVDS display interface.
>>
>> The panel's product specification can be found at:
>> http://www.onetech.com.tw/files/EV121WXM-N10-1850ProductSpecification_20180801.pdf
>>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Signed-off-by: Liu Ying <victor.liu@nxp.com>
>> ---
>> v1->v2:
>> * Add Krzysztof's A-b tag.
>>
>> .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.example.dtb: pcie-ep@33800000: Unevaluated properties are not allowed ('assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks' were unexpected)
> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: camera@3c: port:endpoint:data-lanes: [[1]] is too short
> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.example.dtb: camera-sensor@3c: port:endpoint:data-lanes: [[1]] is too short
> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml
Warnings are unrelated, can be ignored.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/2] drm/panel: panel-simple: Add BOE EV121WXM-N10-1850 panel support
2023-05-08 8:38 ` [PATCH v2 2/2] drm/panel: panel-simple: Add BOE EV121WXM-N10-1850 panel support Liu Ying
@ 2023-05-09 7:49 ` neil.armstrong
0 siblings, 0 replies; 7+ messages in thread
From: neil.armstrong @ 2023-05-09 7:49 UTC (permalink / raw)
To: Liu Ying, dri-devel, devicetree, linux-kernel
Cc: sam, airlied, daniel, robh+dt, krzysztof.kozlowski+dt, conor+dt,
thierry.reding, linux-imx, krzysztof.kozlowski
On 08/05/2023 10:38, Liu Ying wrote:
> Add BOE EV121WXM-N10-1850 12.1" WXGA (1280x800) TFT LCD panel support.
> The panel has a LVDS display interface.
>
> The panel's product specification can be found at:
> http://www.onetech.com.tw/files/EV121WXM-N10-1850ProductSpecification_20180801.pdf
>
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
> v1->v2:
> * Use struct display_timing to tell minimum and maximum pixel clock rates.
> * Set bus_flags to DRM_BUS_FLAG_DE_HIGH in struct panel_desc.
>
> drivers/gpu/drm/panel/panel-simple.c | 34 ++++++++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 065f378bba9d..b1590a7e2cda 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1211,6 +1211,37 @@ static const struct panel_desc bananapi_s070wv20_ct16 = {
> },
> };
>
> +static const struct display_timing boe_ev121wxm_n10_1850_timing = {
> + .pixelclock = { 69922000, 71000000, 72293000 },
> + .hactive = { 1280, 1280, 1280 },
> + .hfront_porch = { 48, 48, 48 },
> + .hback_porch = { 80, 80, 80 },
> + .hsync_len = { 32, 32, 32 },
> + .vactive = { 800, 800, 800 },
> + .vfront_porch = { 3, 3, 3 },
> + .vback_porch = { 14, 14, 14 },
> + .vsync_len = { 6, 6, 6 },
> +};
> +
> +static const struct panel_desc boe_ev121wxm_n10_1850 = {
> + .timings = &boe_ev121wxm_n10_1850_timing,
> + .num_timings = 1,
> + .bpc = 8,
> + .size = {
> + .width = 261,
> + .height = 163,
> + },
> + .delay = {
> + .prepare = 9,
> + .enable = 300,
> + .unprepare = 300,
> + .disable = 560,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> + .bus_flags = DRM_BUS_FLAG_DE_HIGH,
> + .connector_type = DRM_MODE_CONNECTOR_LVDS,
> +};
> +
> static const struct drm_display_mode boe_hv070wsa_mode = {
> .clock = 42105,
> .hdisplay = 1024,
> @@ -3984,6 +4015,9 @@ static const struct of_device_id platform_of_match[] = {
> }, {
> .compatible = "bananapi,s070wv20-ct16",
> .data = &bananapi_s070wv20_ct16,
> + }, {
> + .compatible = "boe,ev121wxm-n10-1850",
> + .data = &boe_ev121wxm_n10_1850,
> }, {
> .compatible = "boe,hv070wsa-100",
> .data = &boe_hv070wsa
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 0/2] drm/panel: panel-simple: Add BOE EV121WXM-N10-1850 panel support
2023-05-08 8:38 [PATCH v2 0/2] drm/panel: panel-simple: Add BOE EV121WXM-N10-1850 panel support Liu Ying
2023-05-08 8:38 ` [PATCH v2 1/2] dt-bindings: display: simple: Add BOE EV121WXM-N10-1850 panel Liu Ying
2023-05-08 8:38 ` [PATCH v2 2/2] drm/panel: panel-simple: Add BOE EV121WXM-N10-1850 panel support Liu Ying
@ 2023-05-11 8:48 ` Neil Armstrong
2 siblings, 0 replies; 7+ messages in thread
From: Neil Armstrong @ 2023-05-11 8:48 UTC (permalink / raw)
To: dri-devel, devicetree, linux-kernel, Liu Ying
Cc: sam, airlied, daniel, robh+dt, krzysztof.kozlowski+dt, conor+dt,
thierry.reding, linux-imx, krzysztof.kozlowski
Hi,
On Mon, 08 May 2023 16:38:24 +0800, Liu Ying wrote:
> This patch series aims to add BOE EV121WXM-N10-1850 panel support
> in the DRM simple panel driver.
>
> Patch 1/2 adds dt-bindings support for the panel.
> Patch 2/2 adds the panel support in the DRM simple panel driver.
>
> v1->v2:
> * Add Krzysztof's A-b tag on patch 1/2.
> * Use struct display_timing in patch 2/2 to tell minimum and maximum
> pixel clock rates.
> * Set bus_flags to DRM_BUS_FLAG_DE_HIGH in struct panel_desc in patch 2/2.
>
> [...]
Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)
[1/2] dt-bindings: display: simple: Add BOE EV121WXM-N10-1850 panel
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=0bd5bd65cd2e4d1335ea6c17cd2c8664decbc630
[2/2] drm/panel: panel-simple: Add BOE EV121WXM-N10-1850 panel support
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=8bb7c7bca5b70f3cd22d95b4d36029295c4274f6
--
Neil
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-05-11 8:48 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-08 8:38 [PATCH v2 0/2] drm/panel: panel-simple: Add BOE EV121WXM-N10-1850 panel support Liu Ying
2023-05-08 8:38 ` [PATCH v2 1/2] dt-bindings: display: simple: Add BOE EV121WXM-N10-1850 panel Liu Ying
2023-05-08 9:27 ` Rob Herring
2023-05-08 10:13 ` Krzysztof Kozlowski
2023-05-08 8:38 ` [PATCH v2 2/2] drm/panel: panel-simple: Add BOE EV121WXM-N10-1850 panel support Liu Ying
2023-05-09 7:49 ` neil.armstrong
2023-05-11 8:48 ` [PATCH v2 0/2] " Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).