From: Jonathan Cameron <jic23@kernel.org>
To: Maxim Kiselev <bigunclemax@gmail.com>
Cc: linux-iio@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Conor Dooley <conor@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Philipp Zabel <p.zabel@pengutronix.de>,
Andre Przywara <andre.przywara@arm.com>,
Heiko Stuebner <heiko.stuebner@vrull.eu>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Cosmin Tanislav <demonsingur@gmail.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Alexander Sverdlin <alexander.sverdlin@gmail.com>,
Ramona Bolboaca <ramona.bolboaca@analog.com>,
William Breathitt Gray <william.gray@linaro.org>,
ChiYuan Huang <cy_huang@richtek.com>,
Ibrahim Tilki <Ibrahim.Tilki@analog.com>,
Caleb Connolly <caleb.connolly@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Mike Looijmans <mike.looijmans@topic.nl>,
ChiaEn Wu <chiaen_wu@richtek.com>,
Haibo Chen <haibo.chen@nxp.com>,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [RFC PATCH v1 2/4] dt-bindings: iio: adc: Add Allwinner D1/T113s/R329 SoCs GPADC
Date: Sun, 28 May 2023 16:28:13 +0100 [thread overview]
Message-ID: <20230528162813.6a7263e5@jic23-huawei> (raw)
In-Reply-To: <20230524082744.3215427-3-bigunclemax@gmail.com>
On Wed, 24 May 2023 11:27:31 +0300
Maxim Kiselev <bigunclemax@gmail.com> wrote:
> Allwinner's D1, T113s and R329 SoCs have a new general purpose ADC.
> This ADC is the same for all of this SoCs. The only difference is
> the number of available channels.
>
> Signed-off-by: Maxim Kiselev <bigunclemax@gmail.com>
> ---
> .../iio/adc/allwinner,sun20i-d1-gpadc.yaml | 52 +++++++++++++++++++
> 1 file changed, 52 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/allwinner,sun20i-d1-gpadc.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/allwinner,sun20i-d1-gpadc.yaml b/Documentation/devicetree/bindings/iio/adc/allwinner,sun20i-d1-gpadc.yaml
> new file mode 100644
> index 000000000000..a79b874750dd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/allwinner,sun20i-d1-gpadc.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/allwinner,sun20i-d1-gpadc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Allwinner D1 General Purpose ADC
> +
> +properties:
> + "#io-channel-cells":
> + const: 0
That's odd for a device with more than one channel. How do you reference
which channel you want to consume?
> +
> + clocks:
> + maxItems: 1
> +
> + compatible:
> + enum:
> + - allwinner,sun20i-d1-gpadc
> + - allwinner,sun8i-t113-gpadc
> + - allwinner,sun50i-r329-gpadc
> +
> + interrupts:
> + maxItems: 1
> +
> + reg:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> +
> +required:
> + - "#io-channel-cells"
> + - clocks
> + - compatible
> + - interrupts
> + - reg
> + - resets
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + gpadc: adc@2009000 {
> + compatible = "allwinner,sun20i-d1-gpadc";
> + reg = <0x2009000 0x1000>;
> + clocks = <&ccu CLK_BUS_GPADC>;
> + resets = <&ccu RST_BUS_GPADC>;
> + interrupts = <SOC_PERIPHERAL_IRQ(57) IRQ_TYPE_LEVEL_HIGH>;
I guess the bot probably got this, but to use these macros you need some includes.
> + #io-channel-cells = <0>;
> + };
> +
> +...
next prev parent reply other threads:[~2023-05-28 15:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 8:27 [RFC PATCH v1 0/4] Add support for Allwinner GPADC on D1/T113s/R329 SoCs Maxim Kiselev
2023-05-24 8:27 ` [RFC PATCH v1 1/4] iio: adc: Add Allwinner D1/T113s/R329 SoCs GPADC Maxim Kiselev
2023-05-24 10:01 ` Andre Przywara
2023-05-24 11:06 ` Andy Shevchenko
2023-05-24 12:14 ` Maxim Kiselev
2023-05-28 16:38 ` Jonathan Cameron
2023-05-24 8:27 ` [RFC PATCH v1 2/4] dt-bindings: " Maxim Kiselev
2023-05-24 9:21 ` Rob Herring
2023-05-28 15:28 ` Jonathan Cameron [this message]
2023-05-24 8:27 ` [RFC PATCH v1 3/4] ARM: dts: sun8i: t113s: Add GPADC node Maxim Kiselev
2023-05-24 8:27 ` [RFC PATCH v1 4/4] riscv: dts: allwinner: d1: " Maxim Kiselev
2023-05-24 9:34 ` [RFC PATCH v1 0/4] Add support for Allwinner GPADC on D1/T113s/R329 SoCs Andre Przywara
2023-05-24 11:36 ` Maxim Kiselev
2023-05-28 15:22 ` Jonathan Cameron
2023-05-28 15:25 ` Jonathan Cameron
2023-05-28 16:39 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230528162813.6a7263e5@jic23-huawei \
--to=jic23@kernel.org \
--cc=Ibrahim.Tilki@analog.com \
--cc=alexander.sverdlin@gmail.com \
--cc=andre.przywara@arm.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=bigunclemax@gmail.com \
--cc=caleb.connolly@linaro.org \
--cc=chiaen_wu@richtek.com \
--cc=conor@kernel.org \
--cc=cy_huang@richtek.com \
--cc=demonsingur@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=haibo.chen@nxp.com \
--cc=heiko.stuebner@vrull.eu \
--cc=hvilleneuve@dimonoff.com \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mike.looijmans@topic.nl \
--cc=miquel.raynal@bootlin.com \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=ramona.bolboaca@analog.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
--cc=william.gray@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).