From: Maxim Kiselev <bigunclemax@gmail.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: linux-iio@vger.kernel.org, "Jonathan Cameron" <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Conor Dooley" <conor@kernel.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Heiko Stuebner" <heiko.stuebner@vrull.eu>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Cosmin Tanislav" <demonsingur@gmail.com>,
"Mike Looijmans" <mike.looijmans@topic.nl>,
"Haibo Chen" <haibo.chen@nxp.com>,
"ChiYuan Huang" <cy_huang@richtek.com>,
"Ramona Bolboaca" <ramona.bolboaca@analog.com>,
"Ibrahim Tilki" <Ibrahim.Tilki@analog.com>,
"Caleb Connolly" <caleb.connolly@linaro.org>,
"William Breathitt Gray" <william.gray@linaro.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Leonard Göhrs" <l.goehrs@pengutronix.de>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
"ChiaEn Wu" <chiaen_wu@richtek.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [RFC PATCH v1 0/4] Add support for Allwinner GPADC on D1/T113s/R329 SoCs
Date: Wed, 24 May 2023 14:36:28 +0300 [thread overview]
Message-ID: <CALHCpMh2sZSCrFMMT13kYbsu+C2bC2xY3coB_fv0mZom_g=oPQ@mail.gmail.com> (raw)
In-Reply-To: <20230524103431.50c6a2fd@donnerap.cambridge.arm.com>
Hi Andre,
thanks for you comments
> This may sound kind of obvious, but wouldn't it be easier to model this
> with one compatible string, and have the number of channels as a DT
> property?
Yes, I completely agree that using separate config for each SoCs is looks
overcomplicated because the only difference is the number of channels.
I thought about a DT property with channels number but I didn't find
another ADC driver with the same approach (except i2c ADC's with child nodes).
> Or, alternatively, using iio/multiplexer/io-channel-mux.yaml, since it's
> only one ADC anyway?
I'm sorry, I didn't quite understand what you're suggesting.
> And btw: it seems that the T507 (the H616 die with a different pinout) has
> the same IP, with four channels:
> http://dl.linux-sunxi.org/T507/
Oh, thanks for pointing that. I'll add it to the list in the next version.
next prev parent reply other threads:[~2023-05-24 11:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 8:27 [RFC PATCH v1 0/4] Add support for Allwinner GPADC on D1/T113s/R329 SoCs Maxim Kiselev
2023-05-24 8:27 ` [RFC PATCH v1 1/4] iio: adc: Add Allwinner D1/T113s/R329 SoCs GPADC Maxim Kiselev
2023-05-24 10:01 ` Andre Przywara
2023-05-24 11:06 ` Andy Shevchenko
2023-05-24 12:14 ` Maxim Kiselev
2023-05-28 16:38 ` Jonathan Cameron
2023-05-24 8:27 ` [RFC PATCH v1 2/4] dt-bindings: " Maxim Kiselev
2023-05-24 9:21 ` Rob Herring
2023-05-28 15:28 ` Jonathan Cameron
2023-05-24 8:27 ` [RFC PATCH v1 3/4] ARM: dts: sun8i: t113s: Add GPADC node Maxim Kiselev
2023-05-24 8:27 ` [RFC PATCH v1 4/4] riscv: dts: allwinner: d1: " Maxim Kiselev
2023-05-24 9:34 ` [RFC PATCH v1 0/4] Add support for Allwinner GPADC on D1/T113s/R329 SoCs Andre Przywara
2023-05-24 11:36 ` Maxim Kiselev [this message]
2023-05-28 15:22 ` Jonathan Cameron
2023-05-28 15:25 ` Jonathan Cameron
2023-05-28 16:39 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALHCpMh2sZSCrFMMT13kYbsu+C2bC2xY3coB_fv0mZom_g=oPQ@mail.gmail.com' \
--to=bigunclemax@gmail.com \
--cc=Ibrahim.Tilki@analog.com \
--cc=andre.przywara@arm.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=caleb.connolly@linaro.org \
--cc=chiaen_wu@richtek.com \
--cc=conor@kernel.org \
--cc=cy_huang@richtek.com \
--cc=demonsingur@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=haibo.chen@nxp.com \
--cc=heiko.stuebner@vrull.eu \
--cc=hvilleneuve@dimonoff.com \
--cc=jernej.skrabec@gmail.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.goehrs@pengutronix.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mike.looijmans@topic.nl \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=ramona.bolboaca@analog.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
--cc=william.gray@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).