linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 6.1 5.15 5.10 5.4 4.19 4.14] selftests/memfd: Fix unknown type name build failure
@ 2023-05-26 23:21 Hardik Garg
  2023-05-27  1:21 ` Tyler Hicks
  2023-05-28  7:42 ` Greg KH
  0 siblings, 2 replies; 3+ messages in thread
From: Hardik Garg @ 2023-05-26 23:21 UTC (permalink / raw)
  To: stable; +Cc: shuah, jeffxu, linux-kselftest, linux-kernel, code, niyelchu

Partially backport v6.3 commit 11f75a01448f ("selftests/memfd: add
tests for MFD_NOEXEC_SEAL MFD_EXEC") to fix an unknown type name 
build error.
In some systems, the __u64 typedef is not present due to differences
in system headers, causing compilation errors like this one:

fuse_test.c:64:8: error: unknown type name '__u64'
   64 | static __u64 mfd_assert_get_seals(int fd)

This header includes the  __u64 typedef which increases the
likelihood of successful compilation on a wider variety of systems.

Signed-off-by: Hardik Garg <hargar@linux.microsoft.com>
---
 tools/testing/selftests/memfd/fuse_test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/memfd/fuse_test.c b/tools/testing/selftests/memfd/fuse_test.c
index be675002f918..93798c8c5d54 100644
--- a/tools/testing/selftests/memfd/fuse_test.c
+++ b/tools/testing/selftests/memfd/fuse_test.c
@@ -22,6 +22,7 @@
 #include <linux/falloc.h>
 #include <fcntl.h>
 #include <linux/memfd.h>
+#include <linux/types.h>
 #include <sched.h>
 #include <stdio.h>
 #include <stdlib.h>
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 6.1 5.15 5.10 5.4 4.19 4.14] selftests/memfd: Fix unknown type name build failure
  2023-05-26 23:21 [PATCH 6.1 5.15 5.10 5.4 4.19 4.14] selftests/memfd: Fix unknown type name build failure Hardik Garg
@ 2023-05-27  1:21 ` Tyler Hicks
  2023-05-28  7:42 ` Greg KH
  1 sibling, 0 replies; 3+ messages in thread
From: Tyler Hicks @ 2023-05-27  1:21 UTC (permalink / raw)
  To: Hardik Garg
  Cc: stable, shuah, jeffxu, linux-kselftest, linux-kernel, niyelchu

On 2023-05-26 16:21:36, Hardik Garg wrote:
> Partially backport v6.3 commit 11f75a01448f ("selftests/memfd: add
> tests for MFD_NOEXEC_SEAL MFD_EXEC") to fix an unknown type name 
> build error.
> In some systems, the __u64 typedef is not present due to differences
> in system headers, causing compilation errors like this one:
> 
> fuse_test.c:64:8: error: unknown type name '__u64'
>    64 | static __u64 mfd_assert_get_seals(int fd)
> 
> This header includes the  __u64 typedef which increases the
> likelihood of successful compilation on a wider variety of systems.
> 
> Signed-off-by: Hardik Garg <hargar@linux.microsoft.com>

Reviewed-by: Tyler Hicks (Microsoft) <code@tyhicks.com>

Tyler

> ---
>  tools/testing/selftests/memfd/fuse_test.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/memfd/fuse_test.c b/tools/testing/selftests/memfd/fuse_test.c
> index be675002f918..93798c8c5d54 100644
> --- a/tools/testing/selftests/memfd/fuse_test.c
> +++ b/tools/testing/selftests/memfd/fuse_test.c
> @@ -22,6 +22,7 @@
>  #include <linux/falloc.h>
>  #include <fcntl.h>
>  #include <linux/memfd.h>
> +#include <linux/types.h>
>  #include <sched.h>
>  #include <stdio.h>
>  #include <stdlib.h>
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 6.1 5.15 5.10 5.4 4.19 4.14] selftests/memfd: Fix unknown type name build failure
  2023-05-26 23:21 [PATCH 6.1 5.15 5.10 5.4 4.19 4.14] selftests/memfd: Fix unknown type name build failure Hardik Garg
  2023-05-27  1:21 ` Tyler Hicks
@ 2023-05-28  7:42 ` Greg KH
  1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2023-05-28  7:42 UTC (permalink / raw)
  To: Hardik Garg
  Cc: stable, shuah, jeffxu, linux-kselftest, linux-kernel, code, niyelchu

On Fri, May 26, 2023 at 04:21:36PM -0700, Hardik Garg wrote:
> Partially backport v6.3 commit 11f75a01448f ("selftests/memfd: add
> tests for MFD_NOEXEC_SEAL MFD_EXEC") to fix an unknown type name 
> build error.
> In some systems, the __u64 typedef is not present due to differences
> in system headers, causing compilation errors like this one:
> 
> fuse_test.c:64:8: error: unknown type name '__u64'
>    64 | static __u64 mfd_assert_get_seals(int fd)
> 
> This header includes the  __u64 typedef which increases the
> likelihood of successful compilation on a wider variety of systems.
> 
> Signed-off-by: Hardik Garg <hargar@linux.microsoft.com>
> ---
>  tools/testing/selftests/memfd/fuse_test.c | 1 +
>  1 file changed, 1 insertion(+)

Now queued up, thanks.

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-05-28  7:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-26 23:21 [PATCH 6.1 5.15 5.10 5.4 4.19 4.14] selftests/memfd: Fix unknown type name build failure Hardik Garg
2023-05-27  1:21 ` Tyler Hicks
2023-05-28  7:42 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).