[PATCH 1/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add missing type for "linux,keycode"

[PATCH 1/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add missing type for "linux,keycode"

[Rob Herring]

The "linux,keycode" property is missing a type probably because it was
confused with the common property "linux,keycodes".

Signed-off-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml b/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml
index 286dffa0671b..6052129bf852 100644
--- a/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml
+++ b/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml
@@ -103,6 +103,7 @@ properties:
       wakeup-source: true
 
       linux,keycode:
+        $ref: /schemas/types.yaml#/definitions/uint32
         default: 116
 
     required:
-- 
2.39.2

[PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode"

[Rob Herring]

The "linux,keycode" property is non-standard. Add the common property
"linux,keycodes" and mark "linux,keycode" deprecated so that the mistake
is not propagated.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml         | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml b/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml
index 6052129bf852..e879bc0be8e2 100644
--- a/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml
+++ b/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml
@@ -105,6 +105,11 @@ properties:
       linux,keycode:
         $ref: /schemas/types.yaml#/definitions/uint32
         default: 116
+        deprecated: true
+
+      linux,keycodes:
+        maxItems: 1
+        default: 116
 
     required:
       - compatible
-- 
2.39.2

Re: [PATCH 1/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add missing type for "linux,keycode"

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

On Tue, Jun 13, 2023 at 02:12:29PM -0600, Rob Herring wrote:
> The "linux,keycode" property is missing a type probably because it was
> confused with the common property "linux,keycodes".
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode"

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1188 bytes --]

On Tue, Jun 13, 2023 at 02:12:30PM -0600, Rob Herring wrote:
> The "linux,keycode" property is non-standard. Add the common property
> "linux,keycodes" and mark "linux,keycode" deprecated so that the mistake
> is not propagated.

This is actually used in the driver for this device, should the driver
not also be updated to use the corrected property?


> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  .../devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml         | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml b/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml
> index 6052129bf852..e879bc0be8e2 100644
> --- a/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml
> +++ b/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml
> @@ -105,6 +105,11 @@ properties:
>        linux,keycode:
>          $ref: /schemas/types.yaml#/definitions/uint32
>          default: 116
> +        deprecated: true
> +
> +      linux,keycodes:
> +        maxItems: 1
> +        default: 116
>  
>      required:
>        - compatible
> -- 
> 2.39.2
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode"

[Rob Herring]

On Tue, Jun 13, 2023 at 3:11 PM Conor Dooley <conor@kernel.org> wrote:
>
> On Tue, Jun 13, 2023 at 02:12:30PM -0600, Rob Herring wrote:
> > The "linux,keycode" property is non-standard. Add the common property
> > "linux,keycodes" and mark "linux,keycode" deprecated so that the mistake
> > is not propagated.
>
> This is actually used in the driver for this device, should the driver
> not also be updated to use the corrected property?

Yes, but that doesn't have to be in sync with the binding change. I
mainly want to add this so it doesn't get propagated to new users
rather than move this case off of linux,keycode. Also, the input
subsystem should probably have a common function to read
linux,keycodes as right now every driver does it.

Rob

Re: [PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode"

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]

On Wed, Jun 14, 2023 at 08:53:20AM -0600, Rob Herring wrote:
> On Tue, Jun 13, 2023 at 3:11 PM Conor Dooley <conor@kernel.org> wrote:
> >
> > On Tue, Jun 13, 2023 at 02:12:30PM -0600, Rob Herring wrote:
> > > The "linux,keycode" property is non-standard. Add the common property
> > > "linux,keycodes" and mark "linux,keycode" deprecated so that the mistake
> > > is not propagated.
> >
> > This is actually used in the driver for this device, should the driver
> > not also be updated to use the corrected property?
> 
> Yes, but that doesn't have to be in sync with the binding change. I
> mainly want to add this so it doesn't get propagated to new users
> rather than move this case off of linux,keycode. Also, the input
> subsystem should probably have a common function to read
> linux,keycodes as right now every driver does it.

Perhaps one of the nxp folk in the audience should have a crack at that
so.
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 1/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add missing type for "linux,keycode"

[Rob Herring]

On Tue, 13 Jun 2023 14:12:29 -0600, Rob Herring wrote:
> The "linux,keycode" property is missing a type probably because it was
> confused with the common property "linux,keycodes".
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Applied, thanks!

Re: [PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode"

[Rob Herring]

On Tue, 13 Jun 2023 14:12:30 -0600, Rob Herring wrote:
> The "linux,keycode" property is non-standard. Add the common property
> "linux,keycodes" and mark "linux,keycode" deprecated so that the mistake
> is not propagated.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  .../devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml         | 5 +++++
>  1 file changed, 5 insertions(+)
> 

Applied, thanks!