* [PATCH] clk: meson: pll: remove unneeded semicolon
@ 2023-06-14 8:48 Jiapeng Chong
2023-06-14 14:05 ` Jerome Brunet
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jiapeng Chong @ 2023-06-14 8:48 UTC (permalink / raw)
To: neil.armstrong
Cc: jbrunet, mturquette, sboyd, khilman, martin.blumenstingl,
linux-amlogic, linux-clk, linux-arm-kernel, linux-kernel,
Jiapeng Chong, Abaci Robot
No functional modification involved.
./drivers/clk/meson/clk-pll.c:373:2-3: Unneeded semicolon.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5533
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/clk/meson/clk-pll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/meson/clk-pll.c b/drivers/clk/meson/clk-pll.c
index 56ec2210f1ad..8fef90bf962f 100644
--- a/drivers/clk/meson/clk-pll.c
+++ b/drivers/clk/meson/clk-pll.c
@@ -370,7 +370,7 @@ static int meson_clk_pll_enable(struct clk_hw *hw)
usleep_range(10, 20);
meson_parm_write(clk->map, &pll->current_en, 1);
usleep_range(40, 50);
- };
+ }
if (MESON_PARM_APPLICABLE(&pll->l_detect)) {
meson_parm_write(clk->map, &pll->l_detect, 1);
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] clk: meson: pll: remove unneeded semicolon
2023-06-14 8:48 [PATCH] clk: meson: pll: remove unneeded semicolon Jiapeng Chong
@ 2023-06-14 14:05 ` Jerome Brunet
2023-06-14 20:09 ` Martin Blumenstingl
2023-06-22 18:59 ` Dmitry Rokosov
2 siblings, 0 replies; 5+ messages in thread
From: Jerome Brunet @ 2023-06-14 14:05 UTC (permalink / raw)
To: Jiapeng Chong, neil.armstrong
Cc: mturquette, sboyd, khilman, martin.blumenstingl, linux-amlogic,
linux-clk, linux-arm-kernel, linux-kernel, Abaci Robot
On Wed 14 Jun 2023 at 16:48, Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:
> No functional modification involved.
>
> ./drivers/clk/meson/clk-pll.c:373:2-3: Unneeded semicolon.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5533
Not sure this tag is relevant
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Apart from this
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> drivers/clk/meson/clk-pll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/meson/clk-pll.c b/drivers/clk/meson/clk-pll.c
> index 56ec2210f1ad..8fef90bf962f 100644
> --- a/drivers/clk/meson/clk-pll.c
> +++ b/drivers/clk/meson/clk-pll.c
> @@ -370,7 +370,7 @@ static int meson_clk_pll_enable(struct clk_hw *hw)
> usleep_range(10, 20);
> meson_parm_write(clk->map, &pll->current_en, 1);
> usleep_range(40, 50);
> - };
> + }
>
> if (MESON_PARM_APPLICABLE(&pll->l_detect)) {
> meson_parm_write(clk->map, &pll->l_detect, 1);
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] clk: meson: pll: remove unneeded semicolon
2023-06-14 8:48 [PATCH] clk: meson: pll: remove unneeded semicolon Jiapeng Chong
2023-06-14 14:05 ` Jerome Brunet
@ 2023-06-14 20:09 ` Martin Blumenstingl
2023-06-15 10:36 ` Jerome Brunet
2023-06-22 18:59 ` Dmitry Rokosov
2 siblings, 1 reply; 5+ messages in thread
From: Martin Blumenstingl @ 2023-06-14 20:09 UTC (permalink / raw)
To: Jiapeng Chong
Cc: neil.armstrong, jbrunet, mturquette, sboyd, khilman,
linux-amlogic, linux-clk, linux-arm-kernel, linux-kernel,
Abaci Robot
On Wed, Jun 14, 2023 at 10:48 AM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> No functional modification involved.
>
> ./drivers/clk/meson/clk-pll.c:373:2-3: Unneeded semicolon.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5533
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] clk: meson: pll: remove unneeded semicolon
2023-06-14 20:09 ` Martin Blumenstingl
@ 2023-06-15 10:36 ` Jerome Brunet
0 siblings, 0 replies; 5+ messages in thread
From: Jerome Brunet @ 2023-06-15 10:36 UTC (permalink / raw)
To: Martin Blumenstingl, Jiapeng Chong
Cc: neil.armstrong, mturquette, sboyd, khilman, linux-amlogic,
linux-clk, linux-arm-kernel, linux-kernel, Abaci Robot
On Wed 14 Jun 2023 at 22:09, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
> On Wed, Jun 14, 2023 at 10:48 AM Jiapeng Chong
> <jiapeng.chong@linux.alibaba.com> wrote:
>>
>> No functional modification involved.
>>
>> ./drivers/clk/meson/clk-pll.c:373:2-3: Unneeded semicolon.
>>
>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5533
Removed this bugzilla tag and added a fixes tag:
Fixes: b6ec400aa153 ("clk: meson: introduce new pll power-on sequence for A1 SoC family")
>> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Applied through the amlogic clock tree.
Thx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] clk: meson: pll: remove unneeded semicolon
2023-06-14 8:48 [PATCH] clk: meson: pll: remove unneeded semicolon Jiapeng Chong
2023-06-14 14:05 ` Jerome Brunet
2023-06-14 20:09 ` Martin Blumenstingl
@ 2023-06-22 18:59 ` Dmitry Rokosov
2 siblings, 0 replies; 5+ messages in thread
From: Dmitry Rokosov @ 2023-06-22 18:59 UTC (permalink / raw)
To: Jiapeng Chong
Cc: neil.armstrong, jbrunet, mturquette, sboyd, khilman,
martin.blumenstingl, linux-amlogic, linux-clk, linux-arm-kernel,
linux-kernel, Abaci Robot
Dear Jiapeng,
Thank you for catching this bug! Appreciate it!
On Wed, Jun 14, 2023 at 04:48:08PM +0800, Jiapeng Chong wrote:
> No functional modification involved.
>
> ./drivers/clk/meson/clk-pll.c:373:2-3: Unneeded semicolon.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5533
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/clk/meson/clk-pll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/meson/clk-pll.c b/drivers/clk/meson/clk-pll.c
> index 56ec2210f1ad..8fef90bf962f 100644
> --- a/drivers/clk/meson/clk-pll.c
> +++ b/drivers/clk/meson/clk-pll.c
> @@ -370,7 +370,7 @@ static int meson_clk_pll_enable(struct clk_hw *hw)
> usleep_range(10, 20);
> meson_parm_write(clk->map, &pll->current_en, 1);
> usleep_range(40, 50);
> - };
> + }
>
> if (MESON_PARM_APPLICABLE(&pll->l_detect)) {
> meson_parm_write(clk->map, &pll->l_detect, 1);
Reviewed-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> --
> 2.20.1.7.g153144c
>
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
--
Thank you,
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-22 19:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-14 8:48 [PATCH] clk: meson: pll: remove unneeded semicolon Jiapeng Chong
2023-06-14 14:05 ` Jerome Brunet
2023-06-14 20:09 ` Martin Blumenstingl
2023-06-15 10:36 ` Jerome Brunet
2023-06-22 18:59 ` Dmitry Rokosov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).