* [PATCH v4 0/6] Add display support on the stm32f746-disco board
@ 2023-06-19 16:55 Dario Binacchi
2023-06-19 16:55 ` [PATCH v4 1/6] ARM: dts: stm32: add ltdc support on stm32f746 MCU Dario Binacchi
` (5 more replies)
0 siblings, 6 replies; 10+ messages in thread
From: Dario Binacchi @ 2023-06-19 16:55 UTC (permalink / raw)
To: linux-kernel
Cc: Philippe Cornu, Raphael Gallais-Pou, Amarula patchwork, michael,
Dario Binacchi, Alexandre Torgue, Conor Dooley, Daniel Vetter,
David Airlie, Krzysztof Kozlowski, Maxime Coquelin, Rob Herring,
Yannick Fertre, devicetree, dri-devel, linux-arm-kernel,
linux-stm32
The series adds support for the display on the stm32f746-disco board,
along with a generic patch that adds the "bpp" parameter to the stm-drm
module. The intention is to allow users to size, within certain limits,
the memory footprint required by the framebuffer.
Changes in v4:
- Use DTS property instead of module parameter to set the framebuffer bit depth.
Changes in v3:
- rename ltdc-pins-a-0 to ltdc-0.
- drop [4/6] dt-bindings: display: simple: add Rocktech RK043FN48H
Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next):
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=c42a37a27c777d63961dd634a30f7c887949491a
- drop [5/6] drm/panel: simple: add support for Rocktech RK043FN48H panel
Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=13cdd12a9f934158f4ec817cf048fcb4384aa9dc
Dario Binacchi (6):
ARM: dts: stm32: add ltdc support on stm32f746 MCU
ARM: dts: stm32: add pin map for LTDC on stm32f7
ARM: dts: stm32: support display on stm32f746-disco board
dt-bindings: display: stm32-ltdc: add optional st,fb-bpp property
ARM: dts: stm32: set framebuffer bit depth on stm32f746-disco
drm/stm: set framebuffer bit depth through DTS property
.../bindings/display/st,stm32-ltdc.yaml | 6 +++
arch/arm/boot/dts/stm32f7-pinctrl.dtsi | 35 +++++++++++++
arch/arm/boot/dts/stm32f746-disco.dts | 52 +++++++++++++++++++
arch/arm/boot/dts/stm32f746.dtsi | 10 ++++
drivers/gpu/drm/stm/drv.c | 6 ++-
5 files changed, 108 insertions(+), 1 deletion(-)
--
2.32.0
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v4 1/6] ARM: dts: stm32: add ltdc support on stm32f746 MCU
2023-06-19 16:55 [PATCH v4 0/6] Add display support on the stm32f746-disco board Dario Binacchi
@ 2023-06-19 16:55 ` Dario Binacchi
2023-06-19 16:55 ` [PATCH v4 2/6] ARM: dts: stm32: add pin map for LTDC on stm32f7 Dario Binacchi
` (4 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Dario Binacchi @ 2023-06-19 16:55 UTC (permalink / raw)
To: linux-kernel
Cc: Philippe Cornu, Raphael Gallais-Pou, Amarula patchwork, michael,
Dario Binacchi, Alexandre Torgue, Conor Dooley,
Krzysztof Kozlowski, Maxime Coquelin, Rob Herring, devicetree,
linux-arm-kernel, linux-stm32
Add LTDC (Lcd-tft Display Controller) support.
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
(no changes since v1)
arch/arm/boot/dts/stm32f746.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/stm32f746.dtsi b/arch/arm/boot/dts/stm32f746.dtsi
index dc868e6da40e..9c4ba0b7f239 100644
--- a/arch/arm/boot/dts/stm32f746.dtsi
+++ b/arch/arm/boot/dts/stm32f746.dtsi
@@ -507,6 +507,16 @@ pwm {
};
};
+ ltdc: display-controller@40016800 {
+ compatible = "st,stm32-ltdc";
+ reg = <0x40016800 0x200>;
+ interrupts = <88>, <89>;
+ resets = <&rcc STM32F7_APB2_RESET(LTDC)>;
+ clocks = <&rcc 1 CLK_LCD>;
+ clock-names = "lcd";
+ status = "disabled";
+ };
+
pwrcfg: power-config@40007000 {
compatible = "st,stm32-power-config", "syscon";
reg = <0x40007000 0x400>;
--
2.32.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v4 2/6] ARM: dts: stm32: add pin map for LTDC on stm32f7
2023-06-19 16:55 [PATCH v4 0/6] Add display support on the stm32f746-disco board Dario Binacchi
2023-06-19 16:55 ` [PATCH v4 1/6] ARM: dts: stm32: add ltdc support on stm32f746 MCU Dario Binacchi
@ 2023-06-19 16:55 ` Dario Binacchi
2023-06-19 16:55 ` [PATCH v4 3/6] ARM: dts: stm32: support display on stm32f746-disco board Dario Binacchi
` (3 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Dario Binacchi @ 2023-06-19 16:55 UTC (permalink / raw)
To: linux-kernel
Cc: Philippe Cornu, Raphael Gallais-Pou, Amarula patchwork, michael,
Dario Binacchi, Alexandre Torgue, Conor Dooley,
Krzysztof Kozlowski, Maxime Coquelin, Rob Herring, devicetree,
linux-arm-kernel, linux-stm32
Add pin configurations for using LTDC (LCD-tft Display Controller) on
stm32f746-disco board.
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
(no changes since v3)
Changes in v3:
- rename ltdc-pins-a-0 to ltdc-0.
arch/arm/boot/dts/stm32f7-pinctrl.dtsi | 35 ++++++++++++++++++++++++++
1 file changed, 35 insertions(+)
diff --git a/arch/arm/boot/dts/stm32f7-pinctrl.dtsi b/arch/arm/boot/dts/stm32f7-pinctrl.dtsi
index 9f65403295ca..36dad40dd0c7 100644
--- a/arch/arm/boot/dts/stm32f7-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stm32f7-pinctrl.dtsi
@@ -365,6 +365,41 @@ pins2 {
bias-pull-up;
};
};
+
+
+ ltdc_pins_a: ltdc-0 {
+ pins {
+ pinmux = <STM32_PINMUX('E', 4, AF14)>, /* LCD_B0 */
+ <STM32_PINMUX('G',12, AF9)>, /* LCD_B4 */
+ <STM32_PINMUX('I', 9, AF14)>, /* LCD_VSYNC */
+ <STM32_PINMUX('I',10, AF14)>, /* LCD_HSYNC */
+ <STM32_PINMUX('I',14, AF14)>, /* LCD_CLK */
+ <STM32_PINMUX('I',15, AF14)>, /* LCD_R0 */
+ <STM32_PINMUX('J', 0, AF14)>, /* LCD_R1 */
+ <STM32_PINMUX('J', 1, AF14)>, /* LCD_R2 */
+ <STM32_PINMUX('J', 2, AF14)>, /* LCD_R3 */
+ <STM32_PINMUX('J', 3, AF14)>, /* LCD_R4 */
+ <STM32_PINMUX('J', 4, AF14)>, /* LCD_R5 */
+ <STM32_PINMUX('J', 5, AF14)>, /* LCD_R6 */
+ <STM32_PINMUX('J', 6, AF14)>, /* LCD_R7 */
+ <STM32_PINMUX('J', 7, AF14)>, /* LCD_G0 */
+ <STM32_PINMUX('J', 8, AF14)>, /* LCD_G1 */
+ <STM32_PINMUX('J', 9, AF14)>, /* LCD_G2 */
+ <STM32_PINMUX('J',10, AF14)>, /* LCD_G3 */
+ <STM32_PINMUX('J',11, AF14)>, /* LCD_G4 */
+ <STM32_PINMUX('J',13, AF14)>, /* LCD_B1 */
+ <STM32_PINMUX('J',14, AF14)>, /* LCD_B2 */
+ <STM32_PINMUX('J',15, AF14)>, /* LCD_B3 */
+ <STM32_PINMUX('K', 0, AF14)>, /* LCD_G5 */
+ <STM32_PINMUX('K', 1, AF14)>, /* LCD_G6 */
+ <STM32_PINMUX('K', 2, AF14)>, /* LCD_G7 */
+ <STM32_PINMUX('K', 4, AF14)>, /* LCD_B5 */
+ <STM32_PINMUX('K', 5, AF14)>, /* LCD_B6 */
+ <STM32_PINMUX('K', 6, AF14)>, /* LCD_B7 */
+ <STM32_PINMUX('K', 7, AF14)>; /* LCD_DE */
+ slew-rate = <2>;
+ };
+ };
};
};
};
--
2.32.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v4 3/6] ARM: dts: stm32: support display on stm32f746-disco board
2023-06-19 16:55 [PATCH v4 0/6] Add display support on the stm32f746-disco board Dario Binacchi
2023-06-19 16:55 ` [PATCH v4 1/6] ARM: dts: stm32: add ltdc support on stm32f746 MCU Dario Binacchi
2023-06-19 16:55 ` [PATCH v4 2/6] ARM: dts: stm32: add pin map for LTDC on stm32f7 Dario Binacchi
@ 2023-06-19 16:55 ` Dario Binacchi
2023-06-19 16:55 ` [PATCH v4 4/6] dt-bindings: display: stm32-ltdc: add optional st,fb-bpp property Dario Binacchi
` (2 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Dario Binacchi @ 2023-06-19 16:55 UTC (permalink / raw)
To: linux-kernel
Cc: Philippe Cornu, Raphael Gallais-Pou, Amarula patchwork, michael,
Dario Binacchi, Alexandre Torgue, Conor Dooley,
Krzysztof Kozlowski, Maxime Coquelin, Rob Herring, devicetree,
linux-arm-kernel, linux-stm32
Add support to Rocktech RK043FN48H display on stm32f746-disco board.
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
(no changes since v1)
arch/arm/boot/dts/stm32f746-disco.dts | 51 +++++++++++++++++++++++++++
1 file changed, 51 insertions(+)
diff --git a/arch/arm/boot/dts/stm32f746-disco.dts b/arch/arm/boot/dts/stm32f746-disco.dts
index c11616ed5fc6..cda423b6a874 100644
--- a/arch/arm/boot/dts/stm32f746-disco.dts
+++ b/arch/arm/boot/dts/stm32f746-disco.dts
@@ -60,10 +60,41 @@ memory@c0000000 {
reg = <0xC0000000 0x800000>;
};
+ reserved-memory {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ linux,cma {
+ compatible = "shared-dma-pool";
+ no-map;
+ size = <0x80000>;
+ linux,dma-default;
+ };
+ };
+
aliases {
serial0 = &usart1;
};
+ backlight: backlight {
+ compatible = "gpio-backlight";
+ gpios = <&gpiok 3 GPIO_ACTIVE_HIGH>;
+ status = "okay";
+ };
+
+ panel_rgb: panel-rgb {
+ compatible = "rocktech,rk043fn48h";
+ backlight = <&backlight>;
+ enable-gpios = <&gpioi 12 GPIO_ACTIVE_HIGH>;
+ status = "okay";
+ port {
+ panel_in_rgb: endpoint {
+ remote-endpoint = <<dc_out_rgb>;
+ };
+ };
+ };
+
usbotg_hs_phy: usb-phy {
#phy-cells = <0>;
compatible = "usb-nop-xceiv";
@@ -99,6 +130,26 @@ &i2c1 {
status = "okay";
};
+&dma1 {
+ status = "okay";
+};
+
+&dma2 {
+ status = "okay";
+};
+
+<dc {
+ pinctrl-0 = <<dc_pins_a>;
+ pinctrl-names = "default";
+ status = "okay";
+
+ port {
+ ltdc_out_rgb: endpoint {
+ remote-endpoint = <&panel_in_rgb>;
+ };
+ };
+};
+
&sdio1 {
status = "okay";
vmmc-supply = <&mmc_vcard>;
--
2.32.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v4 4/6] dt-bindings: display: stm32-ltdc: add optional st,fb-bpp property
2023-06-19 16:55 [PATCH v4 0/6] Add display support on the stm32f746-disco board Dario Binacchi
` (2 preceding siblings ...)
2023-06-19 16:55 ` [PATCH v4 3/6] ARM: dts: stm32: support display on stm32f746-disco board Dario Binacchi
@ 2023-06-19 16:55 ` Dario Binacchi
2023-06-19 17:17 ` Rob Herring
2023-06-19 20:18 ` Conor Dooley
2023-06-19 16:55 ` [PATCH v4 5/6] ARM: dts: stm32: set framebuffer bit depth on stm32f746-disco Dario Binacchi
2023-06-19 16:55 ` [PATCH v4 6/6] drm/stm: set framebuffer bit depth through DTS property Dario Binacchi
5 siblings, 2 replies; 10+ messages in thread
From: Dario Binacchi @ 2023-06-19 16:55 UTC (permalink / raw)
To: linux-kernel
Cc: Philippe Cornu, Raphael Gallais-Pou, Amarula patchwork, michael,
Dario Binacchi, Alexandre Torgue, Conor Dooley, Daniel Vetter,
David Airlie, Krzysztof Kozlowski, Maxime Coquelin, Rob Herring,
Yannick Fertre, devicetree, dri-devel, linux-arm-kernel,
linux-stm32
Boards that use the STM32F{4,7} series have limited amounts of RAM. The
added property allows to size, within certain limits, the memory footprint
required by the framebuffer.
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
(no changes since v1)
.../devicetree/bindings/display/st,stm32-ltdc.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml b/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml
index d6ea4d62a2cf..1c3a3653579f 100644
--- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml
+++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml
@@ -42,6 +42,12 @@ properties:
- for internal dpi input of the MIPI DSI host controller.
Note: These 2 endpoints cannot be activated simultaneously.
+ st,fb-bpp:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: |
+ bit depth of framebuffer (8, 16 or 32)
+ maxItems: 1
+
required:
- compatible
- reg
--
2.32.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v4 5/6] ARM: dts: stm32: set framebuffer bit depth on stm32f746-disco
2023-06-19 16:55 [PATCH v4 0/6] Add display support on the stm32f746-disco board Dario Binacchi
` (3 preceding siblings ...)
2023-06-19 16:55 ` [PATCH v4 4/6] dt-bindings: display: stm32-ltdc: add optional st,fb-bpp property Dario Binacchi
@ 2023-06-19 16:55 ` Dario Binacchi
2023-06-19 16:55 ` [PATCH v4 6/6] drm/stm: set framebuffer bit depth through DTS property Dario Binacchi
5 siblings, 0 replies; 10+ messages in thread
From: Dario Binacchi @ 2023-06-19 16:55 UTC (permalink / raw)
To: linux-kernel
Cc: Philippe Cornu, Raphael Gallais-Pou, Amarula patchwork, michael,
Dario Binacchi, Alexandre Torgue, Conor Dooley,
Krzysztof Kozlowski, Maxime Coquelin, Rob Herring, devicetree,
linux-arm-kernel, linux-stm32
The board uses a limited amounts of RAM. The added property halves the
memory footprint required by the framebuffer.
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
(no changes since v1)
arch/arm/boot/dts/stm32f746-disco.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/stm32f746-disco.dts b/arch/arm/boot/dts/stm32f746-disco.dts
index cda423b6a874..36612b4c2504 100644
--- a/arch/arm/boot/dts/stm32f746-disco.dts
+++ b/arch/arm/boot/dts/stm32f746-disco.dts
@@ -142,6 +142,7 @@ <dc {
pinctrl-0 = <<dc_pins_a>;
pinctrl-names = "default";
status = "okay";
+ st,fb-bpp = <8>;
port {
ltdc_out_rgb: endpoint {
--
2.32.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v4 6/6] drm/stm: set framebuffer bit depth through DTS property
2023-06-19 16:55 [PATCH v4 0/6] Add display support on the stm32f746-disco board Dario Binacchi
` (4 preceding siblings ...)
2023-06-19 16:55 ` [PATCH v4 5/6] ARM: dts: stm32: set framebuffer bit depth on stm32f746-disco Dario Binacchi
@ 2023-06-19 16:55 ` Dario Binacchi
5 siblings, 0 replies; 10+ messages in thread
From: Dario Binacchi @ 2023-06-19 16:55 UTC (permalink / raw)
To: linux-kernel
Cc: Philippe Cornu, Raphael Gallais-Pou, Amarula patchwork, michael,
Dario Binacchi, Alexandre Torgue, Daniel Vetter, David Airlie,
Maxime Coquelin, Yannick Fertre, dri-devel, linux-arm-kernel,
linux-stm32
The patch, which is backwards compatible, sets the bit depth of the
framebuffer using the optional property 'st,fb-bpp' in the DTS.
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
Changes in v4:
- Use DTS property instead of module parameter to set the framebuffer bit depth.
Changes in v3:
- drop [4/6] dt-bindings: display: simple: add Rocktech RK043FN48H
Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next):
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=c42a37a27c777d63961dd634a30f7c887949491a
- drop [5/6] drm/panel: simple: add support for Rocktech RK043FN48H panel
Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=13cdd12a9f934158f4ec817cf048fcb4384aa9dc
drivers/gpu/drm/stm/drv.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/stm/drv.c b/drivers/gpu/drm/stm/drv.c
index 422220df7d8c..7a61a3c63469 100644
--- a/drivers/gpu/drm/stm/drv.c
+++ b/drivers/gpu/drm/stm/drv.c
@@ -180,7 +180,9 @@ static const struct dev_pm_ops drv_pm_ops = {
static int stm_drm_platform_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
+ struct device_node *np = pdev->dev.of_node;
struct drm_device *ddev;
+ u32 fb_bpp = 16;
int ret;
DRM_DEBUG("%s\n", __func__);
@@ -203,7 +205,9 @@ static int stm_drm_platform_probe(struct platform_device *pdev)
if (ret)
goto err_put;
- drm_fbdev_dma_setup(ddev, 16);
+ of_property_read_u32(np, "st,fb-bpp", &fb_bpp);
+
+ drm_fbdev_dma_setup(ddev, fb_bpp);
return 0;
--
2.32.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v4 4/6] dt-bindings: display: stm32-ltdc: add optional st,fb-bpp property
2023-06-19 16:55 ` [PATCH v4 4/6] dt-bindings: display: stm32-ltdc: add optional st,fb-bpp property Dario Binacchi
@ 2023-06-19 17:17 ` Rob Herring
2023-06-19 20:18 ` Conor Dooley
1 sibling, 0 replies; 10+ messages in thread
From: Rob Herring @ 2023-06-19 17:17 UTC (permalink / raw)
To: Dario Binacchi
Cc: Daniel Vetter, Krzysztof Kozlowski, Yannick Fertre, Rob Herring,
Conor Dooley, David Airlie, devicetree, linux-arm-kernel,
linux-stm32, Raphael Gallais-Pou, Alexandre Torgue, dri-devel,
Philippe Cornu, Amarula patchwork, Maxime Coquelin, linux-kernel,
michael
On Mon, 19 Jun 2023 18:55:23 +0200, Dario Binacchi wrote:
> Boards that use the STM32F{4,7} series have limited amounts of RAM. The
> added property allows to size, within certain limits, the memory footprint
> required by the framebuffer.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
>
> (no changes since v1)
>
> .../devicetree/bindings/display/st,stm32-ltdc.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml: properties:st,fb-bpp:maxItems: False schema does not allow 1
from schema $id: http://devicetree.org/meta-schemas/core.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230619165525.1035243-5-dario.binacchi@amarulasolutions.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v4 4/6] dt-bindings: display: stm32-ltdc: add optional st,fb-bpp property
2023-06-19 16:55 ` [PATCH v4 4/6] dt-bindings: display: stm32-ltdc: add optional st,fb-bpp property Dario Binacchi
2023-06-19 17:17 ` Rob Herring
@ 2023-06-19 20:18 ` Conor Dooley
2023-06-19 22:11 ` Rob Herring
1 sibling, 1 reply; 10+ messages in thread
From: Conor Dooley @ 2023-06-19 20:18 UTC (permalink / raw)
To: Dario Binacchi
Cc: linux-kernel, Philippe Cornu, Raphael Gallais-Pou,
Amarula patchwork, michael, Alexandre Torgue, Conor Dooley,
Daniel Vetter, David Airlie, Krzysztof Kozlowski,
Maxime Coquelin, Rob Herring, Yannick Fertre, devicetree,
dri-devel, linux-arm-kernel, linux-stm32
[-- Attachment #1: Type: text/plain, Size: 1701 bytes --]
Hey,
On Mon, Jun 19, 2023 at 06:55:23PM +0200, Dario Binacchi wrote:
> Boards that use the STM32F{4,7} series have limited amounts of RAM. The
> added property allows to size, within certain limits, the memory footprint
> required by the framebuffer.
Hmm, this sounds quite a lot like "software policy", since the actual
display doesn't have these limitations. Rob, Krzysztof?
>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
>
> (no changes since v1)
Really?
https://lore.kernel.org/all/?q=dfn:st,stm32-ltdc.yaml%20
You sure this shouldn't be "new in v4"?
> .../devicetree/bindings/display/st,stm32-ltdc.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml b/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml
> index d6ea4d62a2cf..1c3a3653579f 100644
> --- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml
> +++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml
> @@ -42,6 +42,12 @@ properties:
> - for internal dpi input of the MIPI DSI host controller.
> Note: These 2 endpoints cannot be activated simultaneously.
>
> + st,fb-bpp:
Is there not a more understandable property name than this?
Maybe I just had to think about it because fbdev stuff aint something
I've worked with...
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + bit depth of framebuffer (8, 16 or 32)
> + maxItems: 1
Why not make it an enum, since there are only 4 values?
Cheers,
Conor.
> +
> required:
> - compatible
> - reg
> --
> 2.32.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v4 4/6] dt-bindings: display: stm32-ltdc: add optional st,fb-bpp property
2023-06-19 20:18 ` Conor Dooley
@ 2023-06-19 22:11 ` Rob Herring
0 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2023-06-19 22:11 UTC (permalink / raw)
To: Conor Dooley
Cc: Dario Binacchi, linux-kernel, Philippe Cornu,
Raphael Gallais-Pou, Amarula patchwork, michael,
Alexandre Torgue, Conor Dooley, Daniel Vetter, David Airlie,
Krzysztof Kozlowski, Maxime Coquelin, Yannick Fertre, devicetree,
dri-devel, linux-arm-kernel, linux-stm32
On Mon, Jun 19, 2023 at 09:18:25PM +0100, Conor Dooley wrote:
> Hey,
>
> On Mon, Jun 19, 2023 at 06:55:23PM +0200, Dario Binacchi wrote:
> > Boards that use the STM32F{4,7} series have limited amounts of RAM. The
> > added property allows to size, within certain limits, the memory footprint
> > required by the framebuffer.
>
> Hmm, this sounds quite a lot like "software policy", since the actual
> display doesn't have these limitations. Rob, Krzysztof?
Indeed. This doesn't belong in DT.
Rob
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-06-19 22:11 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-19 16:55 [PATCH v4 0/6] Add display support on the stm32f746-disco board Dario Binacchi
2023-06-19 16:55 ` [PATCH v4 1/6] ARM: dts: stm32: add ltdc support on stm32f746 MCU Dario Binacchi
2023-06-19 16:55 ` [PATCH v4 2/6] ARM: dts: stm32: add pin map for LTDC on stm32f7 Dario Binacchi
2023-06-19 16:55 ` [PATCH v4 3/6] ARM: dts: stm32: support display on stm32f746-disco board Dario Binacchi
2023-06-19 16:55 ` [PATCH v4 4/6] dt-bindings: display: stm32-ltdc: add optional st,fb-bpp property Dario Binacchi
2023-06-19 17:17 ` Rob Herring
2023-06-19 20:18 ` Conor Dooley
2023-06-19 22:11 ` Rob Herring
2023-06-19 16:55 ` [PATCH v4 5/6] ARM: dts: stm32: set framebuffer bit depth on stm32f746-disco Dario Binacchi
2023-06-19 16:55 ` [PATCH v4 6/6] drm/stm: set framebuffer bit depth through DTS property Dario Binacchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).