linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: mfd: ti,j721e-system-controller: Remove syscon from example
@ 2023-06-23 20:15 Andrew Davis
  2023-06-23 20:23 ` Rob Herring
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Andrew Davis @ 2023-06-23 20:15 UTC (permalink / raw)
  To: Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: linux-clk, devicetree, linux-kernel, Andrew Davis

The binding for ti,am654-ehrpwm-tbclk was updated to remove the syscon
compatible hint. Remove the same from the example in this binding.

Signed-off-by: Andrew Davis <afd@ti.com>
---
 .../devicetree/bindings/mfd/ti,j721e-system-controller.yaml     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
index 0c98d913747bb..e6289fbe69070 100644
--- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
+++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
@@ -101,7 +101,7 @@ examples:
         };
 
         clock-controller@4140 {
-            compatible = "ti,am654-ehrpwm-tbclk", "syscon";
+            compatible = "ti,am654-ehrpwm-tbclk";
             reg = <0x4140 0x18>;
             #clock-cells = <1>;
         };
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: mfd: ti,j721e-system-controller: Remove syscon from example
  2023-06-23 20:15 [PATCH] dt-bindings: mfd: ti,j721e-system-controller: Remove syscon from example Andrew Davis
@ 2023-06-23 20:23 ` Rob Herring
  2023-06-23 21:22 ` Rob Herring
  2023-06-26 23:37 ` Stephen Boyd
  2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2023-06-23 20:23 UTC (permalink / raw)
  To: Andrew Davis
  Cc: Stephen Boyd, Krzysztof Kozlowski, Conor Dooley, linux-clk,
	devicetree, linux-kernel

On Fri, Jun 23, 2023 at 2:15 PM Andrew Davis <afd@ti.com> wrote:
>
> The binding for ti,am654-ehrpwm-tbclk was updated to remove the syscon
> compatible hint. Remove the same from the example in this binding.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>  .../devicetree/bindings/mfd/ti,j721e-system-controller.yaml     | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for the quick fix.

Acked-by: Rob Herring <robh@kernel.org>

Stephen should apply this.

Rob

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: mfd: ti,j721e-system-controller: Remove syscon from example
  2023-06-23 20:15 [PATCH] dt-bindings: mfd: ti,j721e-system-controller: Remove syscon from example Andrew Davis
  2023-06-23 20:23 ` Rob Herring
@ 2023-06-23 21:22 ` Rob Herring
  2023-06-26 23:37 ` Stephen Boyd
  2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2023-06-23 21:22 UTC (permalink / raw)
  To: Andrew Davis
  Cc: Krzysztof Kozlowski, linux-kernel, devicetree, Rob Herring,
	Conor Dooley, linux-clk, Stephen Boyd


On Fri, 23 Jun 2023 15:15:19 -0500, Andrew Davis wrote:
> The binding for ti,am654-ehrpwm-tbclk was updated to remove the syscon
> compatible hint. Remove the same from the example in this binding.
> 
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>  .../devicetree/bindings/mfd/ti,j721e-system-controller.yaml     | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.example.dtb: scm-conf@100000: clock-controller@4140:compatible: ['ti,am654-ehrpwm-tbclk'] is too short
	from schema $id: http://devicetree.org/schemas/mfd/ti,j721e-system-controller.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.example.dtb: clock-controller@4140: compatible: ['ti,am654-ehrpwm-tbclk'] is too short
	from schema $id: http://devicetree.org/schemas/clock/ti,am654-ehrpwm-tbclk.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230623201519.194269-1-afd@ti.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: mfd: ti,j721e-system-controller: Remove syscon from example
  2023-06-23 20:15 [PATCH] dt-bindings: mfd: ti,j721e-system-controller: Remove syscon from example Andrew Davis
  2023-06-23 20:23 ` Rob Herring
  2023-06-23 21:22 ` Rob Herring
@ 2023-06-26 23:37 ` Stephen Boyd
  2 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2023-06-26 23:37 UTC (permalink / raw)
  To: Andrew Davis, Conor Dooley, Krzysztof Kozlowski, Rob Herring
  Cc: linux-clk, devicetree, linux-kernel, Andrew Davis

Quoting Andrew Davis (2023-06-23 13:15:19)
> The binding for ti,am654-ehrpwm-tbclk was updated to remove the syscon
> compatible hint. Remove the same from the example in this binding.
> 
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---

Applied to clk-next

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-06-26 23:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-23 20:15 [PATCH] dt-bindings: mfd: ti,j721e-system-controller: Remove syscon from example Andrew Davis
2023-06-23 20:23 ` Rob Herring
2023-06-23 21:22 ` Rob Herring
2023-06-26 23:37 ` Stephen Boyd

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).