linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] drm/amdgpu: clean up some inconsistent indentings
@ 2023-07-27  1:03 Yang Li
  2023-07-27 11:39 ` Christian König
  0 siblings, 1 reply; 4+ messages in thread
From: Yang Li @ 2023-07-27  1:03 UTC (permalink / raw)
  To: airlied, daniel
  Cc: christian.koenig, Xinhui.Pan, amd-gfx, dri-devel, linux-kernel,
	Yang Li, Abaci Robot

drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:622 amdgpu_gfx_enable_kcq() warn: inconsistent indenting

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5992
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
index c76b6bfc4dab..80a306b3d9f9 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
@@ -619,8 +619,7 @@ int amdgpu_gfx_enable_kcq(struct amdgpu_device *adev, int xcc_id)
 	kiq->pmf->kiq_set_resources(kiq_ring, queue_mask);
 	for (i = 0; i < adev->gfx.num_compute_rings; i++) {
 		j = i + xcc_id * adev->gfx.num_compute_rings;
-			kiq->pmf->kiq_map_queues(kiq_ring,
-						 &adev->gfx.compute_ring[j]);
+		kiq->pmf->kiq_map_queues(kiq_ring, &adev->gfx.compute_ring[j]);
 	}
 
 	r = amdgpu_ring_test_helper(kiq_ring);
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH -next] drm/amdgpu: clean up some inconsistent indentings
  2023-07-27  1:03 [PATCH -next] drm/amdgpu: clean up some inconsistent indentings Yang Li
@ 2023-07-27 11:39 ` Christian König
  0 siblings, 0 replies; 4+ messages in thread
From: Christian König @ 2023-07-27 11:39 UTC (permalink / raw)
  To: Yang Li, airlied, daniel
  Cc: Xinhui.Pan, amd-gfx, dri-devel, linux-kernel, Abaci Robot

Am 27.07.23 um 03:03 schrieb Yang Li:
> drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:622 amdgpu_gfx_enable_kcq() warn: inconsistent indenting
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5992
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> index c76b6bfc4dab..80a306b3d9f9 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> @@ -619,8 +619,7 @@ int amdgpu_gfx_enable_kcq(struct amdgpu_device *adev, int xcc_id)
>   	kiq->pmf->kiq_set_resources(kiq_ring, queue_mask);
>   	for (i = 0; i < adev->gfx.num_compute_rings; i++) {
>   		j = i + xcc_id * adev->gfx.num_compute_rings;
> -			kiq->pmf->kiq_map_queues(kiq_ring,
> -						 &adev->gfx.compute_ring[j]);
> +		kiq->pmf->kiq_map_queues(kiq_ring, &adev->gfx.compute_ring[j]);
>   	}
>   
>   	r = amdgpu_ring_test_helper(kiq_ring);


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH -next] drm/amdgpu: clean up some inconsistent indentings
  2023-01-06  1:32 Yang Li
@ 2023-01-06 15:30 ` Alex Deucher
  0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2023-01-06 15:30 UTC (permalink / raw)
  To: Yang Li
  Cc: alexander.deucher, Xinhui.Pan, Abaci Robot, linux-kernel,
	amd-gfx, dri-devel, christian.koenig

Applied.  Thanks!

Alex

On Thu, Jan 5, 2023 at 8:37 PM Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c:65 amdgpu_gem_fault() warn: inconsistent indenting
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3639
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> index 00edc7002ee8..ed1164a87fce 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> @@ -62,10 +62,10 @@ static vm_fault_t amdgpu_gem_fault(struct vm_fault *vmf)
>                         goto unlock;
>                 }
>
> -                ret = ttm_bo_vm_fault_reserved(vmf, vmf->vma->vm_page_prot,
> -                                               TTM_BO_VM_NUM_PREFAULT);
> +               ret = ttm_bo_vm_fault_reserved(vmf, vmf->vma->vm_page_prot,
> +                                              TTM_BO_VM_NUM_PREFAULT);
>
> -                drm_dev_exit(idx);
> +               drm_dev_exit(idx);
>         } else {
>                 ret = ttm_bo_vm_dummy_page(vmf, vmf->vma->vm_page_prot);
>         }
> --
> 2.20.1.7.g153144c
>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH -next] drm/amdgpu: clean up some inconsistent indentings
@ 2023-01-06  1:32 Yang Li
  2023-01-06 15:30 ` Alex Deucher
  0 siblings, 1 reply; 4+ messages in thread
From: Yang Li @ 2023-01-06  1:32 UTC (permalink / raw)
  To: alexander.deucher
  Cc: christian.koenig, Xinhui.Pan, airlied, daniel, amd-gfx,
	dri-devel, linux-kernel, Yang Li, Abaci Robot

drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c:65 amdgpu_gem_fault() warn: inconsistent indenting

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3639
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
index 00edc7002ee8..ed1164a87fce 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
@@ -62,10 +62,10 @@ static vm_fault_t amdgpu_gem_fault(struct vm_fault *vmf)
 			goto unlock;
 		}
 
-		 ret = ttm_bo_vm_fault_reserved(vmf, vmf->vma->vm_page_prot,
-						TTM_BO_VM_NUM_PREFAULT);
+		ret = ttm_bo_vm_fault_reserved(vmf, vmf->vma->vm_page_prot,
+					       TTM_BO_VM_NUM_PREFAULT);
 
-		 drm_dev_exit(idx);
+		drm_dev_exit(idx);
 	} else {
 		ret = ttm_bo_vm_dummy_page(vmf, vmf->vma->vm_page_prot);
 	}
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-27 11:39 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-27  1:03 [PATCH -next] drm/amdgpu: clean up some inconsistent indentings Yang Li
2023-07-27 11:39 ` Christian König
  -- strict thread matches above, loose matches on Subject: below --
2023-01-06  1:32 Yang Li
2023-01-06 15:30 ` Alex Deucher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).