* [PATCH] hid: Add "Hailuck" to the list of non-apple apple keyboards
@ 2023-08-11 20:29 Nils Tonnaett
2023-08-14 5:11 ` Rahul Rameshbabu
2023-08-15 20:19 ` [PATCH v2] HID: apple: Add "Hailuck" to the list of non-apple keyboards Nils Tonnaett
0 siblings, 2 replies; 5+ messages in thread
From: Nils Tonnaett @ 2023-08-11 20:29 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires, linux-input, linux-kernel; +Cc: Nils Tonnaett
Powzan keyboards KB750 and KB770 identify as
"Hailuck Co.,Ltd USB Keyboard". Adding "Hailuck" to the list
of non-apple apple keyboards fixes function keys for these models.
Signed-off-by: Nils Tonnaett <ntonnatt@ccrma.stanford.edu>
---
drivers/hid/hid-apple.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
index d7b932925730..6664f90cecaf 100644
--- a/drivers/hid/hid-apple.c
+++ b/drivers/hid/hid-apple.c
@@ -343,7 +343,8 @@ static const struct apple_non_apple_keyboard non_apple_keyboards[] = {
{ "SONiX USB DEVICE" },
{ "Keychron" },
{ "AONE" },
- { "GANSS" }
+ { "GANSS" },
+ { "Hailuck" }
};
static bool apple_is_non_apple_keyboard(struct hid_device *hdev)
--
2.41.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] hid: Add "Hailuck" to the list of non-apple apple keyboards
2023-08-11 20:29 [PATCH] hid: Add "Hailuck" to the list of non-apple apple keyboards Nils Tonnaett
@ 2023-08-14 5:11 ` Rahul Rameshbabu
2023-08-15 20:19 ` [PATCH v2] HID: apple: Add "Hailuck" to the list of non-apple keyboards Nils Tonnaett
1 sibling, 0 replies; 5+ messages in thread
From: Rahul Rameshbabu @ 2023-08-14 5:11 UTC (permalink / raw)
To: Nils Tonnaett; +Cc: Jiri Kosina, Benjamin Tissoires, linux-input, linux-kernel
On Fri, 11 Aug, 2023 13:29:31 -0700 "Nils Tonnaett" <ntonnatt@ccrma.Stanford.EDU> wrote:
> Powzan keyboards KB750 and KB770 identify as
> "Hailuck Co.,Ltd USB Keyboard". Adding "Hailuck" to the list
> of non-apple apple keyboards fixes function keys for these models.
>
> Signed-off-by: Nils Tonnaett <ntonnatt@ccrma.stanford.edu>
> ---
You will likely want to resubmit this patch using "HID: apple:" in
place of "hid:" in the commit message subject.
https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/log/drivers/hid/hid-apple.c
> drivers/hid/hid-apple.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
> index d7b932925730..6664f90cecaf 100644
> --- a/drivers/hid/hid-apple.c
> +++ b/drivers/hid/hid-apple.c
> @@ -343,7 +343,8 @@ static const struct apple_non_apple_keyboard non_apple_keyboards[] = {
> { "SONiX USB DEVICE" },
> { "Keychron" },
> { "AONE" },
> - { "GANSS" }
> + { "GANSS" },
> + { "Hailuck" }
This isn't a must, but maybe it makes sense to comma terminate the last
member in this array specifically if you will be resubmitting this
change as a v2. This way, future keyboards added will only touch one
line in the patch rather than two.
> };
>
> static bool apple_is_non_apple_keyboard(struct hid_device *hdev)
--
Thanks,
Rahul Rameshbabu
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] HID: apple: Add "Hailuck" to the list of non-apple keyboards
2023-08-11 20:29 [PATCH] hid: Add "Hailuck" to the list of non-apple apple keyboards Nils Tonnaett
2023-08-14 5:11 ` Rahul Rameshbabu
@ 2023-08-15 20:19 ` Nils Tonnaett
2023-08-16 2:23 ` Rahul Rameshbabu
2023-08-16 13:21 ` Jiri Kosina
1 sibling, 2 replies; 5+ messages in thread
From: Nils Tonnaett @ 2023-08-15 20:19 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires, linux-input, linux-kernel
Cc: Rahul Rameshbabu, Nils Tonnaett
Powzan keyboards KB750 and KB770 identify as
"Hailuck Co.,Ltd USB Keyboard". Adding "Hailuck" to the list
of non-apple keyboards fixes function keys for these models.
Signed-off-by: Nils Tonnaett <ntonnatt@ccrma.stanford.edu>
---
V1 -> V2:
- Start commit message subject with HID: apple: instead of hid:
- Comma terminate last member of array
drivers/hid/hid-apple.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
index d7b932925730..3ca45975c686 100644
--- a/drivers/hid/hid-apple.c
+++ b/drivers/hid/hid-apple.c
@@ -343,7 +343,8 @@ static const struct apple_non_apple_keyboard non_apple_keyboards[] = {
{ "SONiX USB DEVICE" },
{ "Keychron" },
{ "AONE" },
- { "GANSS" }
+ { "GANSS" },
+ { "Hailuck" },
};
static bool apple_is_non_apple_keyboard(struct hid_device *hdev)
--
2.41.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] HID: apple: Add "Hailuck" to the list of non-apple keyboards
2023-08-15 20:19 ` [PATCH v2] HID: apple: Add "Hailuck" to the list of non-apple keyboards Nils Tonnaett
@ 2023-08-16 2:23 ` Rahul Rameshbabu
2023-08-16 13:21 ` Jiri Kosina
1 sibling, 0 replies; 5+ messages in thread
From: Rahul Rameshbabu @ 2023-08-16 2:23 UTC (permalink / raw)
To: Nils Tonnaett; +Cc: Jiri Kosina, Benjamin Tissoires, linux-input, linux-kernel
On Tue, 15 Aug, 2023 13:19:59 -0700 "Nils Tonnaett" <ntonnatt@ccrma.Stanford.EDU> wrote:
> Powzan keyboards KB750 and KB770 identify as
> "Hailuck Co.,Ltd USB Keyboard". Adding "Hailuck" to the list
> of non-apple keyboards fixes function keys for these models.
>
> Signed-off-by: Nils Tonnaett <ntonnatt@ccrma.stanford.edu>
> ---
> V1 -> V2:
> - Start commit message subject with HID: apple: instead of hid:
> - Comma terminate last member of array
>
> drivers/hid/hid-apple.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
> index d7b932925730..3ca45975c686 100644
> --- a/drivers/hid/hid-apple.c
> +++ b/drivers/hid/hid-apple.c
> @@ -343,7 +343,8 @@ static const struct apple_non_apple_keyboard non_apple_keyboards[] = {
> { "SONiX USB DEVICE" },
> { "Keychron" },
> { "AONE" },
> - { "GANSS" }
> + { "GANSS" },
> + { "Hailuck" },
> };
>
> static bool apple_is_non_apple_keyboard(struct hid_device *hdev)
Reviewed-by: Rahul Rameshbabu <sergeantsagara@protonmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] HID: apple: Add "Hailuck" to the list of non-apple keyboards
2023-08-15 20:19 ` [PATCH v2] HID: apple: Add "Hailuck" to the list of non-apple keyboards Nils Tonnaett
2023-08-16 2:23 ` Rahul Rameshbabu
@ 2023-08-16 13:21 ` Jiri Kosina
1 sibling, 0 replies; 5+ messages in thread
From: Jiri Kosina @ 2023-08-16 13:21 UTC (permalink / raw)
To: Nils Tonnaett
Cc: Benjamin Tissoires, linux-input, linux-kernel, Rahul Rameshbabu
On Tue, 15 Aug 2023, Nils Tonnaett wrote:
> Powzan keyboards KB750 and KB770 identify as
> "Hailuck Co.,Ltd USB Keyboard". Adding "Hailuck" to the list
> of non-apple keyboards fixes function keys for these models.
>
> Signed-off-by: Nils Tonnaett <ntonnatt@ccrma.stanford.edu>
> ---
> V1 -> V2:
> - Start commit message subject with HID: apple: instead of hid:
> - Comma terminate last member of array
>
> drivers/hid/hid-apple.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
> index d7b932925730..3ca45975c686 100644
> --- a/drivers/hid/hid-apple.c
> +++ b/drivers/hid/hid-apple.c
> @@ -343,7 +343,8 @@ static const struct apple_non_apple_keyboard non_apple_keyboards[] = {
> { "SONiX USB DEVICE" },
> { "Keychron" },
> { "AONE" },
> - { "GANSS" }
> + { "GANSS" },
> + { "Hailuck" },
> };
Applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-16 13:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-11 20:29 [PATCH] hid: Add "Hailuck" to the list of non-apple apple keyboards Nils Tonnaett
2023-08-14 5:11 ` Rahul Rameshbabu
2023-08-15 20:19 ` [PATCH v2] HID: apple: Add "Hailuck" to the list of non-apple keyboards Nils Tonnaett
2023-08-16 2:23 ` Rahul Rameshbabu
2023-08-16 13:21 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).