* linux-next-2023-0815: s390/block/dasd: build error
@ 2023-08-16 5:34 Randy Dunlap
2023-08-16 7:03 ` Sven Schnelle
2023-08-16 7:14 ` Stephen Rothwell
0 siblings, 2 replies; 4+ messages in thread
From: Randy Dunlap @ 2023-08-16 5:34 UTC (permalink / raw)
To: linux-kernel, linux-next, linux-kbuild, Masahiro Yamada
Cc: linux-s390, Stefan Haberland, Jan Hoeppner
[-- Attachment #1: Type: text/plain, Size: 298 bytes --]
I have spent some time on this but I don't see where the problem is.
ERROR: modpost: "bdev_mark_dead" [drivers/s390/block/dasd_mod.ko] undefined!
CONFIG_BLOCK=y, bdev.o is built and contains the missing symbol.
Full randconfig file is attached.
Hopefully I'm just overlooking something.
~Randy
[-- Attachment #2: config-r5177.gz --]
[-- Type: application/gzip, Size: 19900 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next-2023-0815: s390/block/dasd: build error
2023-08-16 5:34 linux-next-2023-0815: s390/block/dasd: build error Randy Dunlap
@ 2023-08-16 7:03 ` Sven Schnelle
2023-08-16 7:14 ` Stephen Rothwell
1 sibling, 0 replies; 4+ messages in thread
From: Sven Schnelle @ 2023-08-16 7:03 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, linux-next, linux-kbuild, Masahiro Yamada,
linux-s390, Stefan Haberland, Jan Hoeppner, Christoph Hellwig
Randy Dunlap <rdunlap@infradead.org> writes:
> I have spent some time on this but I don't see where the problem is.
>
> ERROR: modpost: "bdev_mark_dead" [drivers/s390/block/dasd_mod.ko] undefined!
>
> CONFIG_BLOCK=y, bdev.o is built and contains the missing symbol.
>
> Full randconfig file is attached.
>
> Hopefully I'm just overlooking something.
The EXPORT_SYMBOL_GPL is surrounded by #ifdef CONFIG_DASD, but i think
it should be '#ifdef CONFIG_DASD_MODULE'. This was introduced by
381f678306ce ("block: consolidate __invalidate_device and fsync_bdev")
There was already a thread about this:
https://www.spinics.net/lists/linux-btrfs/msg138633.html
regards,
Sven
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next-2023-0815: s390/block/dasd: build error
2023-08-16 5:34 linux-next-2023-0815: s390/block/dasd: build error Randy Dunlap
2023-08-16 7:03 ` Sven Schnelle
@ 2023-08-16 7:14 ` Stephen Rothwell
2023-08-16 8:11 ` Christian Brauner
1 sibling, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2023-08-16 7:14 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, linux-next, linux-kbuild, Masahiro Yamada,
linux-s390, Stefan Haberland, Jan Hoeppner, Christian Brauner,
Christoph Hellwig
[-- Attachment #1: Type: text/plain, Size: 852 bytes --]
Hi Randy,
On Tue, 15 Aug 2023 22:34:19 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
>
> I have spent some time on this but I don't see where the problem is.
>
> ERROR: modpost: "bdev_mark_dead" [drivers/s390/block/dasd_mod.ko] undefined!
>
> CONFIG_BLOCK=y, bdev.o is built and contains the missing symbol.
>
> Full randconfig file is attached.
>
> Hopefully I'm just overlooking something.
In your config, CONFIG_DASD=m which means "#ifdef CONFIG_DASD" will
fail since CONFIG_DASD_MODULE is defined instead ... so maybe it should
be "#if IS_ENABLED(CONFIG_DASD)" in block/bdev.c. This also fails an
s390 allmodconfig build (obviously).
So this is caused by commit
381f678306ce ("block: consolidate __invalidate_device and fsync_bdev")
from the vfs-brauner branch in linux-next.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next-2023-0815: s390/block/dasd: build error
2023-08-16 7:14 ` Stephen Rothwell
@ 2023-08-16 8:11 ` Christian Brauner
0 siblings, 0 replies; 4+ messages in thread
From: Christian Brauner @ 2023-08-16 8:11 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Randy Dunlap, linux-kernel, linux-next, linux-kbuild,
Masahiro Yamada, linux-s390, Stefan Haberland, Jan Hoeppner,
Christoph Hellwig
On Wed, Aug 16, 2023 at 05:14:39PM +1000, Stephen Rothwell wrote:
> Hi Randy,
>
> On Tue, 15 Aug 2023 22:34:19 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > I have spent some time on this but I don't see where the problem is.
> >
> > ERROR: modpost: "bdev_mark_dead" [drivers/s390/block/dasd_mod.ko] undefined!
> >
> > CONFIG_BLOCK=y, bdev.o is built and contains the missing symbol.
> >
> > Full randconfig file is attached.
> >
> > Hopefully I'm just overlooking something.
>
> In your config, CONFIG_DASD=m which means "#ifdef CONFIG_DASD" will
> fail since CONFIG_DASD_MODULE is defined instead ... so maybe it should
> be "#if IS_ENABLED(CONFIG_DASD)" in block/bdev.c. This also fails an
> s390 allmodconfig build (obviously).
>
> So this is caused by commit
>
> 381f678306ce ("block: consolidate __invalidate_device and fsync_bdev")
>
> from the vfs-brauner branch in linux-next.
Thanks for reporting this everyone. Fixed in-tree.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-16 8:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-16 5:34 linux-next-2023-0815: s390/block/dasd: build error Randy Dunlap
2023-08-16 7:03 ` Sven Schnelle
2023-08-16 7:14 ` Stephen Rothwell
2023-08-16 8:11 ` Christian Brauner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).