* [PATCH 1/3] rtc: sun6i: remove unnecessary message
@ 2023-08-27 22:16 alexandre.belloni
2023-08-27 22:16 ` [PATCH 2/3] rtc: twl: remove unnecessary messages alexandre.belloni
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: alexandre.belloni @ 2023-08-27 22:16 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland
Cc: linux-rtc, linux-arm-kernel, linux-sunxi, linux-kernel
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
The core already print a message once the rtc is successfully registered,
it is not necessary to print an other one.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
drivers/rtc/rtc-sun6i.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c
index 753a2d9c8a17..8e0c66906103 100644
--- a/drivers/rtc/rtc-sun6i.c
+++ b/drivers/rtc/rtc-sun6i.c
@@ -846,8 +846,6 @@ static int sun6i_rtc_probe(struct platform_device *pdev)
if (ret)
return ret;
- dev_info(&pdev->dev, "RTC enabled\n");
-
return 0;
}
--
2.41.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/3] rtc: twl: remove unnecessary messages
2023-08-27 22:16 [PATCH 1/3] rtc: sun6i: remove unnecessary message alexandre.belloni
@ 2023-08-27 22:16 ` alexandre.belloni
2023-08-27 22:16 ` [PATCH 3/3] rtc: wm8350: " alexandre.belloni
2023-09-05 20:31 ` [PATCH 1/3] rtc: sun6i: remove unnecessary message Jernej Škrabec
2 siblings, 0 replies; 5+ messages in thread
From: alexandre.belloni @ 2023-08-27 22:16 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni; +Cc: linux-rtc, linux-kernel
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
The RTC core already prints a message when the RTC is registered and when
registering fails, it is not necessary to have more in the driver.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
drivers/rtc/rtc-twl.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c
index f8f0d774a06e..13f8ce08243c 100644
--- a/drivers/rtc/rtc-twl.c
+++ b/drivers/rtc/rtc-twl.c
@@ -555,7 +555,6 @@ static int twl_rtc_probe(struct platform_device *pdev)
REG_INT_MSK_STS_A);
}
- dev_info(&pdev->dev, "Enabling TWL-RTC\n");
ret = twl_rtc_write_u8(twl_rtc, BIT_RTC_CTRL_REG_STOP_RTC_M,
REG_RTC_CTRL_REG);
if (ret < 0)
@@ -577,11 +576,8 @@ static int twl_rtc_probe(struct platform_device *pdev)
twl_rtc->rtc = devm_rtc_device_register(&pdev->dev, pdev->name,
&twl_rtc_ops, THIS_MODULE);
- if (IS_ERR(twl_rtc->rtc)) {
- dev_err(&pdev->dev, "can't register RTC device, err %ld\n",
- PTR_ERR(twl_rtc->rtc));
+ if (IS_ERR(twl_rtc->rtc))
return PTR_ERR(twl_rtc->rtc);
- }
ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
twl_rtc_interrupt,
--
2.41.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 3/3] rtc: wm8350: remove unnecessary messages
2023-08-27 22:16 [PATCH 1/3] rtc: sun6i: remove unnecessary message alexandre.belloni
2023-08-27 22:16 ` [PATCH 2/3] rtc: twl: remove unnecessary messages alexandre.belloni
@ 2023-08-27 22:16 ` alexandre.belloni
2023-08-28 8:16 ` Charles Keepax
2023-09-05 20:31 ` [PATCH 1/3] rtc: sun6i: remove unnecessary message Jernej Škrabec
2 siblings, 1 reply; 5+ messages in thread
From: alexandre.belloni @ 2023-08-27 22:16 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni; +Cc: patches, linux-rtc, linux-kernel
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
The RTC core already prints a message when the RTC is registered and when
registering fails, it is not necessary to have more in the driver.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
drivers/rtc/rtc-wm8350.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/rtc/rtc-wm8350.c b/drivers/rtc/rtc-wm8350.c
index 947f8071803f..3c773cff2b39 100644
--- a/drivers/rtc/rtc-wm8350.c
+++ b/drivers/rtc/rtc-wm8350.c
@@ -386,8 +386,6 @@ static int wm8350_rtc_probe(struct platform_device *pdev)
/* enable the RTC if it's not already enabled */
power5 = wm8350_reg_read(wm8350, WM8350_POWER_MGMT_5);
if (!(power5 & WM8350_RTC_TICK_ENA)) {
- dev_info(wm8350->dev, "Starting RTC\n");
-
wm8350_reg_unlock(wm8350);
ret = wm8350_set_bits(wm8350, WM8350_POWER_MGMT_5,
@@ -426,11 +424,8 @@ static int wm8350_rtc_probe(struct platform_device *pdev)
wm_rtc->rtc = devm_rtc_device_register(&pdev->dev, "wm8350",
&wm8350_rtc_ops, THIS_MODULE);
- if (IS_ERR(wm_rtc->rtc)) {
- ret = PTR_ERR(wm_rtc->rtc);
- dev_err(&pdev->dev, "failed to register RTC: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(wm_rtc->rtc))
+ return PTR_ERR(wm_rtc->rtc);
ret = wm8350_register_irq(wm8350, WM8350_IRQ_RTC_SEC,
wm8350_rtc_update_handler, 0,
--
2.41.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 3/3] rtc: wm8350: remove unnecessary messages
2023-08-27 22:16 ` [PATCH 3/3] rtc: wm8350: " alexandre.belloni
@ 2023-08-28 8:16 ` Charles Keepax
0 siblings, 0 replies; 5+ messages in thread
From: Charles Keepax @ 2023-08-28 8:16 UTC (permalink / raw)
To: alexandre.belloni; +Cc: Alessandro Zummo, patches, linux-rtc, linux-kernel
On Mon, Aug 28, 2023 at 12:16:42AM +0200, alexandre.belloni@bootlin.com wrote:
> From: Alexandre Belloni <alexandre.belloni@bootlin.com>
>
> The RTC core already prints a message when the RTC is registered and when
> registering fails, it is not necessary to have more in the driver.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/3] rtc: sun6i: remove unnecessary message
2023-08-27 22:16 [PATCH 1/3] rtc: sun6i: remove unnecessary message alexandre.belloni
2023-08-27 22:16 ` [PATCH 2/3] rtc: twl: remove unnecessary messages alexandre.belloni
2023-08-27 22:16 ` [PATCH 3/3] rtc: wm8350: " alexandre.belloni
@ 2023-09-05 20:31 ` Jernej Škrabec
2 siblings, 0 replies; 5+ messages in thread
From: Jernej Škrabec @ 2023-09-05 20:31 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni, Chen-Yu Tsai,
Samuel Holland, alexandre.belloni
Cc: linux-rtc, linux-arm-kernel, linux-sunxi, linux-kernel
On Monday, August 28, 2023 12:16:40 AM CEST alexandre.belloni@bootlin.com
wrote:
> From: Alexandre Belloni <alexandre.belloni@bootlin.com>
>
> The core already print a message once the rtc is successfully registered,
> it is not necessary to print an other one.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
> ---
> drivers/rtc/rtc-sun6i.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c
> index 753a2d9c8a17..8e0c66906103 100644
> --- a/drivers/rtc/rtc-sun6i.c
> +++ b/drivers/rtc/rtc-sun6i.c
> @@ -846,8 +846,6 @@ static int sun6i_rtc_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - dev_info(&pdev->dev, "RTC enabled\n");
> -
> return 0;
> }
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-09-05 20:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-27 22:16 [PATCH 1/3] rtc: sun6i: remove unnecessary message alexandre.belloni
2023-08-27 22:16 ` [PATCH 2/3] rtc: twl: remove unnecessary messages alexandre.belloni
2023-08-27 22:16 ` [PATCH 3/3] rtc: wm8350: " alexandre.belloni
2023-08-28 8:16 ` Charles Keepax
2023-09-05 20:31 ` [PATCH 1/3] rtc: sun6i: remove unnecessary message Jernej Škrabec
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).