* [PATCH] mm: fix unaccount of memory on vma_link() failure
@ 2023-08-30 0:43 Anthony Yznaga
2023-09-05 13:12 ` Liam R. Howlett
0 siblings, 1 reply; 2+ messages in thread
From: Anthony Yznaga @ 2023-08-30 0:43 UTC (permalink / raw)
To: linux-mm, linux-kernel; +Cc: akpm, Liam.Howlett, willy
Fix insert_vm_struct() so that only accounted memory is unaccounted
if vma_link() fails.
Fixes: d4af56c5c7c6 ("mm: start tracking VMAs with maple tree")
Signed-off-by: Anthony Yznaga <anthony.yznaga@oracle.com>
---
mm/mmap.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/mm/mmap.c b/mm/mmap.c
index 514ced13c65c..f8c084017757 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -3278,7 +3278,8 @@ int insert_vm_struct(struct mm_struct *mm, struct vm_area_struct *vma)
}
if (vma_link(mm, vma)) {
- vm_unacct_memory(charged);
+ if (vma->vm_flags & VM_ACCOUNT)
+ vm_unacct_memory(charged);
return -ENOMEM;
}
--
2.39.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm: fix unaccount of memory on vma_link() failure
2023-08-30 0:43 [PATCH] mm: fix unaccount of memory on vma_link() failure Anthony Yznaga
@ 2023-09-05 13:12 ` Liam R. Howlett
0 siblings, 0 replies; 2+ messages in thread
From: Liam R. Howlett @ 2023-09-05 13:12 UTC (permalink / raw)
To: Anthony Yznaga; +Cc: linux-mm, linux-kernel, akpm, willy
* Anthony Yznaga <anthony.yznaga@oracle.com> [230829 20:43]:
> Fix insert_vm_struct() so that only accounted memory is unaccounted
> if vma_link() fails.
>
> Fixes: d4af56c5c7c6 ("mm: start tracking VMAs with maple tree")
> Signed-off-by: Anthony Yznaga <anthony.yznaga@oracle.com>
Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> ---
> mm/mmap.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/mm/mmap.c b/mm/mmap.c
> index 514ced13c65c..f8c084017757 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -3278,7 +3278,8 @@ int insert_vm_struct(struct mm_struct *mm, struct vm_area_struct *vma)
> }
>
> if (vma_link(mm, vma)) {
> - vm_unacct_memory(charged);
> + if (vma->vm_flags & VM_ACCOUNT)
> + vm_unacct_memory(charged);
> return -ENOMEM;
> }
>
> --
> 2.39.3
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-05 16:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-30 0:43 [PATCH] mm: fix unaccount of memory on vma_link() failure Anthony Yznaga
2023-09-05 13:12 ` Liam R. Howlett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).