* [PATCH 1/1] selftests/mm: include mman header to access MREMAP_DONTUNMAP identifier
@ 2023-10-12 6:40 Samasth Norway Ananda
2023-10-12 8:06 ` Muhammad Usama Anjum
0 siblings, 1 reply; 4+ messages in thread
From: Samasth Norway Ananda @ 2023-10-12 6:40 UTC (permalink / raw)
To: akpm, shuah, usama.anjum
Cc: linux-mm, linux-kselftest, linux-kernel, samasth.norway.ananda
Definition for MREMAP_DONTUNMAP not present in the selftest for
mremap_dontunmap thus throwing an undeclared error when running make
on mm.
Fixes: 0183d777c29a ("selftests: mm: remove duplicate unneeded defines")
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Closes: https://lore.kernel.org/linux-mm/CA+G9fYvV-71XqpCr_jhdDfEtN701fBdG3q+=bafaZiGwUXy_aA@mail.gmail.com/
Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@oracle.com>
---
tools/testing/selftests/mm/mremap_dontunmap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/mm/mremap_dontunmap.c b/tools/testing/selftests/mm/mremap_dontunmap.c
index ca2359835e75..a06e73ec8568 100644
--- a/tools/testing/selftests/mm/mremap_dontunmap.c
+++ b/tools/testing/selftests/mm/mremap_dontunmap.c
@@ -7,6 +7,7 @@
*/
#define _GNU_SOURCE
#include <sys/mman.h>
+#include <linux/mman.h>
#include <errno.h>
#include <stdio.h>
#include <stdlib.h>
--
2.42.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] selftests/mm: include mman header to access MREMAP_DONTUNMAP identifier
2023-10-12 6:40 [PATCH 1/1] selftests/mm: include mman header to access MREMAP_DONTUNMAP identifier Samasth Norway Ananda
@ 2023-10-12 8:06 ` Muhammad Usama Anjum
2023-10-12 8:17 ` Muhammad Usama Anjum
2023-10-12 12:05 ` [External] : " samasth.norway.ananda
0 siblings, 2 replies; 4+ messages in thread
From: Muhammad Usama Anjum @ 2023-10-12 8:06 UTC (permalink / raw)
To: Samasth Norway Ananda, akpm, shuah
Cc: Muhammad Usama Anjum, linux-mm, linux-kselftest, linux-kernel
On 10/12/23 11:40 AM, Samasth Norway Ananda wrote:
> Definition for MREMAP_DONTUNMAP not present in the selftest for
> mremap_dontunmap thus throwing an undeclared error when running make
> on mm.
Thanks for sending the patch.
You have mentioned in other email that MREMAP_DONTUNMAP isn't present in
glibc older than 2.32. So including linux/mman.h solves the build error for
people having older glibc. Please add this to the description of the patch
to give the exact reason this patch should be accepted.
>
> Fixes: 0183d777c29a ("selftests: mm: remove duplicate unneeded defines")
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> Closes: https://lore.kernel.org/linux-mm/CA+G9fYvV-71XqpCr_jhdDfEtN701fBdG3q+=bafaZiGwUXy_aA@mail.gmail.com/
> Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@oracle.com>
> ---
> tools/testing/selftests/mm/mremap_dontunmap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/mm/mremap_dontunmap.c b/tools/testing/selftests/mm/mremap_dontunmap.c
> index ca2359835e75..a06e73ec8568 100644
> --- a/tools/testing/selftests/mm/mremap_dontunmap.c
> +++ b/tools/testing/selftests/mm/mremap_dontunmap.c
> @@ -7,6 +7,7 @@
> */
> #define _GNU_SOURCE
> #include <sys/mman.h>
> +#include <linux/mman.h>
> #include <errno.h>
> #include <stdio.h>
> #include <stdlib.h>
Tested-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
--
BR,
Muhammad Usama Anjum
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] selftests/mm: include mman header to access MREMAP_DONTUNMAP identifier
2023-10-12 8:06 ` Muhammad Usama Anjum
@ 2023-10-12 8:17 ` Muhammad Usama Anjum
2023-10-12 12:05 ` [External] : " samasth.norway.ananda
1 sibling, 0 replies; 4+ messages in thread
From: Muhammad Usama Anjum @ 2023-10-12 8:17 UTC (permalink / raw)
To: Samasth Norway Ananda, akpm, shuah
Cc: Muhammad Usama Anjum, linux-mm, linux-kselftest, linux-kernel
On 10/12/23 1:06 PM, Muhammad Usama Anjum wrote:
> On 10/12/23 11:40 AM, Samasth Norway Ananda wrote:
>> Definition for MREMAP_DONTUNMAP not present in the selftest for
>> mremap_dontunmap thus throwing an undeclared error when running make
>> on mm.
> Thanks for sending the patch.
>
> You have mentioned in other email that MREMAP_DONTUNMAP isn't present in
> glibc older than 2.32. So including linux/mman.h solves the build error for
> people having older glibc. Please add this to the description of the patch
> to give the exact reason this patch should be accepted.
>
>>
>> Fixes: 0183d777c29a ("selftests: mm: remove duplicate unneeded defines")
>> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>> Closes: https://lore.kernel.org/linux-mm/CA+G9fYvV-71XqpCr_jhdDfEtN701fBdG3q+=bafaZiGwUXy_aA@mail.gmail.com/
>> Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@oracle.com>
>> ---
>> tools/testing/selftests/mm/mremap_dontunmap.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/testing/selftests/mm/mremap_dontunmap.c b/tools/testing/selftests/mm/mremap_dontunmap.c
>> index ca2359835e75..a06e73ec8568 100644
>> --- a/tools/testing/selftests/mm/mremap_dontunmap.c
>> +++ b/tools/testing/selftests/mm/mremap_dontunmap.c
>> @@ -7,6 +7,7 @@
>> */
>> #define _GNU_SOURCE
>> #include <sys/mman.h>
>> +#include <linux/mman.h>
>> #include <errno.h>
>> #include <stdio.h>
>> #include <stdlib.h>
> Tested-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Just to add more context, the build error doesn't trigger on latest glibc.
I've tested building this test with glic 2.31 and there is build error.
This patch fixes the build error.
>
--
BR,
Muhammad Usama Anjum
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [External] : Re: [PATCH 1/1] selftests/mm: include mman header to access MREMAP_DONTUNMAP identifier
2023-10-12 8:06 ` Muhammad Usama Anjum
2023-10-12 8:17 ` Muhammad Usama Anjum
@ 2023-10-12 12:05 ` samasth.norway.ananda
1 sibling, 0 replies; 4+ messages in thread
From: samasth.norway.ananda @ 2023-10-12 12:05 UTC (permalink / raw)
To: Muhammad Usama Anjum, akpm, shuah; +Cc: linux-mm, linux-kselftest, linux-kernel
On 10/12/23 1:06 AM, Muhammad Usama Anjum wrote:
> You have mentioned in other email that MREMAP_DONTUNMAP isn't present in
> glibc older than 2.32. So including linux/mman.h solves the build error for
> people having older glibc. Please add this to the description of the patch
> to give the exact reason this patch should be accepted.
>
Thanks Usama. I will send out a v2 patch with updated description as you
suggested.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-12 12:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-12 6:40 [PATCH 1/1] selftests/mm: include mman header to access MREMAP_DONTUNMAP identifier Samasth Norway Ananda
2023-10-12 8:06 ` Muhammad Usama Anjum
2023-10-12 8:17 ` Muhammad Usama Anjum
2023-10-12 12:05 ` [External] : " samasth.norway.ananda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).